[jira] Created: (OFBIZ-2379) Encrypt EFT Account number

[Nicolas Malin (Jira)]

Encrypt EFT Account number
--------------------------

                 Key: OFBIZ-2379
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2379
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Wickersheimer Jeremy
            Priority: Minor
             Fix For: SVN trunk


Account numbers could be encrypted just like credit card numbers.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-2379:
----------------------------------------

    Attachment: 2379.patch

A patch for the entity definition

> Encrypt EFT Account number
> --------------------------
>
>                 Key: OFBIZ-2379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2379
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 2379.patch
>
>
> Account numbers could be encrypted just like credit card numbers.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2379:
--------------------------------------

    Assignee: Jacques Le Roux

> Encrypt EFT Account number
> --------------------------
>
>                 Key: OFBIZ-2379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2379
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 2379.patch
>
>
> Account numbers could be encrypted just like credit card numbers.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707711#action_12707711 ]

Jacques Le Roux commented on OFBIZ-2379:
----------------------------------------

I will commit this change if nobody see a problem with that (someone needing acountnumber not encrypted for instance ?)

> Encrypt EFT Account number
> --------------------------
>
>                 Key: OFBIZ-2379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2379
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 2379.patch
>
>
> Account numbers could be encrypted just like credit card numbers.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707728#action_12707728 ]

Hans Bakker commented on OFBIZ-2379:
------------------------------------

i do not agree with this. In general, bank accounts numbers are public and there is no need to encrypt them. Mostly this number is printed on an invoice sent to a customer in order for him to be able to make a bank transfer.

regards,
Hans

> Encrypt EFT Account number
> --------------------------
>
>                 Key: OFBIZ-2379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2379
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 2379.patch
>
>
> Account numbers could be encrypted just like credit card numbers.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707757#action_12707757 ]

David E. Jones commented on OFBIZ-2379:
---------------------------------------

Thanks Hans, that's a good point.

For a reason why to NOT encrypt it: if it is encrypted we cannot have the database do a query on that field, so we can't effectively search it without going through EVERY record, decrypting, and then doing the compare.

> Encrypt EFT Account number
> --------------------------
>
>                 Key: OFBIZ-2379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2379
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 2379.patch
>
>
> Account numbers could be encrypted just like credit card numbers.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2379.
----------------------------------

    Resolution: Won't Fix
      Assignee: Hans Bakker  (was: Jacques Le Roux)

Hans, David,

I was suspecting something like this and was playing devil's advocate; so now it's clear, thanks!

> Encrypt EFT Account number
> --------------------------
>
>                 Key: OFBIZ-2379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2379
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Hans Bakker
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 2379.patch
>
>
> Account numbers could be encrypted just like credit card numbers.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.