OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-238) POS Multiple bar code product match

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-238) POS Multiple bar code product match

POS Multiple bar code product match
-----------------------------------

Key: OFBIZ-238
URL: http://issues.apache.org/jira/browse/OFBIZ-238
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: pos
Reporter: Jacques Le Roux
Assigned To: Jacques Le Roux

If one or more product ids are found when searching for a SKU the system presently falls out with a "Product Not Found" error dialog.

The improvement here is to add a new dialog that will present the search results to the user in a list for selection into the basket or to cancel if desired.

The list should contain product code, name and price. Each row should have enough height to ensure easy and accurate selection with a touch screen and the list should be scrollable when necessary.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-238) POS Multiple bar code product match

[ http://issues.apache.org/jira/browse/OFBIZ-238?page=comments#action_12445141 ]

Iain Fogg commented on OFBIZ-238:
---------------------------------

Jacques,

Came across this one myself but the context is a little different (I agree with the Jira BTW).

My use case is a little different and I have a patch that addresses it.

Scenario....

Product_id A has multiple alternative good_ids that map to it. This is extremely common in the book industry (eg, a 10- or 13-digit ISBN number). However, publishers often also supply an EAN which most of the time turns out to be the same as the 13-digit ISBN. If both of these IDs are in the product database then the POS lookup will retrieve multiple records in the GoodIdentificationAndProduct view with the same product_id. The simple solution is to check whether the multiple rows returned actually refer to the same product, and if so return is.

I'll try to attach a patch to this issue (I haven't done that before). BTW, this patch works whether the product lookup returns 0, 1, or many records, so is a benign change. I have not addressed the actual JIRA issue (providing a selection screen), but treat this as a precursor because you wouldn't want duplicate records to appear in this selection screen anyway :-)

> POS Multiple bar code product match
> -----------------------------------
>
> Key: OFBIZ-238
> URL: http://issues.apache.org/jira/browse/OFBIZ-238
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: pos
> Reporter: Jacques Le Roux
> Assigned To: Jacques Le Roux
>
> If one or more product ids are found when searching for a SKU the system presently falls out with a "Product Not Found" error dialog.
> The improvement here is to add a new dialog that will present the search results to the user in a list for selection into the basket or to cancel if desired.
> The list should contain product code, name and price. Each row should have enough height to ensure easy and accurate selection with a touch screen and the list should be scrollable when necessary.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-238) POS Multiple bar code product match

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-238?page=all ]

Iain Fogg updated OFBIZ-238:
----------------------------

Attachment: MenuEvents.patch

This is the patch to address the problem of multiple lookup records referring to the same product (see commentary)

> POS Multiple bar code product match
> -----------------------------------
>
> Key: OFBIZ-238
> URL: http://issues.apache.org/jira/browse/OFBIZ-238
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: pos
> Reporter: Jacques Le Roux
> Assigned To: Jacques Le Roux
> Attachments: MenuEvents.patch
>
>
> If one or more product ids are found when searching for a SKU the system presently falls out with a "Product Not Found" error dialog.
> The improvement here is to add a new dialog that will present the search results to the user in a list for selection into the basket or to cancel if desired.
> The list should contain product code, name and price. Each row should have enough height to ensure easy and accurate selection with a touch screen and the list should be scrollable when necessary.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-238) POS Multiple bar code product match

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-238?page=comments#action_12445158 ]

Jacques Le Roux commented on OFBIZ-238:
---------------------------------------

Hi Iain,

I saw you message but taking some vacation next week I did not find yet the time to answer you. Of course I will review your patch ASAP.

> POS Multiple bar code product match
> -----------------------------------
>
> Key: OFBIZ-238
> URL: http://issues.apache.org/jira/browse/OFBIZ-238
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: pos
> Reporter: Jacques Le Roux
> Assigned To: Jacques Le Roux
> Attachments: MenuEvents.patch
>
>
> If one or more product ids are found when searching for a SKU the system presently falls out with a "Product Not Found" error dialog.
> The improvement here is to add a new dialog that will present the search results to the user in a list for selection into the basket or to cancel if desired.
> The list should contain product code, name and price. Each row should have enough height to ensure easy and accurate selection with a touch screen and the list should be scrollable when necessary.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-238) POS Multiple bar code product match

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-238?page=comments#action_12445199 ]

Chris Howe commented on OFBIZ-238:
----------------------------------

For the initial description of the issue, I would think this is actually a data model issue as a SKU is a unique identifier.

For Iain's issue this is an issue of your application not taking into account the goodIdentificationTypeId as both ISBN and EAN are unique identifiers as well.

> POS Multiple bar code product match
> -----------------------------------
>
> Key: OFBIZ-238
> URL: http://issues.apache.org/jira/browse/OFBIZ-238
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: pos
> Reporter: Jacques Le Roux
> Assigned To: Jacques Le Roux
> Attachments: MenuEvents.patch
>
>
> If one or more product ids are found when searching for a SKU the system presently falls out with a "Product Not Found" error dialog.
> The improvement here is to add a new dialog that will present the search results to the user in a list for selection into the basket or to cancel if desired.
> The list should contain product code, name and price. Each row should have enough height to ensure easy and accurate selection with a touch screen and the list should be scrollable when necessary.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-238) POS Multiple bar code product match

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-238?page=comments#action_12445200 ]

David E. Jones commented on OFBIZ-238:
--------------------------------------

In general the intent of the GoodIdentification entity is to allow multiple IDs for whatever type. Even for things like ISBN that are fairly "globally" unique, it is possible to have multiple products that represent that same book, like a single book, a product representing a five pack, or whatever. Just for example.

> POS Multiple bar code product match
> -----------------------------------
>
> Key: OFBIZ-238
> URL: http://issues.apache.org/jira/browse/OFBIZ-238
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: pos
> Reporter: Jacques Le Roux
> Assigned To: Jacques Le Roux
> Attachments: MenuEvents.patch
>
>
> If one or more product ids are found when searching for a SKU the system presently falls out with a "Product Not Found" error dialog.
> The improvement here is to add a new dialog that will present the search results to the user in a list for selection into the basket or to cancel if desired.
> The list should contain product code, name and price. Each row should have enough height to ensure easy and accurate selection with a touch screen and the list should be scrollable when necessary.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-238) POS Multiple bar code product match

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-238?page=comments#action_12445353 ]

Jacques Le Roux commented on OFBIZ-238:
---------------------------------------

Iain,

I agree with you and David : GoodIdentificationAndProduct may contain more than one Id for a product. It's its reason to be as explained by SIlverston's book on page 75/76 (really clear at end of this paragraph).

I have commited your patch in revision 468662, thanks. I do not close this issue as I'm always willing to do above work.

> POS Multiple bar code product match
> -----------------------------------
>
> Key: OFBIZ-238
> URL: http://issues.apache.org/jira/browse/OFBIZ-238
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: pos
> Reporter: Jacques Le Roux
> Assigned To: Jacques Le Roux
> Attachments: MenuEvents.patch
>
>
> If one or more product ids are found when searching for a SKU the system presently falls out with a "Product Not Found" error dialog.
> The improvement here is to add a new dialog that will present the search results to the user in a list for selection into the basket or to cancel if desired.
> The list should contain product code, name and price. Each row should have enough height to ensure easy and accurate selection with a touch screen and the list should be scrollable when necessary.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-238) POS Multiple bar code product match

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-238?page=all ]

Jacques Le Roux closed OFBIZ-238.
---------------------------------

Fix Version/s: SVN trunk
Resolution: Fixed

I commited changes in OFBiz revisions 474660 and 474667 that add a dialog box with a list box to select a product if multiple product exist.
I have added the following demo data in demoRetail.xml
<GoodIdentification goodIdentificationTypeId="OTHER_ID" productId="GZ-1001" idValue="12345" .../>
to allow testing. To test, simply enter 12345 and click on SKU button.

> POS Multiple bar code product match
> -----------------------------------
>
> Key: OFBIZ-238
> URL: http://issues.apache.org/jira/browse/OFBIZ-238
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: pos
> Reporter: Jacques Le Roux
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: MenuEvents.patch
>
>
> If one or more product ids are found when searching for a SKU the system presently falls out with a "Product Not Found" error dialog.
> The improvement here is to add a new dialog that will present the search results to the user in a list for selection into the basket or to cancel if desired.
> The list should contain product code, name and price. Each row should have enough height to ensure easy and accurate selection with a touch screen and the list should be scrollable when necessary.