[jira] Created: (OFBIZ-2429) Add a new ReturnType of "Replace Immediately"

[Nicolas Malin (Jira)]

Add a new ReturnType of "Replace Immediately"
---------------------------------------------

                 Key: OFBIZ-2429
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
             Project: OFBiz
          Issue Type: New Feature
          Components: order
    Affects Versions: SVN trunk
            Reporter: Pranay Pandey
             Fix For: SVN trunk



Following needs to be done:
# Add new ReturnType of "Replace Immediately"
# New service by name "processReplaceImmediatelyReturn" which will create zero amount replacement order for the replacement items configured on the return item.
# Trigger above service with updateReturnHeader on the status change to RETURN_ACCEPTED.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-2429:
---------------------------------

       Priority: Minor  (was: Major)
    Description:
Following needs to be done:
# Add new ReturnType of "Refund Immediately"
# Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.



  was:

Following needs to be done:
# Add new ReturnType of "Replace Immediately"
# New service by name "processReplaceImmediatelyReturn" which will create zero amount replacement order for the replacement items configured on the return item.
# Trigger above service with updateReturnHeader on the status change to RETURN_ACCEPTED.


        Summary: Add new ReturnType of "Refund Immediately"  (was: Add a new ReturnType of "Replace Immediately")

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepesh Kapoor updated OFBIZ-2429:
----------------------------------

    Attachment: OFBIZ-2429.patch

Hello Pranay,

Here is the patch to Add new ReturnType "Refund Immediately" while creating return for Sales Order.
Following are the steps to test this patch :
1. Create a Sales order
2. Click on "Quick Ship Entire Order" and followed by "Create Return" from the OrderView page.
3. The Return Item page contains a drop down to select the Return Type, from here select "Refund Immediately".
4. Now from the Return Header, select the status "Requested Return Accepted" and click "Submit".
5. The amount gets refunded from the order, this can be verified by going to the Order detail page and checking the Payment Information section.

Please go through this and let me know if i have missed something.
 

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepesh Kapoor updated OFBIZ-2429:
----------------------------------

    Attachment: OFBIZ-2429.patch

Missed adding an attribute in the service definition of "processRefundReturn" in the last patch. Here is the updated patch for this issue.

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch, OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708492#action_12708492 ]

Pranay Pandey commented on OFBIZ-2429:
--------------------------------------

Thanks for the patch Deepesh.

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch, OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2429:
----------------------------------

    Assignee: Vikas Mayur

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch, OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708880#action_12708880 ]

Vikas Mayur commented on OFBIZ-2429:
------------------------------------

Deepesh,

After doing a quick review, I found that existing refund process will break. With couple of fixes the old and new process can work.

What I would suggest is

1) create a service name processRefundOnlyReturn. This service will have two require parameters returnId and returnTypeId. Implementation would be similar to the new service in your patch i.e. processRefundImmediatelyReturn except the returnTypeId would be RTN_REFUND

2) Replace all the occurrence of service processRefundReturn under updateReturnHeader eca, with processRefundOnlyReturn.

With these two changes everything would be working as usual.

Vikas

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch, OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708881#action_12708881 ]

Vikas Mayur commented on OFBIZ-2429:
------------------------------------

Better name returnTypeId RTN_REF_IMMEDIATE as RTN_REFUND_IMMEDIATE (which still being equal to 20 chars and more verbose)

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch, OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepesh Kapoor updated OFBIZ-2429:
----------------------------------

    Attachment: RefundImmediately_OFBIZ-2429.patch

Thanks for the review Vikas,
I have made changes now according to your comments, following are the improvements in this patch :

1. Made a new service "processRefundOnlyReturn"  which would handle the existing Refund process normally.
2. Made respective changes in Secas.xml for the same.
3. Changed the ReturnTypeId as suggested by you.

Now the Refund process should not break and run normally as usual. Please let me know if i have missed something.
Also ,  i have changed the patch name as suggested by Ashish.

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch, OFBIZ-2429.patch, RefundImmediately_OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2429.
------------------------------

    Resolution: Fixed

Thanks Deepesh,

Your patch is in trunk rev. 774291.

Note: Its good to have descriptive names but certainly we should also keep the name of patches same.

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch, OFBIZ-2429.patch, RefundImmediately_OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708905#action_12708905 ]

Deepesh Kapoor commented on OFBIZ-2429:
---------------------------------------

Thanks Vikas,
I will keep consistency while giving patch names from next time. [i.e., descriptive + consistent ] :)

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch, OFBIZ-2429.patch, RefundImmediately_OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708908#action_12708908 ]

Jacques Le Roux commented on OFBIZ-2429:
----------------------------------------

Thanks VIkas for comment, I think I have already added something about that in OFBiz Contributors Best Practices

> Add new ReturnType of "Refund Immediately"
> ------------------------------------------
>
>                 Key: OFBIZ-2429
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2429
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2429.patch, OFBIZ-2429.patch, RefundImmediately_OFBIZ-2429.patch
>
>
> Following needs to be done:
> # Add new ReturnType of "Refund Immediately"
> # Trigger the refund with a new service "processRefundImmediatelyReturn" on the status change to RETURN_ACCEPTED.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.