[jira] Created: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well, as shipment is created in Picked status
Locked
[jira] Created: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well, as shipment is created in Picked status
 
|
Improvement in Verify Pick screen to issue items as well, as shipment is created in Picked status
------------------------------------------------------------------------------------------------- Key: OFBIZ-2436 URL: https://issues.apache.org/jira/browse/OFBIZ-2436 Project: OFBiz Issue Type: Sub-task Reporter: Pranay Pandey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey updated OFBIZ-2436: --------------------------------- Component/s: product Fix Version/s: SVN trunk Priority: Minor (was: Major) Description: Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: # When shipment is created and marked PICKED should also be issued items (ItemIssuance) # Once order items are verified on this screen, Packing screen should use the same shipment created. # Also reduce code for Packing which has to be moved to Very Pick now. *The process will be:* # Create a sales order with 4 to 5 items. # Go to Facility-->Verify Pick, enter orderId and very order items. # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. Affects Version/s: SVN trunk Summary: Improvement in Verify Pick screen to issue items as well when shipment is created (was: Improvement in Verify Pick screen to issue items as well, as shipment is created in Picked status) > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Priority: Minor > Fix For: SVN trunk > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-2436: ------------------------------ Attachment: ItemIssuance.patch Hello Pranay, I am uploading the patch for made entry in ItemIssuance entity when shipment is created in verify pick process Steps for testing :- # Create a sales order, it should be in approved status # Go to Facility --> Verify Pick and enter the above created orderId and verify the order items # Depress Complete button, now shipment will be generated in PICKED status and invoice will be in INVOICE_IN_PROCESS status # Check ItemIssuance entity, all verified order items should be issued. # Go to Facility --> Packing and enter the orderId of above verified order and pack the order items # Depress Complete button, now order will be Complete and changed the status of above created shipment (PACKED) and invoice (Paid) > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Priority: Minor > Fix For: SVN trunk > > Attachments: ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Mayur reassigned OFBIZ-2436: ---------------------------------- Assignee: Vikas Mayur > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-2436: ------------------------------ Attachment: ItemIssuance.patch Minor changes in previous patch :- # Removed the duplicate code from PackingServices.java file # Removed the extra space from UiLabel # Removed the multiple "if" condition from VerifyPickSessionRow.java file > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: ItemIssuance.patch, ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707623#action_12707623 ] Vikas Mayur commented on OFBIZ-2436: ------------------------------------ Hi Akash, I would suggest few changes: 1) {quote} + boolean enteredProdIsOrdProd = false; + List<GenericValue> orderItems = delegator.findByAnd("OrderItem", UtilMisc.toMap("orderId", orderId)); + for (GenericValue orderItem : orderItems) { + if (productId.equals(orderItem.getString("productId"))) { + orderItemSeqIds.add(orderItem.getString("orderItemSeqId")); + enteredProdIsOrdProd = true; + } + } + if (enteredProdIsOrdProd) { + for (String orderItemSeqId : orderItemSeqIds) { + counter++; {quote} This can be simplified using something like {quote} List<GenericValue> orderItems = delegator.findByAnd("OrderItem", UtilMisc.toMap("orderId", orderId, "productId", productId)); if (UtilValidate.isNotEmpty(orderItems)) { for (GenericValue orderItem : orderItems) { // Rest of the code under if (enteredProdIsOrdProd) {, can be moved here } } {quote} I know that this code is just moved over one file to another and was certainly missed during my first commit :) 2) {quote} + <property key="ProductErrorNoValidOrderItemFoundForProductWithEnteredQuantity"> + <value xml:lang="en">ERROR: No valid order item found for product [ ${productId} ] with quantity: ${quantity}</value> + </property> {quote} can be {quote} <value xml:lang="en">ERROR: No valid order item found for product [${productId}] with quantity [${quantity}]</value> {quote} 3) In this method {quote} + public boolean isSameItem(VerifyPickSessionRow line) { + if (this.getInventoryItemId().equals(line.getInventoryItemId())) { + if (this.getOrderItemSeqId().equals(line.getOrderItemSeqId())) { + if (this.getOrderId().equals(line.getOrderId())) { + if (this.getShipGroupSeqId().equals(line.getShipGroupSeqId())) { + return true; + } + } + } + } + return false; + } {quote} This can be simplified using {quote} if (condition1 && condition2 && condition3 && condition4) { return true; } else { return false; } {quote} 4) It is always good to add brief comments to explain some snippets, like for example in #1, the boolean variable is self explanatory but only to a certain extent. It helps a lot to a person reviewing the code as well in maintaining the code later on (and doing any subsequent changes in future) as with the comment code would be self explanatory. Rest looks good. Good Work! Vikas > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: ItemIssuance.patch, ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707626#action_12707626 ] Vikas Mayur commented on OFBIZ-2436: ------------------------------------ This is just a copy of my last comment except only one change {quote} is changed to {code} Hi Akash, I would suggest few changes: 1) {code} + boolean enteredProdIsOrdProd = false; + List<GenericValue> orderItems = delegator.findByAnd("OrderItem", UtilMisc.toMap("orderId", orderId)); + for (GenericValue orderItem : orderItems) { + if (productId.equals(orderItem.getString("productId"))) { + orderItemSeqIds.add(orderItem.getString("orderItemSeqId")); + enteredProdIsOrdProd = true; + } + } + if (enteredProdIsOrdProd) { + for (String orderItemSeqId : orderItemSeqIds) { + counter++; {code} This can be simplified using something like {code} List<GenericValue> orderItems = delegator.findByAnd("OrderItem", UtilMisc.toMap("orderId", orderId, "productId", productId)); if (UtilValidate.isNotEmpty(orderItems)) { for (GenericValue orderItem : orderItems) { // Rest of the code under if (enteredProdIsOrdProd) {, can be moved here } } {code} I know that this code is just moved over one file to another and was certainly missed during my first commit :) 2) {code} + <property key="ProductErrorNoValidOrderItemFoundForProductWithEnteredQuantity"> + <value xml:lang="en">ERROR: No valid order item found for product [ ${productId} ] with quantity: ${quantity}</value> + </property> {code} can be {code} <value xml:lang="en">ERROR: No valid order item found for product [${productId}] with quantity [${quantity}]</value> {code} 3) In this method {code} + public boolean isSameItem(VerifyPickSessionRow line) { + if (this.getInventoryItemId().equals(line.getInventoryItemId())) { + if (this.getOrderItemSeqId().equals(line.getOrderItemSeqId())) { + if (this.getOrderId().equals(line.getOrderId())) { + if (this.getShipGroupSeqId().equals(line.getShipGroupSeqId())) { + return true; + } + } + } + } + return false; + } {code} This can be simplified using {code} if (condition1 && condition2 && condition3 && condition4) { return true; } else { return false; } {code} 4) It is always good to add brief comments to explain some snippets, like for example in #1, the boolean variable is self explanatory but only to a certain extent. It helps a lot to a person reviewing the code as well in maintaining the code later on (and doing any subsequent changes in future) as the with the comment code would be self explanatory. Rest looks good. Good Work! Vikas > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: ItemIssuance.patch, ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707626#action_12707626 ] Vikas Mayur edited comment on OFBIZ-2436 at 5/8/09 11:49 PM: ------------------------------------------------------------- This is just a copy of my last comment except only one change \{quote} is changed to \{code} Note: Finally have to edit this comment, no change other then just escaping the notation above. Hi Akash, I would suggest few changes: 1) {code} + boolean enteredProdIsOrdProd = false; + List<GenericValue> orderItems = delegator.findByAnd("OrderItem", UtilMisc.toMap("orderId", orderId)); + for (GenericValue orderItem : orderItems) { + if (productId.equals(orderItem.getString("productId"))) { + orderItemSeqIds.add(orderItem.getString("orderItemSeqId")); + enteredProdIsOrdProd = true; + } + } + if (enteredProdIsOrdProd) { + for (String orderItemSeqId : orderItemSeqIds) { + counter++; {code} This can be simplified using something like {code} List<GenericValue> orderItems = delegator.findByAnd("OrderItem", UtilMisc.toMap("orderId", orderId, "productId", productId)); if (UtilValidate.isNotEmpty(orderItems)) { for (GenericValue orderItem : orderItems) { // Rest of the code under if (enteredProdIsOrdProd) {, can be moved here } } {code} I know that this code is just moved over one file to another and was certainly missed during my first commit :) 2) {code} + <property key="ProductErrorNoValidOrderItemFoundForProductWithEnteredQuantity"> + <value xml:lang="en">ERROR: No valid order item found for product [ ${productId} ] with quantity: ${quantity}</value> + </property> {code} can be {code} <value xml:lang="en">ERROR: No valid order item found for product [${productId}] with quantity [${quantity}]</value> {code} 3) In this method {code} + public boolean isSameItem(VerifyPickSessionRow line) { + if (this.getInventoryItemId().equals(line.getInventoryItemId())) { + if (this.getOrderItemSeqId().equals(line.getOrderItemSeqId())) { + if (this.getOrderId().equals(line.getOrderId())) { + if (this.getShipGroupSeqId().equals(line.getShipGroupSeqId())) { + return true; + } + } + } + } + return false; + } {code} This can be simplified using {code} if (condition1 && condition2 && condition3 && condition4) { return true; } else { return false; } {code} 4) It is always good to add brief comments to explain some snippets, like for example in #1, the boolean variable is self explanatory but only to a certain extent. It helps a lot to a person reviewing the code as well in maintaining the code later on (and doing any subsequent changes in future) as the with the comment code would be self explanatory. Rest looks good. Good Work! Vikas was (Author: vikasmayur): This is just a copy of my last comment except only one change {quote} is changed to {code} Hi Akash, I would suggest few changes: 1) {code} + boolean enteredProdIsOrdProd = false; + List<GenericValue> orderItems = delegator.findByAnd("OrderItem", UtilMisc.toMap("orderId", orderId)); + for (GenericValue orderItem : orderItems) { + if (productId.equals(orderItem.getString("productId"))) { + orderItemSeqIds.add(orderItem.getString("orderItemSeqId")); + enteredProdIsOrdProd = true; + } + } + if (enteredProdIsOrdProd) { + for (String orderItemSeqId : orderItemSeqIds) { + counter++; {code} This can be simplified using something like {code} List<GenericValue> orderItems = delegator.findByAnd("OrderItem", UtilMisc.toMap("orderId", orderId, "productId", productId)); if (UtilValidate.isNotEmpty(orderItems)) { for (GenericValue orderItem : orderItems) { // Rest of the code under if (enteredProdIsOrdProd) {, can be moved here } } {code} I know that this code is just moved over one file to another and was certainly missed during my first commit :) 2) {code} + <property key="ProductErrorNoValidOrderItemFoundForProductWithEnteredQuantity"> + <value xml:lang="en">ERROR: No valid order item found for product [ ${productId} ] with quantity: ${quantity}</value> + </property> {code} can be {code} <value xml:lang="en">ERROR: No valid order item found for product [${productId}] with quantity [${quantity}]</value> {code} 3) In this method {code} + public boolean isSameItem(VerifyPickSessionRow line) { + if (this.getInventoryItemId().equals(line.getInventoryItemId())) { + if (this.getOrderItemSeqId().equals(line.getOrderItemSeqId())) { + if (this.getOrderId().equals(line.getOrderId())) { + if (this.getShipGroupSeqId().equals(line.getShipGroupSeqId())) { + return true; + } + } + } + } + return false; + } {code} This can be simplified using {code} if (condition1 && condition2 && condition3 && condition4) { return true; } else { return false; } {code} 4) It is always good to add brief comments to explain some snippets, like for example in #1, the boolean variable is self explanatory but only to a certain extent. It helps a lot to a person reviewing the code as well in maintaining the code later on (and doing any subsequent changes in future) as the with the comment code would be self explanatory. Rest looks good. Good Work! Vikas > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: ItemIssuance.patch, ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Mayur closed OFBIZ-2436. ------------------------------ Resolution: Fixed Thanks Akash, Your patch is in trunk rev. 773172 Vikas > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: ItemIssuance.patch, ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707640#action_12707640 ] Akash Jain commented on OFBIZ-2436: ----------------------------------- Thanks Vikas :) Regards -- Akash Jain > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: ItemIssuance.patch, ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-2436: ------------------------------ Attachment: IssuanceServices.patch In last patch, I mistakenly removed conditional code, which checks if "Reserved Inventory does not remains, then status of Order item is changed to complete". And this beaked the functionality of "Quick Ship Entire Order" button (order status not changed to completed) So added back this code and also added extra condition to check that if shipment is in picked status then order item will not get completed. Now "Quick Ship Entire Order" button works fine order will complete after click on it. > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: IssuanceServices.patch, ItemIssuance.patch, ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707679#action_12707679 ] Ashish Vijaywargiya commented on OFBIZ-2436: -------------------------------------------- Thanks Akash for your contribution. Patch is in trunk at rev 773229. -- Ashish Vijaywargiya > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: IssuanceServices.patch, ItemIssuance.patch, ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2436) Improvement in Verify Pick screen to issue items as well when shipment is created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707681#action_12707681 ] Akash Jain commented on OFBIZ-2436: ----------------------------------- Thanks Ashish :) Regards -- Akash Jain > Improvement in Verify Pick screen to issue items as well when shipment is created > --------------------------------------------------------------------------------- > > Key: OFBIZ-2436 > URL: https://issues.apache.org/jira/browse/OFBIZ-2436 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: IssuanceServices.patch, ItemIssuance.patch, ItemIssuance.patch > > > Improvement in Verify Pick screen to issue items as well when shipment is created in Picked status: > # When shipment is created and marked PICKED should also be issued items (ItemIssuance) > # Once order items are verified on this screen, Packing screen should use the same shipment created. > # Also reduce code for Packing which has to be moved to Very Pick now. > *The process will be:* > # Create a sales order with 4 to 5 items. > # Go to Facility-->Verify Pick, enter orderId and very order items. > # After all items are verified shipment should be created in PICKED status, invoice will be generated in INVOICE_IN_PROCESS along with item issuance. > # Now go Facility-->Packing, enter verified oderId and complete pack, now this process will utilize the same shipment, invoice created in Verify Pick process only status of shipment will be changed to PACKED after completion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |