[jira] Created: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)
BizznessTime Theme : error and event messages should not dissapear by default
-----------------------------------------------------------------------------

                 Key: OFBIZ-2442
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
             Project: OFBiz
          Issue Type: Sub-task
            Reporter: Jacques Le Roux


Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2442:
-----------------------------------

          Component/s: ALL COMPONENTS
             Priority: Trivial  (was: Major)
    Affects Version/s: SVN trunk
                       Release Branch 9.04
        Fix Version/s: SVN trunk
                       Release Branch 9.04

> BizznessTime Theme : error and event messages should not dissapear by default
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>
> Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707485#action_12707485 ]

Jacques Le Roux commented on OFBIZ-2442:
----------------------------------------

Or the timeout should be adjustable at least

> BizznessTime Theme : error and event messages should not dissapear by default
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>
> Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769944#action_12769944 ]

Bilgin Ibryam commented on OFBIZ-2442:
--------------------------------------

Jacques,

In my opinion setting a longer timeout is not a solution because in this case the message will hide some of the buttons for a longer period and it is impossible to use these buttons before the message disappears.
I would propose to hide the message only if the user clicks on it. (I am not sure but this may require also an indicator on the message box showing how to hide the message).
WDYT?


Here is the patch to hide the message when clicked.

Bilgin




> BizznessTime Theme : error and event messages should not dissapear by default
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: message.patch
>
>
> Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-2442:
---------------------------------

    Attachment: message.patch

> BizznessTime Theme : error and event messages should not dissapear by default
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: message.patch
>
>
> Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769960#action_12769960 ]

Jacques Le Roux commented on OFBIZ-2442:
----------------------------------------

Hi Bilgin,

Yes indeed sounds like a good idea. Maybe we could continue to show short messages for a default timeout tough ? And then having a parameter for this timeout somewhere could help. But yes, if we go for KISS, clicking on it seems wiser...

Waiting for opinions...

> BizznessTime Theme : error and event messages should not dissapear by default
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: message.patch
>
>
> Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769975#action_12769975 ]

Scott Gray commented on OFBIZ-2442:
-----------------------------------

I don't think it works on a timer currently does it?  Anyway I think a click to remove would be fine.

> BizznessTime Theme : error and event messages should not dissapear by default
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: message.patch
>
>
> Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769982#action_12769982 ]

Jacques Le Roux commented on OFBIZ-2442:
----------------------------------------

At least it dissapears after some time. If nobody complains, I will soon commit Bilgin's patch... Then we will see later if someone come with a better answer...

> BizznessTime Theme : error and event messages should not dissapear by default
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: message.patch
>
>
> Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770000#action_12770000 ]

Bilgin Ibryam commented on OFBIZ-2442:
--------------------------------------

Currently I see two timers for hiding the message:
 -  One that is automatically started and removes the message in 7 seconds.
 - The other one is activated on mousemove, click or keypress events and removes the message in 2-3 seconds.

My patch comments out both timer and removes the message with 0.5s delay if the user clicks on the message box.



> BizznessTime Theme : error and event messages should not dissapear by default
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: message.patch
>
>
> Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2442.
----------------------------------

    Resolution: Fixed
      Assignee: Bilgin Ibryam

Thanks Bilgin,

Your patch is in trunk at r830112, R9.04 at r830115  

Like you, I have kept the tabs rather than converting all the js file to 4 spaces (anyway all js files seems to have tabs in them)

> BizznessTime Theme : error and event messages should not dissapear by default
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: message.patch
>
>
> Error and event messages should not dissapear by default (if there are a bit long it's impossible to read)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.