[jira] Created: (OFBIZ-2464) The Replacement orders in "Held" status should get canceled if the original items are not received within specified time period

[Nicolas Malin (Jira)]

The Replacement orders in "Held" status should get canceled if the original items are not received within specified time period
-------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2464
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2464
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Deepesh Kapoor
            Priority: Minor
             Fix For: SVN trunk


Following needs to be done :

1. We have a return type "Wait Replacement Reserved" which creates a new replacement order in "HELD" status on "RETURN_ACCEPTED".
2. Add logic to process these orders and cancel them if the return is not received within a decided time period(e.g., 30 days).
3. A scheduled service should be written to automatically cancel the "HELD" replacement orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mukesh Choudhary updated OFBIZ-2464:
------------------------------------

    Attachment: OFBIZ-2464.patch

Hello Deepesh,

Here is the patch for automatic cancellation of replacement order if return is not received within 30 days.
Following are the steps to test this patch :
1. Create a Sales order.
2. Click on "Quick Ship Entire Order" and followed by "Create Return" from the OrderView page.
3. The Return Item page contains a drop down to select the Return Type, from here select "Wait Replacement Reserved".
4. Now from the Return Header, select the status "Requested Return Accepted" and click "Submit",So that a replacement order in held status is created.
5. Now if the return is not received within 30 days then this replacement order will be automatically canceled by scheduled service "autoCancelReplacementOrders".

Please go through this and let me know if i have missed something.

> The Replacement orders in "Held" status should get canceled if the original items are not received within specified time period
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2464
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2464
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2464.patch
>
>
> Following needs to be done :
> 1. We have a return type "Wait Replacement Reserved" which creates a new replacement order in "HELD" status on "RETURN_ACCEPTED".
> 2. Add logic to process these orders and cancel them if the return is not received within a decided time period(e.g., 30 days).
> 3. A scheduled service should be written to automatically cancel the "HELD" replacement orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepesh Kapoor updated OFBIZ-2464:
----------------------------------

    Description:
Following needs to be done :

1. We have a return type "Wait Replacement Reserved" which creates a new replacement order in "HELD" status on "RETURN_ACCEPTED".
2. Add logic to process these orders and cancel them if the return is not received within 30 days.
3. A scheduled service should be written to automatically cancel the "HELD" replacement orders.

  was:
Following needs to be done :

1. We have a return type "Wait Replacement Reserved" which creates a new replacement order in "HELD" status on "RETURN_ACCEPTED".
2. Add logic to process these orders and cancel them if the return is not received within a decided time period(e.g., 30 days).
3. A scheduled service should be written to automatically cancel the "HELD" replacement orders.

        Summary: The Replacement orders in "Held" status should get canceled if the original items are not received within 30 days  (was: The Replacement orders in "Held" status should get canceled if the original items are not received within specified time period)

> The Replacement orders in "Held" status should get canceled if the original items are not received within 30 days
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2464
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2464
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2464.patch
>
>
> Following needs to be done :
> 1. We have a return type "Wait Replacement Reserved" which creates a new replacement order in "HELD" status on "RETURN_ACCEPTED".
> 2. Add logic to process these orders and cancel them if the return is not received within 30 days.
> 3. A scheduled service should be written to automatically cancel the "HELD" replacement orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2464:
----------------------------------

    Assignee: Vikas Mayur

> The Replacement orders in "Held" status should get canceled if the original items are not received within 30 days
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2464
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2464
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2464.patch
>
>
> Following needs to be done :
> 1. We have a return type "Wait Replacement Reserved" which creates a new replacement order in "HELD" status on "RETURN_ACCEPTED".
> 2. Add logic to process these orders and cancel them if the return is not received within 30 days.
> 3. A scheduled service should be written to automatically cancel the "HELD" replacement orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mukesh Choudhary updated OFBIZ-2464:
------------------------------------

    Attachment: CancelHeldReplacementOrder_OFBIZ-2464

Hello Vikas,

Here is the updated patch with improvements that you have suggested.

> The Replacement orders in "Held" status should get canceled if the original items are not received within 30 days
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2464
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2464
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CancelHeldReplacementOrder_OFBIZ-2464, OFBIZ-2464.patch
>
>
> Following needs to be done :
> 1. We have a return type "Wait Replacement Reserved" which creates a new replacement order in "HELD" status on "RETURN_ACCEPTED".
> 2. Add logic to process these orders and cancel them if the return is not received within 30 days.
> 3. A scheduled service should be written to automatically cancel the "HELD" replacement orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mukesh Choudhary updated OFBIZ-2464:
------------------------------------

    Attachment: CancelHeldReplacementOrder_OFBIZ-2464.patch

Hello Vikas,

Here is my updated patch with your suggestions.
Here i have used "cancelOrderItem" service because after canceling the order I need to send order cancellation notification and this service is doing it.

> The Replacement orders in "Held" status should get canceled if the original items are not received within 30 days
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2464
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2464
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CancelHeldReplacementOrder_OFBIZ-2464, CancelHeldReplacementOrder_OFBIZ-2464.patch, OFBIZ-2464.patch
>
>
> Following needs to be done :
> 1. We have a return type "Wait Replacement Reserved" which creates a new replacement order in "HELD" status on "RETURN_ACCEPTED".
> 2. Add logic to process these orders and cancel them if the return is not received within 30 days.
> 3. A scheduled service should be written to automatically cancel the "HELD" replacement orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2464.
------------------------------

    Resolution: Fixed

Thanks Mukesh and others,

Mukesh your patch with slight changes is in trunk rev. 775091

Vikas

> The Replacement orders in "Held" status should get canceled if the original items are not received within 30 days
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2464
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2464
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CancelHeldReplacementOrder_OFBIZ-2464, CancelHeldReplacementOrder_OFBIZ-2464.patch, OFBIZ-2464.patch
>
>
> Following needs to be done :
> 1. We have a return type "Wait Replacement Reserved" which creates a new replacement order in "HELD" status on "RETURN_ACCEPTED".
> 2. Add logic to process these orders and cancel them if the return is not received within 30 days.
> 3. A scheduled service should be written to automatically cancel the "HELD" replacement orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.