[jira] Created: (OFBIZ-2470) In Cross-Ship Replacement we need to make sure return for refund is possible after a return for replacement

[Nicolas Malin (Jira)]

In Cross-Ship Replacement we need to make sure return for refund is possible after a return for replacement
-----------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2470
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2470
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Deepesh Kapoor
            Priority: Minor
             Fix For: SVN trunk


Following needs to be done in order to make sure that return for refund is possible after return for replacement :

1. (In Cross-Ship replacement) When creating return for refund against replacement order look for original order and fill in amount(s) from that order.
2. When processing return refund look for original order and CC payment associated with it and do the CC refund transaction against that original purchase payment transaction.
3. A new service needs to be added for achieving this "processCrossShipmentAndRefund".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepesh Kapoor updated OFBIZ-2470:
----------------------------------

    Attachment: CrossShipment_OFBIZ-2470.patch

Here is the patch, following are the steps to test this patch :

1. Create a return for a Sales Order and select the return type "Cross-Ship Replacement".
2. Accept the return from return header by selecting status "Requested Return Accepted".
3. A new zero amount Replacement order will be created in the system which will contain the items returned from the original order.
4. Now create return for this Replacement order and this time select the Return Type "Refund".
5. Receive this return from Return Header.
6. The amount will be refunded upon receiving the return from the original order, this can be verified from viewing the Order Detail page of original order.

> In Cross-Ship Replacement we need to make sure return for refund is possible after a return for replacement
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2470
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2470
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CrossShipment_OFBIZ-2470.patch
>
>
> Following needs to be done in order to make sure that return for refund is possible after return for replacement :
> 1. (In Cross-Ship replacement) When creating return for refund against replacement order look for original order and fill in amount(s) from that order.
> 2. When processing return refund look for original order and CC payment associated with it and do the CC refund transaction against that original purchase payment transaction.
> 3. A new service needs to be added for achieving this "processCrossShipmentAndRefund".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2470:
----------------------------------

    Assignee: Vikas Mayur

> In Cross-Ship Replacement we need to make sure return for refund is possible after a return for replacement
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2470
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2470
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CrossShipment_OFBIZ-2470.patch
>
>
> Following needs to be done in order to make sure that return for refund is possible after return for replacement :
> 1. (In Cross-Ship replacement) When creating return for refund against replacement order look for original order and fill in amount(s) from that order.
> 2. When processing return refund look for original order and CC payment associated with it and do the CC refund transaction against that original purchase payment transaction.
> 3. A new service needs to be added for achieving this "processCrossShipmentAndRefund".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepesh Kapoor updated OFBIZ-2470:
----------------------------------

    Attachment: CrossShipment_OFBIZ-2470.patch

Here is the updated patch for this issue, this will handle refund in two cases :
1. The replacement order for the return created is in "Completed" status.
2. The replacement order for the return is in "Approved" status.

> In Cross-Ship Replacement we need to make sure return for refund is possible after a return for replacement
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2470
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2470
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch
>
>
> Following needs to be done in order to make sure that return for refund is possible after return for replacement :
> 1. (In Cross-Ship replacement) When creating return for refund against replacement order look for original order and fill in amount(s) from that order.
> 2. When processing return refund look for original order and CC payment associated with it and do the CC refund transaction against that original purchase payment transaction.
> 3. A new service needs to be added for achieving this "processCrossShipmentAndRefund".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun Patidar updated OFBIZ-2470:
--------------------------------

    Attachment: CrossShipment_OFBIZ-2470.patch

Here is the new patch for this functionality, as previous patch was not proper work.

> In Cross-Ship Replacement we need to make sure return for refund is possible after a return for replacement
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2470
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2470
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch
>
>
> Following needs to be done in order to make sure that return for refund is possible after return for replacement :
> 1. (In Cross-Ship replacement) When creating return for refund against replacement order look for original order and fill in amount(s) from that order.
> 2. When processing return refund look for original order and CC payment associated with it and do the CC refund transaction against that original purchase payment transaction.
> 3. A new service needs to be added for achieving this "processCrossShipmentAndRefund".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-2470:
---------------------------------

    Attachment: CrossShipment_OFBIZ-2470.patch

Here is the updated patch with improvements.  This patch covers following scenarios:

1) Refund of the replacement order possible now.  Since the replacement order has no payment preferences associated to it, payment preferences of the original order are used to process the refund.  When the replacement order refund is complete you can look for the related entry in payment information section of the original order.  Also you can find the payments for this return in ReturnItem screen.

2) When a replacement order is cancelled, and replacement return against which it was created is already received, then that return is refunded.

--
Thanks,
Mridul Pathak

> In Cross-Ship Replacement we need to make sure return for refund is possible after a return for replacement
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2470
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2470
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch
>
>
> Following needs to be done in order to make sure that return for refund is possible after return for replacement :
> 1. (In Cross-Ship replacement) When creating return for refund against replacement order look for original order and fill in amount(s) from that order.
> 2. When processing return refund look for original order and CC payment associated with it and do the CC refund transaction against that original purchase payment transaction.
> 3. A new service needs to be added for achieving this "processCrossShipmentAndRefund".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2470:
------------------------------------------

    Assignee: Ashish Vijaywargiya  (was: Vikas Mayur)

> In Cross-Ship Replacement we need to make sure return for refund is possible after a return for replacement
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2470
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2470
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch
>
>
> Following needs to be done in order to make sure that return for refund is possible after return for replacement :
> 1. (In Cross-Ship replacement) When creating return for refund against replacement order look for original order and fill in amount(s) from that order.
> 2. When processing return refund look for original order and CC payment associated with it and do the CC refund transaction against that original purchase payment transaction.
> 3. A new service needs to be added for achieving this "processCrossShipmentAndRefund".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2470.
--------------------------------------

    Resolution: Fixed

Thanks Mridul, Arun.
Done at r786827.

--
Ashish Vijaywargiya

> In Cross-Ship Replacement we need to make sure return for refund is possible after a return for replacement
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2470
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2470
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch, CrossShipment_OFBIZ-2470.patch
>
>
> Following needs to be done in order to make sure that return for refund is possible after return for replacement :
> 1. (In Cross-Ship replacement) When creating return for refund against replacement order look for original order and fill in amount(s) from that order.
> 2. When processing return refund look for original order and CC payment associated with it and do the CC refund transaction against that original purchase payment transaction.
> 3. A new service needs to be added for achieving this "processCrossShipmentAndRefund".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.