[jira] Created: (OFBIZ-2542) There is no entry for partyIdTo and partyIdFrom field in Shipment entity

[Nicolas Malin (Jira)]

There is no entry for partyIdTo and partyIdFrom field in Shipment entity
------------------------------------------------------------------------

                 Key: OFBIZ-2542
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2542
             Project: OFBiz
          Issue Type: Improvement
          Components: product
    Affects Versions: SVN trunk
            Reporter: Akash Jain
            Priority: Minor
             Fix For: SVN trunk


There is no entry for partyIdTo and partyIdFrom field in Shipment entity when shipment is created in verify pick screen in PICKED status.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akash Jain updated OFBIZ-2542:
------------------------------

    Attachment: ThereIsNoEntryForPartyId_OFBIZ-2542.patch

I have made the changes in createShipment method in VerifyPickSession.java. I have uploaded the patch now there will be entry for partyIdTo and partyIdFrom field in Shipment when shipment is created in verify pick screen.

> There is no entry for partyIdTo and partyIdFrom field in Shipment entity
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-2542
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2542
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Akash Jain
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ThereIsNoEntryForPartyId_OFBIZ-2542.patch
>
>
> There is no entry for partyIdTo and partyIdFrom field in Shipment entity when shipment is created in verify pick screen in PICKED status.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2542:
----------------------------------

    Assignee: Vikas Mayur

> There is no entry for partyIdTo and partyIdFrom field in Shipment entity
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-2542
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2542
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Akash Jain
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ThereIsNoEntryForPartyId_OFBIZ-2542.patch
>
>
> There is no entry for partyIdTo and partyIdFrom field in Shipment entity when shipment is created in verify pick screen in PICKED status.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2542.
------------------------------

    Resolution: Fixed

Akash, I did commit a different version of your patch in rev. 779899 because of following issues with your patch

1) Instead of using BILL_TO_CUSTOMER and BILL_FROM_VENDOR for shipment, SHIP_TO_CUSTOMER and SHIP_FROM_VENDOR role should be used to find out partyIdTo and partyIdFrom for a shipment.
2) The way partyIdTo and partyIdFrom are fetched might cause NPE.

> There is no entry for partyIdTo and partyIdFrom field in Shipment entity
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-2542
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2542
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Akash Jain
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ThereIsNoEntryForPartyId_OFBIZ-2542.patch
>
>
> There is no entry for partyIdTo and partyIdFrom field in Shipment entity when shipment is created in verify pick screen in PICKED status.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.