[jira] Created: (OFBIZ-2549) The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-2549) The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

Nicolas Malin (Jira)
The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0
-----------------------------------------------------------------------------------------------

                 Key: OFBIZ-2549
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2549
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: WeizhanGuo
            Priority: Minor
             Fix For: SVN trunk


The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2549) The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

WeizhanGuo updated OFBIZ-2549:
------------------------------

    Attachment: fixMacroRenderNextPrevPagesNumber_ofbiz-trunk.patch

> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2549
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2549
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: WeizhanGuo
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: fixMacroRenderNextPrevPagesNumber_ofbiz-trunk.patch
>
>
> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-2549) The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-2549:
----------------------------------------

    Assignee: Jacopo Cappellato

> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2549
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2549
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: WeizhanGuo
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: fixMacroRenderNextPrevPagesNumber_ofbiz-trunk.patch
>
>
> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2549) The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717597#action_12717597 ]

Jacopo Cappellato commented on OFBIZ-2549:
------------------------------------------

Hi Guo,

could you please provide the steps to reproduce the error?

Thank you,

Jacopo



> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2549
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2549
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: WeizhanGuo
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: fixMacroRenderNextPrevPagesNumber_ofbiz-trunk.patch
>
>
> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2549) The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717609#action_12717609 ]

Jacques Le Roux commented on OFBIZ-2549:
----------------------------------------

It may help to follow [these conventions|http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-bugReporters]

Thanks

> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2549
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2549
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: WeizhanGuo
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: fixMacroRenderNextPrevPagesNumber_ofbiz-trunk.patch
>
>
> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2549) The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721082#action_12721082 ]

WeizhanGuo commented on OFBIZ-2549:
-----------------------------------

I'm sorry for late, very busy.

You can see the bug in https://localhost:8443/humanres/control/FindPerfReviews, and select the employee id, you will see the page number in select is wrong, there are two pages but there is only 1 page in the select option.

I double checked this, and found the old patch still have some problems, I make some misunderstand about the divide operator. we need change the code to this:

<#assign x=(listSize/viewSize)?floor>
<#if listSize gt (x*viewSize)><#assign x=x+1></#if>

> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2549
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2549
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: WeizhanGuo
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: fixMacroRenderNextPrevPagesNumber_ofbiz-trunk.patch
>
>
> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2549) The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-2549.
------------------------------------

    Resolution: Fixed

Thank you Guo: your last patch is in rev. 786387.

> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2549
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2549
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: WeizhanGuo
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: fixMacroRenderNextPrevPagesNumber_ofbiz-trunk.patch
>
>
> The pages number which generate by macro renderNextPrev has bug when the listSize/viewSize == 0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.