[jira] Created: (OFBIZ-2627) Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.

[Nicolas Malin (Jira)]

Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2627
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
             Project: OFBiz
          Issue Type: Improvement
          Components: marketing
    Affects Versions: SVN trunk
            Reporter: Ratnesh Upadhyay
            Priority: Minor
             Fix For: SVN trunk


In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.


Regards,
-- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2627:
--------------------------------

    Attachment: DisplayActiveParties_OFBiz_2627.patch

Here is the patch for given problem. Now if users clicks on Expire button then all the active records are shown instead of recently expired record.

Thanks Ratnesh for reporting this issue.
--
Divesh

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2627:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721205#action_12721205 ]

Ashish Vijaywargiya commented on OFBIZ-2627:
--------------------------------------------

Changes are in trunk at revision 786021.
Thanks Divesh, Ratnesh !

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721206#action_12721206 ]

Ashish Vijaywargiya commented on OFBIZ-2627:
--------------------------------------------

Please do one more modification:

-- If thruDate < nowTimestamp then we should not show Edit & Expire button.
It means that record is no more active.

--
Ashish

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2627:
--------------------------------

    Attachment: DisplayActiveParties_OFBiz_2627.patch

Thanks Ashish for your suggestions. Yes I also think that these changes are also necessary. Following are things covered in this patch:

1) Now Edit and Expire link are shown when record is active record and when thruDate is after today's date.

2) For making this functionality I made two new methods "isDateBeforeNow" and "isDateAfterNow" in UtilValidate.java

Thanks again
--
Divesh

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2627:
--------------------------------

    Attachment: DisplayActiveParties_OFBiz_2627.patch

This is the new patch for the same functionality, but here I have used groovy script instead of bsh script.

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721652#action_12721652 ]

Ashish Vijaywargiya commented on OFBIZ-2627:
--------------------------------------------

Thanks Divesh !
Changes are in trunk 786373 except changes done in framework code.
We will wait for someone to commit those changes then I will close that issue.

In UtilValidate.java file "isDateBeforeNow" & "isDateAfterNow" already exists but those takes date "String" as the method argument.
And those methods was not full filling requirement.

So new method introduced that takes TimeStamp as the method argument to solve the purpose.

--
Ashish Vijaywargiya

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721656#action_12721656 ]

Divesh Dutta commented on OFBIZ-2627:
-------------------------------------

Thanks Ashish!

I would like to make small correction so that other developers does not get confused:

In UtilValidate.java file "isDateBeforeToday" and "isDateAfterToday" are the two methods which takes date "String" as the method argument.

--
Divesh Dutta

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721659#action_12721659 ]

Ashish Vijaywargiya commented on OFBIZ-2627:
--------------------------------------------

I have already mentioned that in my previous comment Divesh.

--
Ashish

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2627.
--------------------------------------

    Resolution: Fixed

Part of this issue has been committed by Anil in trunk revision 786400.
Thanks Anil.

Now I am closing this issue.
Thanks Divesh !

--
Ashish

> Clicking on expire button shows only expired record in List Contact List Party form of marketing component, it should show active records only.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2627
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2627
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>    Affects Versions: SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch, DisplayActiveParties_OFBiz_2627.patch
>
>
> In marketing component when a user depress on expire button against a party in List Contact List Party form, It shows expired record (recent expired) instead of showing all the active parties associated with that contact list.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.