OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

NamingServiceContainer binds to all network interfaces
------------------------------------------------------

Key: OFBIZ-2559
URL: https://issues.apache.org/jira/browse/OFBIZ-2559
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Release Branch 9.04
Reporter: Deyan
Attachments: NamingServiceContainer_rmi_registry_bind_interface.patch

org.ofbiz.base.container.NamingServiceContainer by default binds a server socket to all available network interfaces. Configuration of this container is done in
framework/base/config/ofbiz-containers.xml


<container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
<property name="port" value="1099"/>
</container>

Only the port can be configured.

Additional configuration property needs to be implemented:

<property name="host" value="0.0.0.0"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

[ https://issues.apache.org/jira/browse/OFBIZ-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deyan updated OFBIZ-2559:
-------------------------

Attachment: NamingServiceContainer_rmi_registry_bind_interface.patch

Suggested patch.

> NamingServiceContainer binds to all network interfaces
> ------------------------------------------------------
>
> Key: OFBIZ-2559
> URL: https://issues.apache.org/jira/browse/OFBIZ-2559
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Release Branch 9.04
> Reporter: Deyan
> Attachments: NamingServiceContainer_rmi_registry_bind_interface.patch
>
>
> org.ofbiz.base.container.NamingServiceContainer by default binds a server socket to all available network interfaces. Configuration of this container is done in
> framework/base/config/ofbiz-containers.xml
> 
> <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
> <property name="port" value="1099"/>
> </container>
> Only the port can be configured.
> Additional configuration property needs to be implemented:
> <property name="host" value="0.0.0.0"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715413#action_12715413 ]

Jacques Le Roux commented on OFBIZ-2559:
----------------------------------------

Cursory review : please don't use tabs in your patch

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-2559:
---------------------------------------

Attachment: Tabs_Issue.png

See how code looks like on my text editor.
Which IDE you are using?

> NamingServiceContainer binds to all network interfaces
> ------------------------------------------------------
>
> Key: OFBIZ-2559
> URL: https://issues.apache.org/jira/browse/OFBIZ-2559
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Release Branch 9.04
> Reporter: Deyan
> Attachments: NamingServiceContainer_rmi_registry_bind_interface.patch, Tabs_Issue.png
>
>
> org.ofbiz.base.container.NamingServiceContainer by default binds a server socket to all available network interfaces. Configuration of this container is done in
> framework/base/config/ofbiz-containers.xml
> 
> <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
> <property name="port" value="1099"/>
> </container>
> Only the port can be configured.
> Additional configuration property needs to be implemented:
> <property name="host" value="0.0.0.0"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715438#action_12715438 ]

Deyan commented on OFBIZ-2559:
------------------------------

Damn Ganymede ... they are about to screw up the last good IDE on the market.

I've checked "Use spaces instead of tabs" and it still inserts tabs instead of spaces.
I'll fix the patch and attach a new version in few minutes.

Sorry about that

> NamingServiceContainer binds to all network interfaces
> ------------------------------------------------------
>
> Key: OFBIZ-2559
> URL: https://issues.apache.org/jira/browse/OFBIZ-2559
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Release Branch 9.04
> Reporter: Deyan
> Attachments: NamingServiceContainer_rmi_registry_bind_interface.patch, Tabs_Issue.png
>
>
> org.ofbiz.base.container.NamingServiceContainer by default binds a server socket to all available network interfaces. Configuration of this container is done in
> framework/base/config/ofbiz-containers.xml
> 
> <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
> <property name="port" value="1099"/>
> </container>
> Only the port can be configured.
> Additional configuration property needs to be implemented:
> <property name="host" value="0.0.0.0"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

In reply to this post by Nicolas Malin (Jira)

> NamingServiceContainer binds to all network interfaces
> ------------------------------------------------------
>
> Key: OFBIZ-2559
> URL: https://issues.apache.org/jira/browse/OFBIZ-2559
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Release Branch 9.04
> Reporter: Deyan
> Attachments: NamingServiceContainer_rmi_registry_bind_interface.patch, NamingServiceContainer_rmi_registry_bind_interface_v2.patch, Tabs_Issue.png
>
>
> org.ofbiz.base.container.NamingServiceContainer by default binds a server socket to all available network interfaces. Configuration of this container is done in
> framework/base/config/ofbiz-containers.xml
> 
> <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
> <property name="port" value="1099"/>
> </container>
> Only the port can be configured.
> Additional configuration property needs to be implemented:
> <property name="host" value="0.0.0.0"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715981#action_12715981 ]

David E. Jones commented on OFBIZ-2559:
---------------------------------------

This looks pretty good Deyan. +1 from me.

> NamingServiceContainer binds to all network interfaces
> ------------------------------------------------------
>
> Key: OFBIZ-2559
> URL: https://issues.apache.org/jira/browse/OFBIZ-2559
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Release Branch 9.04
> Reporter: Deyan
> Attachments: NamingServiceContainer_rmi_registry_bind_interface.patch, NamingServiceContainer_rmi_registry_bind_interface_v2.patch, Tabs_Issue.png
>
>
> org.ofbiz.base.container.NamingServiceContainer by default binds a server socket to all available network interfaces. Configuration of this container is done in
> framework/base/config/ofbiz-containers.xml
> 
> <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
> <property name="port" value="1099"/>
> </container>
> Only the port can be configured.
> Additional configuration property needs to be implemented:
> <property name="host" value="0.0.0.0"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751917#action_12751917 ]

Jacques Le Roux commented on OFBIZ-2559:
----------------------------------------

Hi Deyan,

I now get conflicts with your patch (and svn is down hence I can't use svn merge :/) , could you please update ?

Thanks

> NamingServiceContainer binds to all network interfaces
> ------------------------------------------------------
>
> Key: OFBIZ-2559
> URL: https://issues.apache.org/jira/browse/OFBIZ-2559
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Release Branch 9.04
> Reporter: Deyan
> Attachments: NamingServiceContainer_rmi_registry_bind_interface.patch, NamingServiceContainer_rmi_registry_bind_interface_v2.patch, Tabs_Issue.png
>
>
> org.ofbiz.base.container.NamingServiceContainer by default binds a server socket to all available network interfaces. Configuration of this container is done in
> framework/base/config/ofbiz-containers.xml
> 
> <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
> <property name="port" value="1099"/>
> </container>
> Only the port can be configured.
> Additional configuration property needs to be implemented:
> <property name="host" value="0.0.0.0"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-2559) NamingServiceContainer binds to all network interfaces

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2559.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Jacques Le Roux

Thanks Deyan,

Your patch is in trunk at r814390

> NamingServiceContainer binds to all network interfaces
> ------------------------------------------------------
>
> Key: OFBIZ-2559
> URL: https://issues.apache.org/jira/browse/OFBIZ-2559
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Release Branch 9.04
> Reporter: Deyan
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: NamingServiceContainer_rmi_registry_bind_interface.patch, NamingServiceContainer_rmi_registry_bind_interface_v2.patch, Tabs_Issue.png
>
>
> org.ofbiz.base.container.NamingServiceContainer by default binds a server socket to all available network interfaces. Configuration of this container is done in
> framework/base/config/ofbiz-containers.xml
> 
> <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
> <property name="port" value="1099"/>
> </container>
> Only the port can be configured.
> Additional configuration property needs to be implemented:
> <property name="host" value="0.0.0.0"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.