[jira] Created: (OFBIZ-2577) typos in serverstats.properties

[Nicolas Malin (Jira)]

typos in serverstats.properties
-------------------------------

                 Key: OFBIZ-2577
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: BJ Freeman
            Priority: Minor
             Fix For: Release Branch 9.04, SVN trunk


found some ftrue typos
corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-2577:
------------------------------

    Attachment: OFBIZ-2577-serverstat.patch

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones closed OFBIZ-2577.
---------------------------------

    Resolution: Won't Fix
      Assignee: David E. Jones

This isn't a typo. Anything but "true" is false, and this makes it easier to edit.

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717584#action_12717584 ]

BJ Freeman commented on OFBIZ-2577:
-----------------------------------

interesting.
since there both true and false in the file
what does ftrue signify?

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717598#action_12717598 ]

Jacques Le Roux commented on OFBIZ-2577:
----------------------------------------

ftrue == false (only true == true). David is not clear enough ?

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717661#action_12717661 ]

BJ Freeman commented on OFBIZ-2577:
-----------------------------------

thanks Jacques I was not clear enough.
the statement :it makes it easier to edit" was what  I was interested in.
why not set it to false like the others. is there something special about the ones with ftrue.

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717690#action_12717690 ]

Adrian Crum commented on OFBIZ-2577:
------------------------------------

It's a confusing hack. I'd like to see the patch committed. This is the third or so Jira issue created to fix this. Why do we want to intentionally confuse the other developers? Just make the setting false, and be done with it.

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717707#action_12717707 ]

Christian Geisert commented on OFBIZ-2577:
------------------------------------------

+1 for changing

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717710#action_12717710 ]

Jacques Le Roux commented on OFBIZ-2577:
----------------------------------------

+1 for changing all properties files

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones reassigned OFBIZ-2577:
-------------------------------------

    Assignee:     (was: David E. Jones)

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones reopened OFBIZ-2577:
-----------------------------------

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718518#action_12718518 ]

Vikas Mayur commented on OFBIZ-2577:
------------------------------------

Isn't it seems reasonable that any thing other then true is false? Can't we add some notes about it in Practice Application or any better place or even in the property file, as my vote would be to keep it intact.

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718529#action_12718529 ]

Adrian Crum commented on OFBIZ-2577:
------------------------------------

Vikas, there is no valid reason to keep it as-is.

David said this makes it easier to edit. Well, David took more time and keystrokes answering a developer's confusion on the subject than he would by just typing "true." It's pointless and confusing.

Besides, most of these configuration changes should be handled by patches, so there's no typing needed to change them.

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-2577.
------------------------------

    Resolution: Fixed

Committed to trunk, rev 783824.

Thanks, BJ.

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718531#action_12718531 ]

David E. Jones commented on OFBIZ-2577:
---------------------------------------

Yes, I agree we should just change it to "false" instead of "ftrue". It's not worth the hassle trying to explain it...

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718552#action_12718552 ]

Jacques Le Roux commented on OFBIZ-2577:
----------------------------------------

This is not the only place where ftrue is used in properties files. Should we not change them all ?

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718722#action_12718722 ]

Mridul Pathak commented on OFBIZ-2577:
--------------------------------------

I think we should, to maintain consistency across all the property files.  And since this change won't affect anything, we must do it.  I'll submit the patch for this soon.

--
Thanks,
Mridul Pathak

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718724#action_12718724 ]

Mridul Pathak commented on OFBIZ-2577:
--------------------------------------

I think we are not left with any occurrences of ftrue is property files.  I wasn't able to find any, so we are good at that, if I didn't missed any :).

--
Thanks,
Mridul Pathak

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718725#action_12718725 ]

Ashish Vijaywargiya commented on OFBIZ-2577:
--------------------------------------------

Hello Mridul,

Please refer trunk revision 783905.
I am sure you should find something interesting done in advance there ;)

--
Ashish

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718726#action_12718726 ]

Mridul Pathak commented on OFBIZ-2577:
--------------------------------------

This is certainly interesting :).  Thanks Jacques.

> typos in serverstats.properties
> -------------------------------
>
>                 Key: OFBIZ-2577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2577
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2577-serverstat.patch
>
>
> found some ftrue typos
> corrected them

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.