[jira] Created: (OFBIZ-2596) categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per row to display products vs 1 column per row from older versions.]

[Nicolas Malin (Jira)]

categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per  row to display products vs 1 column per row from older versions.]
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2596
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2596
             Project: OFBiz
          Issue Type: Bug
          Components: order
         Environment: Proposed change to the ~order/webapp/ordermgr/catalog/categorydetail.ftl screen
            Reporter: Ruth Hoffman
            Priority: Minor


First, someone should test this before committing! This is only a suggested change.
See comments for more info info:
Around line 23:
Change:
<#if (viewIndexMax?int > 0)>
To:
<#-- if the list size/view size (that is total number of items allowed on the page  for this page)
         is 0 or 1 then there is only 1 page of items - so display the pagination drop down anyhow
         'cause its cool and people should see it.
 -->
  <#if (viewIndexMax?int > -1)>

If you change that then, the listSize number following this doesn't make sense - on the demo screen it displays "1 of 9" so,
I propose that you also change line 37 from:

<#if (listSize?int > 0) >

To something like:
 <#if ((listSize?int - viewSize?int) > 0)>
so that the other text is not displayed in this case.

Not sure how multipage, 3 column listings will render, but this will at least make the display for the demo store show pagination.
Maybe someone who has more recent experience with this part of Freemarker pages can look at this really quickly and assess the impact overall.

Thanks
Ruth

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751919#action_12751919 ]

Jacques Le Roux commented on OFBIZ-2596:
----------------------------------------

Hi Ruth,

Could you please explain this in term of business and URL, ie
# What you did (including detailed steps to reproduce)
# What you expected to happen
# What actually happened (including exact quotes of error messages, etc)


Thanks

> categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per  row to display products vs 1 column per row from older versions.]
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2596
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>         Environment: Proposed change to the ~order/webapp/ordermgr/catalog/categorydetail.ftl screen
>            Reporter: Ruth Hoffman
>            Priority: Minor
>
> First, someone should test this before committing! This is only a suggested change.
> See comments for more info info:
> Around line 23:
> Change:
> <#if (viewIndexMax?int > 0)>
> To:
> <#-- if the list size/view size (that is total number of items allowed on the page  for this page)
>          is 0 or 1 then there is only 1 page of items - so display the pagination drop down anyhow
>          'cause its cool and people should see it.
>  -->
>   <#if (viewIndexMax?int > -1)>
> If you change that then, the listSize number following this doesn't make sense - on the demo screen it displays "1 of 9" so,
> I propose that you also change line 37 from:
> <#if (listSize?int > 0) >
> To something like:
>  <#if ((listSize?int - viewSize?int) > 0)>
> so that the other text is not displayed in this case.
> Not sure how multipage, 3 column listings will render, but this will at least make the display for the demo store show pagination.
> Maybe someone who has more recent experience with this part of Freemarker pages can look at this really quickly and assess the impact overall.
> Thanks
> Ruth

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751939#action_12751939 ]

Ruth Hoffman commented on OFBIZ-2596:
-------------------------------------

Hi Jacques:
Let me explain another way:

OOTB there are 9 products in the Promotions category in the Demo catalog. They are displayed in 3 rows. Each row has 3 products in it. (Hence the 3x3 matrix).

If I go to the Catalog Manager and add a 10th product to this category, it does not show up on the Promotions category list (the 3x3 list). Nor is there a way to navigate to it. The pagination has been overwritten by the layout of the 3x3 product listing. (Hence my patch suggestion.)

I will attach 2 graphics showing the Catalog Manager's view and the equivalent Promotions category view.

FYI - I just tried this to version 809901-trunk.

Thanks for looking at this.
Ruth

> categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per  row to display products vs 1 column per row from older versions.]
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2596
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>         Environment: Proposed change to the ~order/webapp/ordermgr/catalog/categorydetail.ftl screen
>            Reporter: Ruth Hoffman
>            Priority: Minor
>
> First, someone should test this before committing! This is only a suggested change.
> See comments for more info info:
> Around line 23:
> Change:
> <#if (viewIndexMax?int > 0)>
> To:
> <#-- if the list size/view size (that is total number of items allowed on the page  for this page)
>          is 0 or 1 then there is only 1 page of items - so display the pagination drop down anyhow
>          'cause its cool and people should see it.
>  -->
>   <#if (viewIndexMax?int > -1)>
> If you change that then, the listSize number following this doesn't make sense - on the demo screen it displays "1 of 9" so,
> I propose that you also change line 37 from:
> <#if (listSize?int > 0) >
> To something like:
>  <#if ((listSize?int - viewSize?int) > 0)>
> so that the other text is not displayed in this case.
> Not sure how multipage, 3 column listings will render, but this will at least make the display for the demo store show pagination.
> Maybe someone who has more recent experience with this part of Freemarker pages can look at this really quickly and assess the impact overall.
> Thanks
> Ruth

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Hoffman updated OFBIZ-2596:
--------------------------------

    Attachment: 2596-ecommercelist.jpg
                2596-categorylist.jpg

Added the "Purple Gizmo" to this category. Observe there are now 10 products in category.

2nd graphic - screen shot of the Promotions category. Only 9 products shown and no way to get to the 10th product. Pagination has been overwritten by the layout of the 3x3 product listing.

> categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per  row to display products vs 1 column per row from older versions.]
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2596
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>         Environment: Proposed change to the ~order/webapp/ordermgr/catalog/categorydetail.ftl screen
>            Reporter: Ruth Hoffman
>            Priority: Minor
>         Attachments: 2596-categorylist.jpg, 2596-ecommercelist.jpg
>
>
> First, someone should test this before committing! This is only a suggested change.
> See comments for more info info:
> Around line 23:
> Change:
> <#if (viewIndexMax?int > 0)>
> To:
> <#-- if the list size/view size (that is total number of items allowed on the page  for this page)
>          is 0 or 1 then there is only 1 page of items - so display the pagination drop down anyhow
>          'cause its cool and people should see it.
>  -->
>   <#if (viewIndexMax?int > -1)>
> If you change that then, the listSize number following this doesn't make sense - on the demo screen it displays "1 of 9" so,
> I propose that you also change line 37 from:
> <#if (listSize?int > 0) >
> To something like:
>  <#if ((listSize?int - viewSize?int) > 0)>
> so that the other text is not displayed in this case.
> Not sure how multipage, 3 column listings will render, but this will at least make the display for the demo store show pagination.
> Maybe someone who has more recent experience with this part of Freemarker pages can look at this really quickly and assess the impact overall.
> Thanks
> Ruth

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751943#action_12751943 ]

Jacques Le Roux commented on OFBIZ-2596:
----------------------------------------

OK, I see, thanks Ruth!

> categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per  row to display products vs 1 column per row from older versions.]
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2596
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>         Environment: Proposed change to the ~order/webapp/ordermgr/catalog/categorydetail.ftl screen
>            Reporter: Ruth Hoffman
>            Priority: Minor
>         Attachments: 2596-categorylist.jpg, 2596-ecommercelist.jpg
>
>
> First, someone should test this before committing! This is only a suggested change.
> See comments for more info info:
> Around line 23:
> Change:
> <#if (viewIndexMax?int > 0)>
> To:
> <#-- if the list size/view size (that is total number of items allowed on the page  for this page)
>          is 0 or 1 then there is only 1 page of items - so display the pagination drop down anyhow
>          'cause its cool and people should see it.
>  -->
>   <#if (viewIndexMax?int > -1)>
> If you change that then, the listSize number following this doesn't make sense - on the demo screen it displays "1 of 9" so,
> I propose that you also change line 37 from:
> <#if (listSize?int > 0) >
> To something like:
>  <#if ((listSize?int - viewSize?int) > 0)>
> so that the other text is not displayed in this case.
> Not sure how multipage, 3 column listings will render, but this will at least make the display for the demo store show pagination.
> Maybe someone who has more recent experience with this part of Freemarker pages can look at this really quickly and assess the impact overall.
> Thanks
> Ruth

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751946#action_12751946 ]

Jacques Le Roux commented on OFBIZ-2596:
----------------------------------------

BTW Ruth, this is only true for the PROMOTIONS category (aka Featured  Products category). But yes, I think we should take care of it and allow pagination.

> categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per  row to display products vs 1 column per row from older versions.]
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2596
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>         Environment: Proposed change to the ~order/webapp/ordermgr/catalog/categorydetail.ftl screen
>            Reporter: Ruth Hoffman
>            Priority: Minor
>         Attachments: 2596-categorylist.jpg, 2596-ecommercelist.jpg
>
>
> First, someone should test this before committing! This is only a suggested change.
> See comments for more info info:
> Around line 23:
> Change:
> <#if (viewIndexMax?int > 0)>
> To:
> <#-- if the list size/view size (that is total number of items allowed on the page  for this page)
>          is 0 or 1 then there is only 1 page of items - so display the pagination drop down anyhow
>          'cause its cool and people should see it.
>  -->
>   <#if (viewIndexMax?int > -1)>
> If you change that then, the listSize number following this doesn't make sense - on the demo screen it displays "1 of 9" so,
> I propose that you also change line 37 from:
> <#if (listSize?int > 0) >
> To something like:
>  <#if ((listSize?int - viewSize?int) > 0)>
> so that the other text is not displayed in this case.
> Not sure how multipage, 3 column listings will render, but this will at least make the display for the demo store show pagination.
> Maybe someone who has more recent experience with this part of Freemarker pages can look at this really quickly and assess the impact overall.
> Thanks
> Ruth

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2596.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 9.04
         Assignee: Jacques Le Roux

Ruth,

I have tried your changes with 19 products and it works well. So i commited in trunk at r811860 and R9.04 at r 811861
A small change (only the 2d change was needed) and a great improvment :)

> categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per  row to display products vs 1 column per row from older versions.]
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2596
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>         Environment: Proposed change to the ~order/webapp/ordermgr/catalog/categorydetail.ftl screen
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: 2596-categorylist.jpg, 2596-ecommercelist.jpg
>
>
> First, someone should test this before committing! This is only a suggested change.
> See comments for more info info:
> Around line 23:
> Change:
> <#if (viewIndexMax?int > 0)>
> To:
> <#-- if the list size/view size (that is total number of items allowed on the page  for this page)
>          is 0 or 1 then there is only 1 page of items - so display the pagination drop down anyhow
>          'cause its cool and people should see it.
>  -->
>   <#if (viewIndexMax?int > -1)>
> If you change that then, the listSize number following this doesn't make sense - on the demo screen it displays "1 of 9" so,
> I propose that you also change line 37 from:
> <#if (listSize?int > 0) >
> To something like:
>  <#if ((listSize?int - viewSize?int) > 0)>
> so that the other text is not displayed in this case.
> Not sure how multipage, 3 column listings will render, but this will at least make the display for the demo store show pagination.
> Maybe someone who has more recent experience with this part of Freemarker pages can look at this really quickly and assess the impact overall.
> Thanks
> Ruth

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751950#action_12751950 ]

Jacques Le Roux commented on OFBIZ-2596:
----------------------------------------

I finally decided to show the pages dropdown only if needed, done in trunk at r811865 and R9.04 at r811867

> categorydetail.ftl page select drop-down and pagination is not compatible with new screen called categorydetailmatrix.ftl. [Screen uses 3 columns per  row to display products vs 1 column per row from older versions.]
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2596
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2596
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>         Environment: Proposed change to the ~order/webapp/ordermgr/catalog/categorydetail.ftl screen
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: 2596-categorylist.jpg, 2596-ecommercelist.jpg
>
>
> First, someone should test this before committing! This is only a suggested change.
> See comments for more info info:
> Around line 23:
> Change:
> <#if (viewIndexMax?int > 0)>
> To:
> <#-- if the list size/view size (that is total number of items allowed on the page  for this page)
>          is 0 or 1 then there is only 1 page of items - so display the pagination drop down anyhow
>          'cause its cool and people should see it.
>  -->
>   <#if (viewIndexMax?int > -1)>
> If you change that then, the listSize number following this doesn't make sense - on the demo screen it displays "1 of 9" so,
> I propose that you also change line 37 from:
> <#if (listSize?int > 0) >
> To something like:
>  <#if ((listSize?int - viewSize?int) > 0)>
> so that the other text is not displayed in this case.
> Not sure how multipage, 3 column listings will render, but this will at least make the display for the demo store show pagination.
> Maybe someone who has more recent experience with this part of Freemarker pages can look at this really quickly and assess the impact overall.
> Thanks
> Ruth

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.