[jira] Created: (OFBIZ-2602) Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.

[Nicolas Malin (Jira)]

Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
-----------------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2602
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
             Project: OFBiz
          Issue Type: Improvement
    Affects Versions: Release Branch 9.04, SVN trunk
         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
            Reporter: Ruth Hoffman
             Fix For: Release Branch 9.04, SVN trunk


To fix this, add the following line to the ecommain.css:

#ecom-mainarea .center {
margin-left:201px;
margin-right:261px;
overflow: hidden;      <------------------------ add this
voice-family:inherit;
}

This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Hoffman updated OFBIZ-2602:
--------------------------------

    Description:
To fix this, add the following line to the ecommain.css:

#ecom-mainarea .center {

margin-left:201px;

margin-right:261px;

overflow: hidden;      <------------------------ add this

voice-family:inherit;

}

This will force any overflow to be cropped.

  was:
To fix this, add the following line to the ecommain.css:

#ecom-mainarea .center {
margin-left:201px;
margin-right:261px;
overflow: hidden;      <------------------------ add this
voice-family:inherit;
}

This will force any overflow to be cropped.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>
> To fix this, add the following line to the ecommain.css:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow: hidden;      <------------------------ add this
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Hoffman updated OFBIZ-2602:
--------------------------------

    Description:
To fix this, add the following line to the ecommain.css:
OLD version:
#ecom-mainarea .center {
margin-left:201px;
margin-right:261px;  
voice-family:inherit;
}

NEW version
#ecom-mainarea .center {
margin-left:201px;
margin-right:261px;
overflow:hidden;  
voice-family:inherit;
}
This will force any overflow to be cropped.

  was:
To fix this, add the following line to the ecommain.css:

#ecom-mainarea .center {

margin-left:201px;

margin-right:261px;

overflow: hidden;      <------------------------ add this

voice-family:inherit;

}

This will force any overflow to be cropped.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719157#action_12719157 ]

BJ Freeman commented on OFBIZ-2602:
-----------------------------------

ruth if you could make this a patch
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
otherwise the commiters have extra work on  a volunteer group that does a lot.
:D

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Ruth Hoffman-2]

Sure.
Ruth
BJ Freeman (JIRA) wrote:

>     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719157#action_12719157 ]
>
> BJ Freeman commented on OFBIZ-2602:
> -----------------------------------
>
> ruth if you could make this a patch
> http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
> otherwise the commiters have extra work on  a volunteer group that does a lot.
> :D
>
>
>  
>> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
>> -----------------------------------------------------------------------------------------------------------------------------------------
>>
>>                 Key: OFBIZ-2602
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>>             Project: OFBiz
>>          Issue Type: Improvement
>>    Affects Versions: Release Branch 9.04, SVN trunk
>>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>>            Reporter: Ruth Hoffman
>>             Fix For: Release Branch 9.04, SVN trunk
>>
>>
>> To fix this, add the following line to the ecommain.css:
>> OLD version:
>> #ecom-mainarea .center {
>> margin-left:201px;
>> margin-right:261px;  
>> voice-family:inherit;
>> }
>> NEW version
>> #ecom-mainarea .center {
>> margin-left:201px;
>> margin-right:261px;
>> overflow:hidden;  
>> voice-family:inherit;
>> }
>> This will force any overflow to be cropped.
>>    
>
>  

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Hoffman updated OFBIZ-2602:
--------------------------------

    Attachment: ecommain.css.patch

In ecommain.css:
Remove lines 310 - 314 and insert the contents of ecommain.css.patch

This should replace the existing #ecom-mainarea .center style with a new style that includes the following line:

overflow: hidden

Thanks

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Ruth Hoffman-2]

Hi BJ:
Not sure if I did what you asked correctly. Please let me know if I need
to do this again - some other way.
Regards,
Ruth
Ruth Hoffman wrote:

> Sure.
> Ruth
> BJ Freeman (JIRA) wrote:
>>     [
>> https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719157#action_12719157 
>> ]
>> BJ Freeman commented on OFBIZ-2602:
>> -----------------------------------
>>
>> ruth if you could make this a patch
>> http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
>> otherwise the commiters have extra work on  a volunteer group that
>> does a lot.
>> :D
>>
>>
>>  
>>> Main storefront page, Featured Products (middle column) overwrites
>>> right column. Should just crop column, but not overwrite right column.
>>> -----------------------------------------------------------------------------------------------------------------------------------------
>>>
>>>
>>>                 Key: OFBIZ-2602
>>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>>>             Project: OFBiz
>>>          Issue Type: Improvement
>>>    Affects Versions: Release Branch 9.04, SVN trunk
>>>         Environment: Note: when using a table inside a div as is
>>> done w/matrix category layout, the table expands past the div in all
>>> but the largest browser windows (with the smallest font settings)
>>> and overwrites the right column. Very messy.  At a minimum, the
>>> middle column should just be cropped - this will force the user to
>>> expand the browser if they want to see all that is in the middle
>>> column. [Better fix is to make the whole thing fluid - but that
>>> would require a major CSS & possibly widget redo.]
>>>            Reporter: Ruth Hoffman
>>>             Fix For: Release Branch 9.04, SVN trunk
>>>
>>>
>>> To fix this, add the following line to the ecommain.css:
>>> OLD version:
>>> #ecom-mainarea .center {
>>> margin-left:201px;
>>> margin-right:261px;   voice-family:inherit;
>>> }
>>> NEW version
>>> #ecom-mainarea .center {
>>> margin-left:201px;
>>> margin-right:261px; overflow:hidden;  voice-family:inherit;
>>> }
>>> This will force any overflow to be cropped.
>>>    
>>
>>  
>
>

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719177#action_12719177 ]

BJ Freeman commented on OFBIZ-2602:
-----------------------------------

in the link I gave you is steps to create a patch.
you use the SVn commands.
:D
thanks for the effort

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Ruth Hoffman-2]

Sorry, I was looking for something specific like that but didn't see it.
Let me look again!
Ruth
BJ Freeman (JIRA) wrote:

>     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719177#action_12719177 ]
>
> BJ Freeman commented on OFBIZ-2602:
> -----------------------------------
>
> in the link I gave you is steps to create a patch.
> you use the SVn commands.
> :D
> thanks for the effort
>
>
>
>  
>> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
>> -----------------------------------------------------------------------------------------------------------------------------------------
>>
>>                 Key: OFBIZ-2602
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>>             Project: OFBiz
>>          Issue Type: Improvement
>>    Affects Versions: Release Branch 9.04, SVN trunk
>>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>>            Reporter: Ruth Hoffman
>>             Fix For: Release Branch 9.04, SVN trunk
>>
>>         Attachments: ecommain.css.patch
>>
>>
>> To fix this, add the following line to the ecommain.css:
>> OLD version:
>> #ecom-mainarea .center {
>> margin-left:201px;
>> margin-right:261px;  
>> voice-family:inherit;
>> }
>> NEW version
>> #ecom-mainarea .center {
>> margin-left:201px;
>> margin-right:261px;
>> overflow:hidden;  
>> voice-family:inherit;
>> }
>> This will force any overflow to be cropped.
>>    
>
>  

[Ruth Hoffman-2]

Ah, now I see - I didn't scroll down far enough...
Ruth
BJ Freeman (JIRA) wrote:

>     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719177#action_12719177 ]
>
> BJ Freeman commented on OFBIZ-2602:
> -----------------------------------
>
> in the link I gave you is steps to create a patch.
> you use the SVn commands.
> :D
> thanks for the effort
>
>
>
>  
>> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
>> -----------------------------------------------------------------------------------------------------------------------------------------
>>
>>                 Key: OFBIZ-2602
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>>             Project: OFBiz
>>          Issue Type: Improvement
>>    Affects Versions: Release Branch 9.04, SVN trunk
>>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>>            Reporter: Ruth Hoffman
>>             Fix For: Release Branch 9.04, SVN trunk
>>
>>         Attachments: ecommain.css.patch
>>
>>
>> To fix this, add the following line to the ecommain.css:
>> OLD version:
>> #ecom-mainarea .center {
>> margin-left:201px;
>> margin-right:261px;  
>> voice-family:inherit;
>> }
>> NEW version
>> #ecom-mainarea .center {
>> margin-left:201px;
>> margin-right:261px;
>> overflow:hidden;  
>> voice-family:inherit;
>> }
>> This will force any overflow to be cropped.
>>    
>
>  

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Hoffman updated OFBIZ-2602:
--------------------------------

    Attachment: ecommain.css.patch

See if this is any better as a patch file? From svn diff command.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Hoffman updated OFBIZ-2602:
--------------------------------

    Attachment:     (was: ecommain.css.patch)

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Hoffman updated OFBIZ-2602:
--------------------------------

    Attachment:     (was: ecommain.css.patch)

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruth Hoffman updated OFBIZ-2602:
--------------------------------

    Attachment: ecommain.css.patch

This is the real patch file.
From svn diff command.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719207#action_12719207 ]

BJ Freeman commented on OFBIZ-2602:
-----------------------------------

Looks good
a suggestion for future patches is to put the Jira number on the patch file  name.
but no need to do that for this one.
thanks for all your effort.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Ruth Hoffman-2]

Great. Glad to help.
I'll do one for the "Browse Categories" list (ul) extra lines.
Ruth
BJ Freeman (JIRA) wrote:

>     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719207#action_12719207 ]
>
> BJ Freeman commented on OFBIZ-2602:
> -----------------------------------
>
> Looks good
> a suggestion for future patches is to put the Jira number on the patch file  name.
> but no need to do that for this one.
> thanks for all your effort.
>
>
>  
>> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
>> -----------------------------------------------------------------------------------------------------------------------------------------
>>
>>                 Key: OFBIZ-2602
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>>             Project: OFBiz
>>          Issue Type: Improvement
>>    Affects Versions: Release Branch 9.04, SVN trunk
>>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>>            Reporter: Ruth Hoffman
>>             Fix For: Release Branch 9.04, SVN trunk
>>
>>         Attachments: ecommain.css.patch
>>
>>
>> To fix this, add the following line to the ecommain.css:
>> OLD version:
>> #ecom-mainarea .center {
>> margin-left:201px;
>> margin-right:261px;  
>> voice-family:inherit;
>> }
>> NEW version
>> #ecom-mainarea .center {
>> margin-left:201px;
>> margin-right:261px;
>> overflow:hidden;  
>> voice-family:inherit;
>> }
>> This will force any overflow to be cropped.
>>    
>
>  

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2602.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Ruth,

Your patch is in trunk at r811419 , R9.04 at r811429  

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reopened OFBIZ-2602:
-------------------------------


Reopening since Jacques has reverted the commits due to my reporting of it causing problems for Safari (4.0.3 on Mac OSX)

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752056#action_12752056 ]

Jacques Le Roux commented on OFBIZ-2602:
----------------------------------------

Scott's comment on dev ML
{quote}
Personally though I don't think cropping the product grid is the right  
way to go, the page should simply be made wider to accommodate  
everything.  The customer would have a pretty strange shopping  
experience if 1/3 of the products are missing...
{quote}

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752109#action_12752109 ]

Ruth Hoffman commented on OFBIZ-2602:
-------------------------------------

Agreed. You could make the page wider, but then that doesn't always work either. If you make the page wider you risk loosing the entire right column to resizing. I suppose then you could also "request" that the browser not resize, but that is no guarantee.

IMHO, this layout should be reverted back to the rev 4.x pattern of one product per "line" until someone commits to doing the design and CSS correctly for a fluid 3 column layout. (if that is, in fact the effect the original change was trying to achieve).  Anything less is sloppy and not befitting the project.

Just my 2 cents.

Ruth

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.