[jira] Created: (OFBIZ-2602) Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765231#action_12765231 ]

Scott Gray commented on OFBIZ-2602:
-----------------------------------

all that needs to be done is to remove the table and add a float left property to the product box, the products will then fit themselves into as many columns as the screen width allows for.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2602:
-----------------------------------

    Issue Type: Sub-task  (was: Improvement)
        Parent: OFBIZ-3037

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767296#action_12767296 ]

Jacques Le Roux commented on OFBIZ-2602:
----------------------------------------

I tried to change numCol value to 1 in

{code}
<screen name="categorydetailmatrix">
        <section>
            <actions>
                <set field="numCol" value="3"/>
{code}

but  on XP with FF 3.5, Opera, Chrome, IE8 and  Safari, I got same issue: the 1st product is shown at the right place but the others are under the last element of the left column. I guess it's only a small change in CSS but I don't have time for that for the moment...

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767323#action_12767323 ]

Ruth Hoffman commented on OFBIZ-2602:
-------------------------------------

That tells me that the screen "numCol" feature is broken as well as the matrix layout. Wouldn't you agree? If not, what was the original intent of the numCol field?
Given that it is now generally acknowledged that the 3x3 matrix rendering is broken and that the original code to build the 3x3 matrix is broken, and that no one is able or has the time to fix this, could we revert back to the rendering in the 4.x version. At least that worked.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767356#action_12767356 ]

Jacques Le Roux commented on OFBIZ-2602:
----------------------------------------

Ruth,

I agree and if nobody tackles this problem in the week I will revert. But maybe it's not much in the numCol=1 case and we could fix it, to keep this feature on hand

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767498#action_12767498 ]

Bruno Busco commented on OFBIZ-2602:
------------------------------------

If you select the multiflex theme (a fixed with theme) it looks ok.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-2602:
---------------------------------

    Assignee: Scott Gray  (was: Jacques Le Roux)

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch, ProductGrid.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-2602:
------------------------------

    Attachment: ProductGrid.patch

Try this out on your browser and let me know what you think

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch, ProductGrid.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767509#action_12767509 ]

Bruno Busco commented on OFBIZ-2602:
------------------------------------

Scott,
I have tested your patch.
I think it could be OK.
On a line appears as many products as can fit,
When changing the browser window width the number of products on a row dinamically change.
Bingo!

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch, ProductGrid.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767511#action_12767511 ]

Bruno Busco commented on OFBIZ-2602:
------------------------------------

Moreover the one product per row is still possible and user activable.
Simply go to
https://localhost:8443/catalog/control/EditCategory?productCategoryId=PROMOTIONS
and empty the "Detail Screen" field.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch, ProductGrid.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767516#action_12767516 ]

Bruno Busco commented on OFBIZ-2602:
------------------------------------

Unfortunately in the one product per row mode another layout issue is present.
Onlly the first product is in the correct place while all other are below the left column.

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch, ProductGrid.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767746#action_12767746 ]

Jacques Le Roux commented on OFBIZ-2602:
----------------------------------------

Yes Bruno,

It's the same issue than I reported when using numCol=1. Looks like a CSS issue introduced since the old layout (1 product per row) has been replaced

> Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Note: when using a table inside a div as is done w/matrix category layout, the table expands past the div in all but the largest browser windows (with the smallest font settings) and overwrites the right column. Very messy.  At a minimum, the middle column should just be cropped - this will force the user to expand the browser if they want to see all that is in the middle column. [Better fix is to make the whole thing fluid - but that would require a major CSS & possibly widget redo.]
>            Reporter: Ruth Hoffman
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: ecommain.css.patch, ProductGrid.patch
>
>
> To fix this, add the following line to the ecommain.css:
> OLD version:
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;  
> voice-family:inherit;
> }
> NEW version
> #ecom-mainarea .center {
> margin-left:201px;
> margin-right:261px;
> overflow:hidden;  
> voice-family:inherit;
> }
> This will force any overflow to be cropped.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.