[jira] Created: (OFBIZ-2613) MiniProductSummary : showPricesWithVatTax and Currency

[Nicolas Malin (Jira)]

MiniProductSummary : showPricesWithVatTax and Currency
-------------------------------------------------------

                 Key: OFBIZ-2613
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
             Project: OFBiz
          Issue Type: Bug
          Components: specialpurpose/ecommerce
    Affects Versions: SVN trunk
         Environment: Linux Debian, trunk revision 782859
            Reporter: Eric DE MAULDE
            Priority: Trivial
             Fix For: SVN trunk


MiniProductSummary doesn't display price with VAT if it's defined into the store
Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2613:
----------------------------------

    Attachment: miniproductsummary.patch

This patch displays price with VAT if it's required
Currency is always displayed

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 782859
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: miniproductsummary.patch
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2613:
--------------------------------------

    Assignee: Jacques Le Roux

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 782859
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: miniproductsummary.patch
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744408#action_12744408 ]

Jacques Le Roux commented on OFBIZ-2613:
----------------------------------------

Hi Eric,

Could you make a new patch, I get this error

D:\workspace\ofbizRun>patch -p0  0<miniproductsummary.patch
patching file specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/catalog/MiniProductSummary.groovy
patch: **** malformed patch at line 45: Index: specialpurpose/ecommerce/webapp/ecommerce/catalog/miniproductsummary.ftl

Thanks

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 782859
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: miniproductsummary.patch
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2613:
----------------------------------

    Attachment:     (was: miniproductsummary.patch)

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 782859
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2613:
----------------------------------

    Attachment: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch

Patch created from trunk version 805338

This patch displays price with VAT if it's required
Currency is always displayed

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 782859
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2613:
----------------------------------

    Environment: Linux Debian, trunk revision 805338  (was: Linux Debian, trunk revision 782859)

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 805338
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751465#action_12751465 ]

Jacques Le Roux commented on OFBIZ-2613:
----------------------------------------

Hi Eric,

I can see any differences, though the code seems to do something. Could you please give me an example based on OOTB products ?

Thanks

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 805338
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751547#action_12751547 ]

Eric DE MAULDE commented on OFBIZ-2613:
---------------------------------------

Hi Jacques,

The difference is from an aggregated product
http://demo.ofbiz.org/ecommerce/control/product/~product_id=PC001

Into the patch for "configproductpetail.ftl", the variable can be both "BigDecimal" and a "Map" (L 235)
... amount=totalPrice isoCode=totalPrice.currencyUsed ...

So, $ dollar is the default currency
But I can get an error if my store currency is Euro or ...
See screenshot

Same error into "miniproductsummary.ftl" for the LAST PRODUCT screen
More, price doesn't display with VAT

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 805338
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2613:
----------------------------------

    Attachment: Screenshot.jpg
                Screenshot.png

Screenshot 1 : Personnal server
Right linguistic configuration
Just file "miniproductsummary.ftl" for LAST PRODUCTS is modified
See the currency difference between LAST PRODUCTS and CURRENT PRODUCT

Screenshot 2 : Demo server
Currency is absent
My browser is Firefox in English or in French, but my Window linguistic configuration is French

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 805338
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch, Screenshot.jpg, Screenshot.png
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2613:
----------------------------------

    Attachment: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch

This patch modifies :
- miniproductsummary.ftl
- configproductdetail.ftl

to display the right currency for an aggregated product
to display price with TVA into LAST PRODUCTS screen if configured in store

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 805338
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch, OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch, Screenshot.jpg, Screenshot.png
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2613:
----------------------------------

    Attachment:     (was: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch)

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 805338
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch, Screenshot.jpg, Screenshot.png
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2613.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 9.04

Thanks Eric,

Your patch is in trunk at r811716, R9.04 at r811717  

> MiniProductSummary : showPricesWithVatTax and Currency
> -------------------------------------------------------
>
>                 Key: OFBIZ-2613
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2613
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk revision 805338
>            Reporter: Eric DE MAULDE
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2613_MiniProductSummary_showPricesWithVatTax-And-Currency.patch, Screenshot.jpg, Screenshot.png
>
>
> MiniProductSummary doesn't display price with VAT if it's defined into the store
> Sometimes "totalPrice.currencyUsed" is null

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.