[jira] Created: (OFBIZ-2619) Issues with Receive PO functionality

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
Issues with Receive PO functionality
------------------------------------

                 Key: OFBIZ-2619
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Mridul Pathak
             Fix For: Release Branch 9.04, SVN trunk


Following are the issues that I came across while going through different scenarios of receiving PO:

# Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
## Before receiving shipment:
OrderItem.quantity = 10
## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
OrderItem.quantity = 10
Received quantity = 5
ShipmentItem.quantity = 5
ItemIssuance.quantity = 5
Total ItemIssuance.quantity = 5
## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
OrderItem.quantity = 10
Received quantity = 7
ShipmentItem.quantity = 12 (5 + 7)
ItemIssuance.quantity = 7
Total ItemIssuance.quantity = 12 (5 + 7)
# Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
OrderItem.quantity = 5
## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
OrderItem.quantity = 5
Issued quantity = 5
ShipmentItem.quantity = 5
ItemIssuance.quantity = 5
Total ItemIssuance.quantity = 5
## On receiving shipment - ShipmentItem updated, new ItemIssuance created
OrderItem.quantity = 5
Received quantity =  5
ShipmentItem.quantity = 10
ItemIssuance.quantity = 5
Total ItemIssuance.quantity = 10 (5 + 5)
This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
# Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
# Quick Receive Purchase Order
If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
## Same as #3-a and #3-b.
## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.

Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-2619:
---------------------------------

    Attachment: OFBiz-2619.patch

The attached patch fixes the above described issues.

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-2619:
---------------------------------

    Attachment: OFBiz-2619.patch

Updated patch which uses UEL instead of <calculate> for arithmetic operations.

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2619:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2619.
--------------------------------------


Thanks a lot Mridul !
Changes are in revisions 786013 & 786014 (trunk & RB9.04 respectively).

--
Ashish Vijaywargiya

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721198#action_12721198 ]

Mridul Pathak commented on OFBIZ-2619:
--------------------------------------

Thanks Ashish :).

--
Mridul Pathak

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reopened OFBIZ-2619:
----------------------------------------


As per Mridul's request and comment from Adrian to update code to use UEL in better way, I am opening this issue.

--
Ashish

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766994#action_12766994 ]

Scott Gray commented on OFBIZ-2619:
-----------------------------------

Anyone know what the comment was that caused this issue to be reopened?

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768068#action_12768068 ]

Mridul Pathak commented on OFBIZ-2619:
--------------------------------------

Scott,

    Adrian suggested to use variable name modifiers in the UEL arithmetic done in this patch, but we encountered a bug in use of variable name modifiers and I was not able to provide the updated patch at that time.  Now that bug has been fixed in OFBIZ-2928 and I'll provide the updated patch for this issue in a day or two.

--
Mridul Pathak

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768127#action_12768127 ]

Scott Gray commented on OFBIZ-2619:
-----------------------------------

Okay thanks Mridul, I was fixing a unit test last weekend that touched some of this code and so was curious as to what the issue was.

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-2619:
---------------------------------

    Attachment: OFBiz-2619.patch

Ashish, please find the updated patch with use of variable name modifiers in UEL arithmetic, as suggested by Adrian.

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781408#action_12781408 ]

Ashish Vijaywargiya commented on OFBIZ-2619:
--------------------------------------------

Mridul, Thanks for the contribution - your changes are in trunk at r883348.
Your changes looks good to me.

I would wait for Adrian's comment for next 1 or 2 days then we will close this issue.

--
Ashish Vijaywargiya

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781416#action_12781416 ]

Mridul Pathak commented on OFBIZ-2619:
--------------------------------------

Thanks for committing the patch, Ashish.  It would be good to port this fix to the release 9.04 too as this particular issue and bug fix in OFBIZ-2928 are already being ported to the release branch.

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781774#action_12781774 ]

Ashish Vijaywargiya commented on OFBIZ-2619:
--------------------------------------------

Will do it today, Mridul.
Thanks for your comment.

--
Ashish

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2619) Issues with Receive PO functionality

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2619.
--------------------------------------

    Resolution: Fixed

Thanks Mridul for the contribution.
Yesterday I had put your changes in trunk and today it is back ported to release branch 9.04 at r883604.

Also closing this issue.
We will reopen it if we see any comment from Adrian or others? on recent changes.

--
Ashish Vijaywargiya

> Issues with Receive PO functionality
> ------------------------------------
>
>                 Key: OFBIZ-2619
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2619
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2619.patch, OFBiz-2619.patch, OFBiz-2619.patch
>
>
> Following are the issues that I came across while going through different scenarios of receiving PO:
> # Create a shipment and receive it from Facility > Shipment > Receive Against PO (This scenario works correctly)
> ## Before receiving shipment:
> OrderItem.quantity = 10
> ## Receiving half if the ordered quantity - New ShipmentItem record created.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## Receiving remaining quantity but receiving some extra quantity too - ShipmentItem record updated.  New ItemIssuance record created.
> OrderItem.quantity = 10
> Received quantity = 7
> ShipmentItem.quantity = 12 (5 + 7)
> ItemIssuance.quantity = 7
> Total ItemIssuance.quantity = 12 (5 + 7)
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Shipment > Receive Against PO
> ## Before Issuing Order Items - No ShipmentItem or ItemIssuance record
> OrderItem.quantity = 5
> ## After Issuing Order Items - ShipmentItem created, ItemIssuance created.
> OrderItem.quantity = 5
> Issued quantity = 5
> ShipmentItem.quantity = 5
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 5
> ## On receiving shipment - ShipmentItem updated, new ItemIssuance created
> OrderItem.quantity = 5
> Received quantity =  5
> ShipmentItem.quantity = 10
> ItemIssuance.quantity = 5
> Total ItemIssuance.quantity = 10 (5 + 5)
> This seems to be a weird behavior.  When I have already issued the item in #b, then on receiving the shipment for the same orderItem quantity in #c, the ShipmentItem shouldn't be updated and new item issuance shouldn't be created (creating new item issuance means that I am re-issuing the items).
> # Create a shipment, issue order items from Facility > Shipment > Order Items, then receive it from Facility > Facilities > Receive Inventory by selecting PO and the respective newly created shipment.
> If I issue the same (or more) quantity as ordered for the Order Item and then receive the exact amount that has been issued (in one or more steps) this scenario works fine.  in following scenarios there is no change in ShipmentItem and ItemIssuance, which causes conflicts:
> ## I issue same quantity as ordered for the Order Item but while receiving receive more than the issued ordered quantity.
> ## I issue same quantity as ordered for the Order Item.  While receiving, receive less first time.  Go back to same screen again.  Receive more than the remaining ordered quantity.
> ## I issue less quantity than ordered for the Order Item but receive more than the issued order item quantity.
> # Quick Receive Purchase Order
> If I Quick Receive Purchase Order from Order Detail page, Shipment is created and all the Order Items are issued and I am taken to the Receive Inventory screen directly.  If I receive exactly the same amount as ordered for each order item (at one go, or receiving it in parts) functionality works fine.  But following are the scenarios which breaks everything.
> ## Same as #3-a and #3-b.
> ## If I receive less quantity than the quantity ordered for order item, and receive remaining (or more)  ordered quantity from Facility > Shipment > Receive against PO then same issue as reported in #2 occurs.
> Note: For testing these issues, comment out eca action updatePoOnReceiveInventory at line no. 55 in order/servicedef/secas.xml.  This service was recently added in revision 757749, but it only covers #3-a and #3-c below partially and its logic needs to be rewritten.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.