[jira] Created: (OFBIZ-2635) Order notes are not displayed on sales order pdf, instead of that it gives error.

[Nicolas Malin (Jira)]

Order notes are not displayed on sales order pdf, instead of that it gives error.
----------------------------------------------------------------------------------

                 Key: OFBIZ-2635
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2635
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Ratnesh Upadhyay
             Fix For: Release Branch 9.04, SVN trunk


To regenerate the error :

1). Create a sales order.
2). Add notes for this order.
3). Depress on PDF link.

Regards,
-- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akash Jain updated OFBIZ-2635:
------------------------------

    Attachment: OrderNotesAreNotDisplayed_OFBIZ-2635.patch

Hello Ratnesh,

I am uploading the patch for solving following bugs :-

1) "Create Note" for any sales order and depress PDF button now it is not shown error
2) Worked for secure URL, now "Save" button works fine on "Add Note" screen.

Steps for testing :-

1) create sales order should be in Approved status
2) depress "Create New" then add note and depress "Save" button
3) now depress PDF button from View Order screen for above order, pdf will open properly

> Order notes are not displayed on sales order pdf, instead of that it gives error.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2635
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2635
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderNotesAreNotDisplayed_OFBIZ-2635.patch
>
>
> To regenerate the error :
> 1). Create a sales order.
> 2). Add notes for this order.
> 3). Depress on PDF link.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2635:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Order notes are not displayed on sales order pdf, instead of that it gives error.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2635
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2635
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderNotesAreNotDisplayed_OFBIZ-2635.patch
>
>
> To regenerate the error :
> 1). Create a sales order.
> 2). Add notes for this order.
> 3). Depress on PDF link.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akash Jain updated OFBIZ-2635:
------------------------------

    Attachment: OrderNotesAreNotDisplayed_OFBIZ-2635.patch

There is minor changes in previous uploaded patch, now after depress "Save" button on "Add Note" screen shown View Order screen instead on Order List screen.

> Order notes are not displayed on sales order pdf, instead of that it gives error.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2635
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2635
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch
>
>
> To regenerate the error :
> 1). Create a sales order.
> 2). Add notes for this order.
> 3). Depress on PDF link.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akash Jain updated OFBIZ-2635:
------------------------------

    Attachment: OrderNotesAreNotDisplayed_OFBIZ-2635.patch

Improvement, now "Note" heading shown on pdf only when, then select Internal Note to "No" when "Add Note" to a sales order.

> Order notes are not displayed on sales order pdf, instead of that it gives error.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2635
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2635
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch
>
>
> To regenerate the error :
> 1). Create a sales order.
> 2). Add notes for this order.
> 3). Depress on PDF link.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akash Jain updated OFBIZ-2635:
------------------------------

    Attachment: OrderNotesAreNotDisplayed_OFBIZ-2635.patch

Minor changed in previous uploaded patch, used filterByCondition method in groovy as per suggested by Ashish Vijaywargiya. Thanks Ashish for valuable suggestion.

> Order notes are not displayed on sales order pdf, instead of that it gives error.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2635
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2635
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch
>
>
> To regenerate the error :
> 1). Create a sales order.
> 2). Add notes for this order.
> 3). Depress on PDF link.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2635.
--------------------------------------

    Resolution: Fixed

Thanks Akash.
Done at r787185(trunk) & r787186(RB9.04).

--
Ashish Vijaywargiya

> Order notes are not displayed on sales order pdf, instead of that it gives error.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2635
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2635
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch
>
>
> To regenerate the error :
> 1). Create a sales order.
> 2). Add notes for this order.
> 3). Depress on PDF link.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722570#action_12722570 ]

Akash Jain commented on OFBIZ-2635:
-----------------------------------

Thanks Ashish :)

> Order notes are not displayed on sales order pdf, instead of that it gives error.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2635
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2635
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch, OrderNotesAreNotDisplayed_OFBIZ-2635.patch
>
>
> To regenerate the error :
> 1). Create a sales order.
> 2). Add notes for this order.
> 3). Depress on PDF link.
> Regards,
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.