[jira] Created: (OFBIZ-2650) Capitalizing Ui Lables of OrderUilabels.xml file for maintaining consistency

[Nicolas Malin (Jira)]

Capitalizing Ui Lables of OrderUilabels.xml file for maintaining consistency
-----------------------------------------------------------------------------

                 Key: OFBIZ-2650
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Divesh Dutta
            Priority: Minor
             Fix For: SVN trunk


Ui labels are not consistent. So we need to Capitalize Ui Lables of OrderUilabels.xml file for maintaining consistency.

Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2650:
--------------------------------

    Attachment: OrderUiLabels_OFBiz_2650.patch

Here is the patch for this.

> Capitalizing Ui Lables of OrderUilabels.xml file for maintaining consistency
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch
>
>
> Ui labels are not consistent. So we need to Capitalize Ui Lables of OrderUilabels.xml file for maintaining consistency.
> Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2650:
--------------------------------

    Description:
Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
Also need to remove duplicate ui label for "Create Return"

  was:
Ui labels are not consistent. So we need to Capitalize Ui Lables of OrderUilabels.xml file for maintaining consistency.

Also need to remove duplicate ui label for "Create Return"

        Summary: Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency   (was: Capitalizing Ui Lables of OrderUilabels.xml file for maintaining consistency )

> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch
>
>
> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2650:
--------------------------------

    Attachment: OrderUiLabels_OFBiz_2650.patch

Here is the patch for changing "Create return" to "Create Return" for maintaining the consistency. Also removed the duplicate label and its references.

> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch
>
>
> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723038#action_12723038 ]

Vikas Mayur commented on OFBIZ-2650:
------------------------------------

Divesh, The changes looks okay. I have no problem with this sort of change except as mentioned below.

The Ui Label OrderCreateReturn and OrderReturnCreate though look same but have minor differences

1) The language transformation for "nl" is different in both the labels. I am not sure which one is correct. Are you?
2) The language transformation for "ro" is not available in OrderCreateReturn so that means by deleting the label OrderReturnCreate this translation will be lost.

Vikas

> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch
>
>
> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723038#action_12723038 ]

Vikas Mayur edited comment on OFBIZ-2650 at 6/23/09 3:41 AM:
-------------------------------------------------------------

Divesh, The changes looks okay. I have no problem with this sort of change except as mentioned below.

The Ui Label OrderCreateReturn and OrderReturnCreate though look same but have minor differences

1) The language translation for "nl" is different in both the labels. I am not sure which one is correct. Are you?
2) The language translation for "ro" is not available in OrderCreateReturn so that means by deleting the label OrderReturnCreate this translation will be lost.

Vikas

      was (Author: vikasmayur):
    Divesh, The changes looks okay. I have no problem with this sort of change except as mentioned below.

The Ui Label OrderCreateReturn and OrderReturnCreate though look same but have minor differences

1) The language transformation for "nl" is different in both the labels. I am not sure which one is correct. Are you?
2) The language transformation for "ro" is not available in OrderCreateReturn so that means by deleting the label OrderReturnCreate this translation will be lost.

Vikas
 

> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch
>
>
> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2650:
--------------------------------

    Attachment: OrderUiLabels_OFBiz_2650.patch

Hello Vikas,

I am uploading the patch in which I have added, language translation for "ro" and in the case of "nl" I think Hans can help us to figure out whether "Maak een retour" is correct translation of "Create Return"

> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch
>
>
> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2650:
----------------------------------

    Assignee: Vikas Mayur

> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch
>
>
> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2650.
------------------------------

    Resolution: Fixed

Thanks Divesh,

Your patch is in rev. 788594

I have added comments about the locales for which both labels have different translation. Hopefully, other contributors would change the translation if there is any thing wrong.

> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch
>
>
> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724399#action_12724399 ]

Divesh Dutta commented on OFBIZ-2650:
-------------------------------------

Thanks Vikas

> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2650
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2650
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch, OrderUiLabels_OFBiz_2650.patch
>
>
> Capitalizing Create return --> Create Return of OrderUilabels.xml file for maintaining consistency
> Also need to remove duplicate ui label for "Create Return"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.