[jira] Created: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
--------------------------------------------------------------------------

                 Key: OFBIZ-2688
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Rishi Solanki
             Fix For: Release Branch 9.04, SVN trunk




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726448#action_12726448 ]

Rishi Solanki commented on OFBIZ-2688:
--------------------------------------

For details please see the discussion :
https://issues.apache.org/jira/browse/OFBIZ-2684

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>             Fix For: Release Branch 9.04, SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727169#action_12727169 ]

Scott Gray commented on OFBIZ-2688:
-----------------------------------

The problem description is as follows:
{code}
            <link target="javascript:confirmActionLink('You want to cancel this invoice number ${invoice.invoiceId}?','setInvoiceStatus')" url-mode="plain" link-type="hidden-form">
                <parameter param-name="invoiceId" from-field="invoice.invoiceId"/>
                <parameter param-name="statusId" value="INVOICE_CANCELLED"/>
            </link>
{code}
prior to the hidden form security stuff you could request confirmation from the \677777777777777777777

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>             Fix For: Release Branch 9.04, SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-2688:
------------------------------

    Comment: was deleted

(was: The problem description is as follows:
{code}
            <link target="javascript:confirmActionLink('You want to cancel this invoice number ${invoice.invoiceId}?','setInvoiceStatus')" url-mode="plain" link-type="hidden-form">
                <parameter param-name="invoiceId" from-field="invoice.invoiceId"/>
                <parameter param-name="statusId" value="INVOICE_CANCELLED"/>
            </link>
{code}
prior to the hidden form security stuff you could request confirmation from the \677777777777777777777)

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>             Fix For: Release Branch 9.04, SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727174#action_12727174 ]

Scott Gray commented on OFBIZ-2688:
-----------------------------------

The problem description is as follows:
{code}
            <link target="javascript:confirmActionLink('You want to cancel this invoice number ${invoice.invoiceId}?','setInvoiceStatus')" url-mode="plain" link-type="hidden-form">
                <parameter param-name="invoiceId" from-field="invoice.invoiceId"/>
                <parameter param-name="statusId" value="INVOICE_CANCELLED"/>
            </link>
{code}
prior to the hidden form security stuff you could request confirmation from the user by using javascript in the target attribute.  That no longer works because the target is placed into a form action rather than a link href.

I can think of two solutions:
1.  Add support for confirmation requests to the link element with two new attributes: request-confirmation and confirmation-message
2.  There is a javascript function for submitting forms but it requires that you know the name of the form which we don't for the hidden forms.  I see 2 possible solutions for this problem:
a. Allow the developer to specify a name for the hidden form using a new link attribute
b. Put the auto-generated formName in the context prior to the target attribute being expanded, something like ${_hiddenFormName}

Any thoughts? other ideas?

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>             Fix For: Release Branch 9.04, SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727206#action_12727206 ]

Hans Bakker commented on OFBIZ-2688:
------------------------------------

Hi Scott, thanks for helping here,
option 1 would be the best and most simple for the menu creation and it would be really nice if you could implement that because it is used in a number of places not only the invoice.
Regards,
Hans

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>             Fix For: Release Branch 9.04, SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727216#action_12727216 ]

Scott Gray commented on OFBIZ-2688:
-----------------------------------

Thanks Hans, I like that option as well.

If anyone sees a problem with this please speak up as I'll probably go ahead and do it tomorrow if I get time.

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>             Fix For: Release Branch 9.04, SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-2688:
---------------------------------

    Assignee: Scott Gray

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-2688.
-----------------------------

       Resolution: Fixed
    Fix Version/s:     (was: Release Branch 9.04)

Added support for the new attributes in r791126
Switched back to using the menu widget in r791127

I'm not going to back port this to 9.04 because I think it's a new feature and the previous fix of switching to freemarker was a perfectly acceptable one.

I know I said I'd wait until tomorrow but it was easy to put in and besides it is tomorrow in NZ :-)

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727295#action_12727295 ]

Hans Bakker commented on OFBIZ-2688:
------------------------------------

works fine Scott, thanks for the quick action.

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727394#action_12727394 ]

Rishi Solanki commented on OFBIZ-2688:
--------------------------------------

Hello Scott,
Thank you for fixing the problem.
I have tested the work and working fine for the most scenarios, except one.
When we try to cancel the payment in that case, the form created is works fine but it takes the target "setInvoiceStatus" .
Steps to regenerate :
First I test for the invoices and cancel the the invoice it works fine in that case.
But when I go for the payments then it captures the last target as the action of the form created even we pass the target as "setPaymentStatus" link target.

Thank you Again !!!

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727397#action_12727397 ]

Scott Gray commented on OFBIZ-2688:
-----------------------------------

Thanks Rishi fixed in r791388

The problem was that I hadn't switched back to widgets for the payments menu so it was still using the freemarker template which contained the bug that you reported.

> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2688) As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727399#action_12727399 ]

Rishi Solanki commented on OFBIZ-2688:
--------------------------------------

Thank you Scott :).


> As per discussion on OFBIZ-2684 need to fix the problem in menu rendering.
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2688
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2688
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.