[jira] Created: (OFBIZ-2720) Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.

[Nicolas Malin (Jira)]

Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2720
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Sumit Pandit
             Fix For: SVN trunk


A) Add statusId field to the FinAccountTrans entity.

B) Seed data: "Created", "Approved".

C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.

D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
1) creates new FinAccountTrans records, then it should create them in the "Approved" status
2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"

Thanks Jacopo for the Guidance.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surya Kusumakar updated OFBIZ-2720:
-----------------------------------

    Attachment: AddedStatusIdToFinAccountTrans.patch

Hello Sumit,

Here is the patch for the above desired functionality.

Thanks to Sumit and Rishi.

--
Regards
Surya Kusumakar

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729990#action_12729990 ]

David E. Jones commented on OFBIZ-2720:
---------------------------------------

Could you please comment on the reason for this change, or in other words the business process or use case that lead to it?

The main reason I ask is that this change as described would impact existing installations, which is something we should always avoid if we can (and there are often ways to avoid it).

If it is the only solution as described here, we need to make sure to update the data migration page:

http://docs.ofbiz.org/display/OFBTECH/Revisions+Requiring+Data+Migration

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[BJ Freeman]

Just as a note:
for some customization I trigger on created to do some business logic.
that business logic then may set the status to hold.

Sumit Pandit (JIRA) sent the following on 7/11/2009 5:33 AM:

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                  Key: OFBIZ-2720
>                  URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>              Project: OFBiz
>           Issue Type: Improvement
>           Components: accounting
>     Affects Versions: SVN trunk
>             Reporter: Sumit Pandit
>              Fix For: SVN trunk
>
>
> A) Add statusId field to the FinAccountTrans entity.
>
> B) Seed data: "Created", "Approved".
>
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
>
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
>
> Thanks Jacopo for the Guidance.
>
>

--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
Systems Integrator.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730324#action_12730324 ]

Jacopo Cappellato commented on OFBIZ-2720:
------------------------------------------

Hi David,

I agree we should address backward compatibility as much as possible (and step C was about creating an upgrade script intended to be referenced from the confluence page you mentioned).

By the way, here are some notes about the use case and design notes: the idea is to allow the maintenance of data related to the Bank account(s) of the company. We are thinking to use FinAccount to represent bank accounts. Users should be able to associate payments (incoming and outgoing) to the bank account (using FinAccountTrans entries). Payments can be associated to the bank account in any status (also when they are paid) and initially the FinAccountTrans entries are created in the "Created" status.
At a later time, when the bank send the official bank statement of the account, the entries are 'reconciled' and marked as "Approved".
This will also trigger, if setup is done properly, a special GL process to 'move' (i.e. thru the creation of an opposite D/C GL trans entry) the payment transactions from the GL accounts in which they are to the GL account that represents the "bank asset account" (FinAccount.postToGlAccount)... but we can probably discuss this at a later point.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730783#action_12730783 ]

Rishi Solanki commented on OFBIZ-2720:
--------------------------------------

Thank you Jacopo and David for the valuable comments on this.

Surya,
I see patch looks fine to me, I minor modification required that in the FinAccountServices.xml change the following line ;
 <set field="newEntity.statusId" value="FINACT_TRNS_APPROVED"/>
to a empty check as user may pass the statusId from the parameter.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surya Kusumakar updated OFBIZ-2720:
-----------------------------------

    Attachment: AddedStatusIdToFinAccountTrans.patch

Hello Rishi ,

Thanks for your comments , i have uploaded patch again with changes.

--
Regards
Surya Kusumakar

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730859#action_12730859 ]

Sumit Pandit commented on OFBIZ-2720:
-------------------------------------

Above patch contains the service to Create a database upgrade that sets the statusId to "Approved" to all the records with statusId set to null.
When run this service it should keep in mind that no ECA should triggered.
To make sure this, following should perform -
1) in file - /Users/sumitpandit/work/project/ofbiz_dev/testing/applications/accounting/entitydef/eecas.xml comment -
        <eca entity="FinAccountTrans" operation="create-store" event="return">
            <action service="updateFinAccountBalancesFromTrans" mode="sync"/>
       </eca>
Above will resist triggering of a service updateFinAccountBalancesFromTrans, when changes are perform in Entity - FinAccountTrans.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730862#action_12730862 ]

Jacopo Cappellato commented on OFBIZ-2720:
------------------------------------------

Sumit,

instead of asking the user to comment out the seca, we may implement the service using the delegator's store method instead of calling the CRUD service.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730896#action_12730896 ]

Sumit Pandit commented on OFBIZ-2720:
-------------------------------------

Hello Jacopo,

Here we are updating entity using store value tag in minilang(<store-value value-field="finAccountTrans"/>).
Though an eeca is being called on entity "FinAccountTrans" therefore I would ask to user to comment the eca.

Let me know if we need to use any alternate approach.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730902#action_12730902 ]

Jacopo Cappellato commented on OFBIZ-2720:
------------------------------------------

Hello Sumit,

you are totally right and sorry for the confusion: I just noticed it is an eca and not a seca.
By the way, I had a look at the updateFinAccountBalancesFromTrans  service and it should not be dangerous to let it run at every update.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730910#action_12730910 ]

Sumit Pandit commented on OFBIZ-2720:
-------------------------------------

So do you mean that here user does not need to comment that ECA when run the database script ?

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730920#action_12730920 ]

Jacopo Cappellato commented on OFBIZ-2720:
------------------------------------------

Yes,

I think that there is no need to comment it.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-2720:
-----------------------------------

    Assignee: Anil K Patel

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel closed OFBIZ-2720.
-------------------------------

    Resolution: Fixed

Applied to svn rev793969. Thanks Sumit, Surya, Jacopo for help.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit reopened OFBIZ-2720:
---------------------------------


Reopened issue for a improvement in efficiency.
Use tag <use-iterator> for iteration. Thanks Vikas for report.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surya Kusumakar updated OFBIZ-2720:
-----------------------------------

    Attachment: AddedStatusIdToFinAccountTrans.patch

Did minor modification in migration service.

Thanks you Vikas for your suggestion.

--
Regards
Surya Kusumakar

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel resolved OFBIZ-2720.
---------------------------------

    Resolution: Fixed

Applied update in r794235.

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2720.
----------------------------------

> Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2720
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch, AddedStatusIdToFinAccountTrans.patch
>
>
> A) Add statusId field to the FinAccountTrans entity.
> B) Seed data: "Created", "Approved".
> C) Create a database upgrade script that sets the statusId to "Approved" to all the records with statusId set to null, no ECA should be triggered when this update is done.
> D) Verify that all the existing code that is using the FinAccountTrans entity works fine; the idea is that if there is code that:
> 1) creates new FinAccountTrans records, then it should create them in the "Approved" status
> 2) if there are accounting transactions posted when FinAccountTrans records are created/updated, this should now happen only when the status is "Approved"
> Thanks Jacopo for the Guidance.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.