[jira] Created: (OFBIZ-2735) Implement a service to set the status of FinAccountTrans entity.

[Nicolas Malin (Jira)]

Implement a service to set the status of FinAccountTrans entity.
----------------------------------------------------------------

                 Key: OFBIZ-2735
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2735
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Sumit Pandit
            Priority: Minor
             Fix For: SVN trunk




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731944#action_12731944 ]

Sumit Pandit commented on OFBIZ-2735:
-------------------------------------

Service will perform following -
1) set the passed status to FinAccountTrans entity.
    verify with StatusValidChange entity.
2) in case of status set to Cancel (FINACT_TRNS_CANCELED) -
   Call an eca which will remove the associated finAccountTransId from Payment entity if any.

Thanks And Regards
Sumit Pandit.

> Implement a service to set the status of FinAccountTrans entity.
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-2735
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2735
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Priority: Minor
>             Fix For: SVN trunk
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732401#action_12732401 ]

Sumit Pandit commented on OFBIZ-2735:
-------------------------------------

To implement this following changes will require in existing service -

Service - updateFinAccountBalancesFromTrans is called via ECA when create-store operation is performed at entity FinAccountTrans. This will recalculate the amount field of FinAccount Entity.
For this add a condition so that updateFinAccountBalancesFromTrans will be called only when FinAccountTrans.statusId = FINACT_TRNS_APPROVED.
And also update the same service where it calculate the balance of FinAccount (FinAccountTransService.xml line # 289 - 307), add a constraint that - DEPOSIT amount will add and WITHDRAW amount will subtract when FinAccountTransaction.statusId = FINACT_TRNS_APPROVED.

> Implement a service to set the status of FinAccountTrans entity.
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-2735
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2735
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Priority: Minor
>             Fix For: SVN trunk
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Singh Pandya updated OFBIZ-2735:
--------------------------------------

    Attachment: Set_Status_of_FinAccountTrans_OFBIZ-2735.patch

Here is the patch of implementation.

This patch contains the following -
- Call service via ECA when create-store operation is performed at entity FinAccountTrans to set the
  status.
- Add a condition so that updateFinAccountBalancesFromTrans will be called only when
  FinAccountTrans.statusId = FINACT_TRNS_APPROVED.
- Add a constraint to add and subtract amount (statusId = FINACT_TRNS_APPROVED).
- Recalculate the amount field of FinAccount Entity.
- Get all the Payments associated with finAccountTrans and set their finAccountTransId to null.

> Implement a service to set the status of FinAccountTrans entity.
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-2735
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2735
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Set_Status_of_FinAccountTrans_OFBIZ-2735.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732439#action_12732439 ]

Sumit Pandit commented on OFBIZ-2735:
-------------------------------------

Thanks Arpit for the patch.

> Implement a service to set the status of FinAccountTrans entity.
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-2735
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2735
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Set_Status_of_FinAccountTrans_OFBIZ-2735.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732441#action_12732441 ]

Jacopo Cappellato commented on OFBIZ-2735:
------------------------------------------

Sumit,

your comments are good to me; my only doubt is when you say: "DEPOSIT amount will add and WITHDRAW amount will subtract ". Maybe we could always add and just store negative values for WITHDRAWS. I think that currently the services are doing this and we should maintain it. Also, this will simplify the way we sum up ADJUSTMENT transactions (negative or positive number).

> Implement a service to set the status of FinAccountTrans entity.
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-2735
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2735
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Set_Status_of_FinAccountTrans_OFBIZ-2735.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732473#action_12732473 ]

Sumit Pandit commented on OFBIZ-2735:
-------------------------------------

Yes you are correct it evaluate withdraw as negative in existing process. But I was talking about final result.
BTW - in this implementation I didn't intended to change any functional logic, I talked about to run the calculation in specified condition.

Attached patch is ready to commit.

> Implement a service to set the status of FinAccountTrans entity.
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-2735
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2735
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Set_Status_of_FinAccountTrans_OFBIZ-2735.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-2735:
-----------------------------------

    Assignee: Anil K Patel

> Implement a service to set the status of FinAccountTrans entity.
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-2735
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2735
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Set_Status_of_FinAccountTrans_OFBIZ-2735.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel closed OFBIZ-2735.
-------------------------------

    Resolution: Fixed

Applied to r795074. Thanks for contribution.

> Implement a service to set the status of FinAccountTrans entity.
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-2735
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2735
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Anil K Patel
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Set_Status_of_FinAccountTrans_OFBIZ-2735.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.