[jira] Created: (OFBIZ-2736) facilityId not processed correctly in case of quickShipPurchaseOrder

[Nicolas Malin (Jira)]

facilityId not processed correctly in case of quickShipPurchaseOrder
--------------------------------------------------------------------

                 Key: OFBIZ-2736
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2736
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Mridul Pathak
             Fix For: Release Branch 9.04, SVN trunk


Shipment.destinationFacilityId isn't being set properly from the facilityId passed to the quickShipPurchaseOrder service.  Also, setShipmentSettingsFromPrimaryOrder (seca on CreateShipment service) overrides Shipment.destinationFacilityId due to <if-not-empty> check on wrong field Shipment.origingFacilityId.  The <if-not-empty> check should be on Shipment.destinationFacilityId instead.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-2736:
---------------------------------

    Attachment: OFBIZ-2736.patch

Here is the patch for the fix.

> facilityId not processed correctly in case of quickShipPurchaseOrder
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-2736
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2736
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2736.patch
>
>
> Shipment.destinationFacilityId isn't being set properly from the facilityId passed to the quickShipPurchaseOrder service.  Also, setShipmentSettingsFromPrimaryOrder (seca on CreateShipment service) overrides Shipment.destinationFacilityId due to <if-not-empty> check on wrong field Shipment.origingFacilityId.  The <if-not-empty> check should be on Shipment.destinationFacilityId instead.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2736:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> facilityId not processed correctly in case of quickShipPurchaseOrder
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-2736
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2736
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2736.patch
>
>
> Shipment.destinationFacilityId isn't being set properly from the facilityId passed to the quickShipPurchaseOrder service.  Also, setShipmentSettingsFromPrimaryOrder (seca on CreateShipment service) overrides Shipment.destinationFacilityId due to <if-not-empty> check on wrong field Shipment.origingFacilityId.  The <if-not-empty> check should be on Shipment.destinationFacilityId instead.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2736.
--------------------------------------

    Resolution: Fixed

Thanks Mridul.
Done at r795050 & 795054(RB9.04)

--
Ashish

> facilityId not processed correctly in case of quickShipPurchaseOrder
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-2736
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2736
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2736.patch
>
>
> Shipment.destinationFacilityId isn't being set properly from the facilityId passed to the quickShipPurchaseOrder service.  Also, setShipmentSettingsFromPrimaryOrder (seca on CreateShipment service) overrides Shipment.destinationFacilityId due to <if-not-empty> check on wrong field Shipment.origingFacilityId.  The <if-not-empty> check should be on Shipment.destinationFacilityId instead.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.