[jira] Created: (OFBIZ-2748) Wrong calculation in UtilDateTime getIntervalInDays

[Nicolas Malin (Jira)]

Wrong calculation in UtilDateTime getIntervalInDays
---------------------------------------------------

                 Key: OFBIZ-2748
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2748
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 9.04
         Environment: Sun Java 6, Linux, Postgres
            Reporter: Anne Jessel


If the two timestamps passed to getIntervalInDays are more than Integer.MAX_VALUE nanoseconds apart, the returned value is incorrect.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anne Jessel updated OFBIZ-2748:
-------------------------------

    Attachment: castbug.patch

This patch (castbug.patch) fixes the problem

> Wrong calculation in UtilDateTime getIntervalInDays
> ---------------------------------------------------
>
>                 Key: OFBIZ-2748
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2748
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04
>         Environment: Sun Java 6, Linux, Postgres
>            Reporter: Anne Jessel
>         Attachments: castbug.patch
>
>
> If the two timestamps passed to getIntervalInDays are more than Integer.MAX_VALUE nanoseconds apart, the returned value is incorrect.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-2748.
------------------------------

    Resolution: Won't Fix

Anne,

It would be preferable to use the TimeDuration class instead of these UtilDateTime methods.

The UtilDateTime methods are flawed because they don't take locale and time zone into consideration, and they use millisecond arithmetic (a definite no-no). Those methods are about to be deprecated and eventually they will be removed.

> Wrong calculation in UtilDateTime getIntervalInDays
> ---------------------------------------------------
>
>                 Key: OFBIZ-2748
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2748
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04
>         Environment: Sun Java 6, Linux, Postgres
>            Reporter: Anne Jessel
>         Attachments: castbug.patch
>
>
> If the two timestamps passed to getIntervalInDays are more than Integer.MAX_VALUE nanoseconds apart, the returned value is incorrect.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Anne Jessel]

Thank you. Wish I'd known a week ago. :-)

Could someone please clarify - the methods in UtilDateTime destined for deprecation are those not using TimeZone or Locale? So those using TimeZone and Locale are okay to use?

Cheers,
Anne.

2009/7/23 Adrian Crum (JIRA) <[hidden email]>

    [ https://issues.apache.org/jira/browse/OFBIZ-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-2748.
------------------------------

   Resolution: Won't Fix

Anne,

It would be preferable to use the TimeDuration class instead of these UtilDateTime methods.

The UtilDateTime methods are flawed because they don't take locale and time zone into consideration, and they use millisecond arithmetic (a definite no-no). Those methods are about to be deprecated and eventually they will be removed.


> Wrong calculation in UtilDateTime getIntervalInDays
> ---------------------------------------------------
>
>                 Key: OFBIZ-2748
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2748
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04
>         Environment: Sun Java 6, Linux, Postgres
>            Reporter: Anne Jessel
>         Attachments: castbug.patch
>
>
> If the two timestamps passed to getIntervalInDays are more than Integer.MAX_VALUE nanoseconds apart, the returned value is incorrect.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

--
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Phone: [phone]
Fax: [phone]
Web: http://www.cohsoft.com.au/
Email: [hidden email]

Bonsai ERP, the all-inclusive ERP system
http://www.bonsaierp.com.au/

[Adrian Crum]

That is correct.

-Adrian

[hidden email] wrote:

> Thank you. Wish I'd known a week ago. :-)
>
> Could someone please clarify - the methods in UtilDateTime destined for
> deprecation are those not using TimeZone or Locale? So those using
> TimeZone and Locale are okay to use?
>
> Cheers,
> Anne.
>
> 2009/7/23 Adrian Crum (JIRA) <[hidden email]>
>
>
>         [
>     https://issues.apache.org/jira/browse/OFBIZ-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>     <https://issues.apache.org/jira/browse/OFBIZ-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel>
>     ]
>
>     Adrian Crum closed OFBIZ-2748.
>     ------------------------------
>
>        Resolution: Won't Fix
>
>     Anne,
>
>     It would be preferable to use the TimeDuration class instead of
>     these UtilDateTime methods.
>
>     The UtilDateTime methods are flawed because they don't take locale
>     and time zone into consideration, and they use millisecond
>     arithmetic (a definite no-no). Those methods are about to be
>     deprecated and eventually they will be removed.
>
>
>      > Wrong calculation in UtilDateTime getIntervalInDays
>      > ---------------------------------------------------
>      >
>      >                 Key: OFBIZ-2748
>      >                 URL:
>     https://issues.apache.org/jira/browse/OFBIZ-2748
>     <https://issues.apache.org/jira/browse/OFBIZ-2748>
>      >             Project: OFBiz
>      >          Issue Type: Bug
>      >          Components: framework
>      >    Affects Versions: Release Branch 9.04
>      >         Environment: Sun Java 6, Linux, Postgres
>      >            Reporter: Anne Jessel
>      >         Attachments: castbug.patch
>      >
>      >
>      > If the two timestamps passed to getIntervalInDays are more than
>     Integer.MAX_VALUE nanoseconds apart, the returned value is incorrect.
>
>     --
>     This message is automatically generated by JIRA.
>     -
>     You can reply to this email to add a comment to the issue online.
>
>
>
>
> --
> Coherent Software Australia Pty Ltd
> PO Box 2773
> Cheltenham Vic 3192
> Phone: [phone]
> Fax: [phone]
> Web: http://www.cohsoft.com.au/
> Email: [hidden email]
>
> Bonsai ERP, the all-inclusive ERP system
> http://www.bonsaierp.com.au/
>