[jira] Created: (OFBIZ-2757) Ofbiz currency rounding with 0 decimal

[Nicolas Malin (Jira)]

Ofbiz currency rounding with 0 decimal
--------------------------------------

                 Key: OFBIZ-2757
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
             Project: OFBiz
          Issue Type: Improvement
          Components: framework, specialpurpose/ecommerce
    Affects Versions: SVN trunk
         Environment: Linux Debian, trunk 796250
            Reporter: Eric DE MAULDE
            Priority: Trivial
             Fix For: SVN trunk


the macro ofbizCurrency doesn't implement rounding with 0 decimal.
We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2757:
----------------------------------

    Attachment: ofbizCurrencyRounding.patch

This patch allow to display a price with any decimal

> Ofbiz currency rounding with 0 decimal
> --------------------------------------
>
>                 Key: OFBIZ-2757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk 796250
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ofbizCurrencyRounding.patch
>
>
> the macro ofbizCurrency doesn't implement rounding with 0 decimal.
> We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric DE MAULDE updated OFBIZ-2757:
----------------------------------

    Description:
the macro ofbizCurrency doesn't implement rounding with no decimal.
We can't display a price $29 with any decimal, just $29.0

  was:
the macro ofbizCurrency doesn't implement rounding with 0 decimal.
We can't display a price $29 with any decimal, just $29.0

> Ofbiz currency rounding with 0 decimal
> --------------------------------------
>
>                 Key: OFBIZ-2757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk 796250
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ofbizCurrencyRounding.patch
>
>
> the macro ofbizCurrency doesn't implement rounding with no decimal.
> We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735081#action_12735081 ]

Eric DE MAULDE edited comment on OFBIZ-2757 at 7/24/09 8:23 AM:
----------------------------------------------------------------

This patch allow to display a price with no decimal

      was (Author: eric13007):
    This patch allow to display a price with any decimal
 

> Ofbiz currency rounding with 0 decimal
> --------------------------------------
>
>                 Key: OFBIZ-2757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk 796250
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ofbizCurrencyRounding.patch
>
>
> the macro ofbizCurrency doesn't implement rounding with no decimal.
> We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751798#action_12751798 ]

Jacques Le Roux commented on OFBIZ-2757:
----------------------------------------

Hi Eric,

I can' see how this patch can do that, could you explain please ?

> Ofbiz currency rounding with 0 decimal
> --------------------------------------
>
>                 Key: OFBIZ-2757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk 796250
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ofbizCurrencyRounding.patch
>
>
> the macro ofbizCurrency doesn't implement rounding with no decimal.
> We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-2757:
---------------------------------

    Assignee: Scott Gray

> Ofbiz currency rounding with 0 decimal
> --------------------------------------
>
>                 Key: OFBIZ-2757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk 796250
>            Reporter: Eric DE MAULDE
>            Assignee: Scott Gray
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ofbizCurrencyRounding.patch
>
>
> the macro ofbizCurrency doesn't implement rounding with no decimal.
> We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-2757:
------------------------------

    Attachment: OFBIZ-2757.patch

Hi Eric

Could you please try the attached patch and see if it also works?  I've replaced the -1 with null since -1 also has a purpose when being passed into formatCurrency (to use locale's default rounding)

Thanks
Scott

@Jacques, Eric's patch solved the problem by allowing 0 to pass through to formatCurrency where currently 0 is switched to 10 decimal places (i.e. no rounding) first

> Ofbiz currency rounding with 0 decimal
> --------------------------------------
>
>                 Key: OFBIZ-2757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk 796250
>            Reporter: Eric DE MAULDE
>            Assignee: Scott Gray
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2757.patch, ofbizCurrencyRounding.patch
>
>
> the macro ofbizCurrency doesn't implement rounding with no decimal.
> We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751844#action_12751844 ]

Jacques Le Roux commented on OFBIZ-2757:
----------------------------------------

OK, thanks Scott for comment

> Ofbiz currency rounding with 0 decimal
> --------------------------------------
>
>                 Key: OFBIZ-2757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk 796250
>            Reporter: Eric DE MAULDE
>            Assignee: Scott Gray
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2757.patch, ofbizCurrencyRounding.patch
>
>
> the macro ofbizCurrency doesn't implement rounding with no decimal.
> We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751877#action_12751877 ]

Eric DE MAULDE commented on OFBIZ-2757:
---------------------------------------

Scott,

Your patch works well
Thanks for your improvement

> Ofbiz currency rounding with 0 decimal
> --------------------------------------
>
>                 Key: OFBIZ-2757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk 796250
>            Reporter: Eric DE MAULDE
>            Assignee: Scott Gray
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2757.patch, ofbizCurrencyRounding.patch
>
>
> the macro ofbizCurrency doesn't implement rounding with no decimal.
> We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-2757.
-----------------------------

    Resolution: Fixed

Thanks Eric, fixed in r811813

> Ofbiz currency rounding with 0 decimal
> --------------------------------------
>
>                 Key: OFBIZ-2757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2757
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Linux Debian, trunk 796250
>            Reporter: Eric DE MAULDE
>            Assignee: Scott Gray
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2757.patch, ofbizCurrencyRounding.patch
>
>
> the macro ofbizCurrency doesn't implement rounding with no decimal.
> We can't display a price $29 with any decimal, just $29.0

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.