[jira] Created: (OFBIZ-2759) Seed data (GEO) for Gemany contains bugs

[Nicolas Malin (Jira)]

Seed data (GEO) for Gemany contains bugs
----------------------------------------

                 Key: OFBIZ-2759
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2759
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
         Environment: not env specfic; seed data issue
            Reporter: Carsten Schinzer
            Priority: Minor


The following mistakes were found in the seed data for Germany:

Germany has 16 states. And they are states rather than Counties. Only 13 states show in the seed data file as located in the trunk at:
{OFBIZ_HOME}/framework/common/data/GeoData_DE.xml.

The following are missing:
* Hessen
* Sachsen-Anhalt
* Schleswig-Holstein

Further, all of these were categorized as "COUNTY" in geoTypeId while I believe they should al be considered as a "STATE" type.

I have the fixed file available and I am ready to attach it to this issue so you can double-check.

Remaining effort (if possible to attach the file here in JIRA) will be to download, review and check the fixed seed data file in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Schinzer updated OFBIZ-2759:
------------------------------------

    Attachment: GeoData_DE.xml

The attached file loads cleanly into my local database.
Please review and commit in order to fix the issue.

> Seed data (GEO) for Gemany contains bugs
> ----------------------------------------
>
>                 Key: OFBIZ-2759
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2759
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: not env specfic; seed data issue
>            Reporter: Carsten Schinzer
>            Priority: Minor
>         Attachments: GeoData_DE.xml
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The following mistakes were found in the seed data for Germany:
> Germany has 16 states. And they are states rather than Counties. Only 13 states show in the seed data file as located in the trunk at:
> {OFBIZ_HOME}/framework/common/data/GeoData_DE.xml.
> The following are missing:
> * Hessen
> * Sachsen-Anhalt
> * Schleswig-Holstein
> Further, all of these were categorized as "COUNTY" in geoTypeId while I believe they should al be considered as a "STATE" type.
> I have the fixed file available and I am ready to attach it to this issue so you can double-check.
> Remaining effort (if possible to attach the file here in JIRA) will be to download, review and check the fixed seed data file in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Schinzer updated OFBIZ-2759:
------------------------------------

    Attachment: OFBIZ-2759_Seed data (GEO) for Gemany contains bugs.patch

the fixed file as a patch .. so this can move forward :)

> Seed data (GEO) for Gemany contains bugs
> ----------------------------------------
>
>                 Key: OFBIZ-2759
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2759
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: not env specfic; seed data issue
>            Reporter: Carsten Schinzer
>            Priority: Minor
>         Attachments: GeoData_DE.xml, OFBIZ-2759_Seed data (GEO) for Gemany contains bugs.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The following mistakes were found in the seed data for Germany:
> Germany has 16 states. And they are states rather than Counties. Only 13 states show in the seed data file as located in the trunk at:
> {OFBIZ_HOME}/framework/common/data/GeoData_DE.xml.
> The following are missing:
> * Hessen
> * Sachsen-Anhalt
> * Schleswig-Holstein
> Further, all of these were categorized as "COUNTY" in geoTypeId while I believe they should al be considered as a "STATE" type.
> I have the fixed file available and I am ready to attach it to this issue so you can double-check.
> Remaining effort (if possible to attach the file here in JIRA) will be to download, review and check the fixed seed data file in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Schinzer updated OFBIZ-2759:
------------------------------------

    Attachment:     (was: GeoData_DE.xml)

> Seed data (GEO) for Gemany contains bugs
> ----------------------------------------
>
>                 Key: OFBIZ-2759
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2759
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: not env specfic; seed data issue
>            Reporter: Carsten Schinzer
>            Priority: Minor
>         Attachments: OFBIZ-2759_Seed data (GEO) for Gemany contains bugs.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The following mistakes were found in the seed data for Germany:
> Germany has 16 states. And they are states rather than Counties. Only 13 states show in the seed data file as located in the trunk at:
> {OFBIZ_HOME}/framework/common/data/GeoData_DE.xml.
> The following are missing:
> * Hessen
> * Sachsen-Anhalt
> * Schleswig-Holstein
> Further, all of these were categorized as "COUNTY" in geoTypeId while I believe they should al be considered as a "STATE" type.
> I have the fixed file available and I am ready to attach it to this issue so you can double-check.
> Remaining effort (if possible to attach the file here in JIRA) will be to download, review and check the fixed seed data file in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Schinzer updated OFBIZ-2759:
------------------------------------

        Fix Version/s: SVN trunk
                       Release Branch 9.04
                       Release Branch 4.0
    Affects Version/s: Release Branch 9.04
                       Release Branch 4.0

This is a simple fix. Could this be kindly proceeded?

> Seed data (GEO) for Gemany contains bugs
> ----------------------------------------
>
>                 Key: OFBIZ-2759
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2759
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk
>         Environment: not env specfic; seed data issue
>            Reporter: Carsten Schinzer
>            Priority: Minor
>             Fix For: Release Branch 4.0, Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2759_Seed data (GEO) for Gemany contains bugs.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The following mistakes were found in the seed data for Germany:
> Germany has 16 states. And they are states rather than Counties. Only 13 states show in the seed data file as located in the trunk at:
> {OFBIZ_HOME}/framework/common/data/GeoData_DE.xml.
> The following are missing:
> * Hessen
> * Sachsen-Anhalt
> * Schleswig-Holstein
> Further, all of these were categorized as "COUNTY" in geoTypeId while I believe they should al be considered as a "STATE" type.
> I have the fixed file available and I am ready to attach it to this issue so you can double-check.
> Remaining effort (if possible to attach the file here in JIRA) will be to download, review and check the fixed seed data file in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2759.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: Release Branch 4.0)
         Assignee: Jacques Le Roux

Hi Carsten,

I have commited your patch in CTR mode in trunk at R882918, R9.04 r882919, does not exist in R4.0 (at least got a tree conflict and gave up)

> Seed data (GEO) for Gemany contains bugs
> ----------------------------------------
>
>                 Key: OFBIZ-2759
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2759
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk
>         Environment: not env specfic; seed data issue
>            Reporter: Carsten Schinzer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2759_Seed data (GEO) for Gemany contains bugs.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The following mistakes were found in the seed data for Germany:
> Germany has 16 states. And they are states rather than Counties. Only 13 states show in the seed data file as located in the trunk at:
> {OFBIZ_HOME}/framework/common/data/GeoData_DE.xml.
> The following are missing:
> * Hessen
> * Sachsen-Anhalt
> * Schleswig-Holstein
> Further, all of these were categorized as "COUNTY" in geoTypeId while I believe they should al be considered as a "STATE" type.
> I have the fixed file available and I am ready to attach it to this issue so you can double-check.
> Remaining effort (if possible to attach the file here in JIRA) will be to download, review and check the fixed seed data file in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.