[jira] Created: (OFBIZ-2788) Patch non-secure URL in EditCategoryProducts.ftl

[Nicolas Malin (Jira)]

Patch non-secure URL in EditCategoryProducts.ftl
------------------------------------------------

                 Key: OFBIZ-2788
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2788
             Project: OFBiz
          Issue Type: Sub-task
          Components: product
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Ahmed Dini
             Fix For: Release Branch 9.04, SVN trunk
         Attachments: EditCategoryProducts.patch

How to regenerate the error:-

Catalog Manager -->Under Browse Categories section, select a category with products-->Products tab then try to delete one of the products by clicking on the delete button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Dini updated OFBIZ-2788:
------------------------------

    Attachment: EditCategoryProducts.patch

> Patch non-secure URL in EditCategoryProducts.ftl
> ------------------------------------------------
>
>                 Key: OFBIZ-2788
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2788
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ahmed Dini
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditCategoryProducts.patch
>
>
> How to regenerate the error:-
> Catalog Manager -->Under Browse Categories section, select a category with products-->Products tab then try to delete one of the products by clicking on the delete button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Dini updated OFBIZ-2788:
------------------------------

    Priority: Minor  (was: Major)

> Patch non-secure URL in EditCategoryProducts.ftl
> ------------------------------------------------
>
>                 Key: OFBIZ-2788
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2788
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ahmed Dini
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditCategoryProducts.patch
>
>
> How to regenerate the error:-
> Catalog Manager -->Under Browse Categories section, select a category with products-->Products tab then try to delete one of the products by clicking on the delete button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751012#action_12751012 ]

Jacques Le Roux commented on OFBIZ-2788:
----------------------------------------

Hi Ahmed,

I got a conflict with your patch, could you update please ?

Thanks

> Patch non-secure URL in EditCategoryProducts.ftl
> ------------------------------------------------
>
>                 Key: OFBIZ-2788
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2788
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ahmed Dini
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditCategoryProducts.patch
>
>
> How to regenerate the error:-
> Catalog Manager -->Under Browse Categories section, select a category with products-->Products tab then try to delete one of the products by clicking on the delete button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751846#action_12751846 ]

Jacques Le Roux commented on OFBIZ-2788:
----------------------------------------

Hi Ahmed,

Did you see this message? I'd like to commit this patch as well :)

Thanks

> Patch non-secure URL in EditCategoryProducts.ftl
> ------------------------------------------------
>
>                 Key: OFBIZ-2788
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2788
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ahmed Dini
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditCategoryProducts.patch
>
>
> How to regenerate the error:-
> Catalog Manager -->Under Browse Categories section, select a category with products-->Products tab then try to delete one of the products by clicking on the delete button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Dini updated OFBIZ-2788:
------------------------------

    Attachment: EditCategoryProducts.patch


Hello Jacques,

Sorry about the delay, please find the updated patch.
Thanks

> Patch non-secure URL in EditCategoryProducts.ftl
> ------------------------------------------------
>
>                 Key: OFBIZ-2788
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2788
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ahmed Dini
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditCategoryProducts.patch, EditCategoryProducts.patch
>
>
> How to regenerate the error:-
> Catalog Manager -->Under Browse Categories section, select a category with products-->Products tab then try to delete one of the products by clicking on the delete button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751928#action_12751928 ]

Jacques Le Roux commented on OFBIZ-2788:
----------------------------------------

No worries Ahmed,

BTW is your formatting intended ?

> Patch non-secure URL in EditCategoryProducts.ftl
> ------------------------------------------------
>
>                 Key: OFBIZ-2788
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2788
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ahmed Dini
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditCategoryProducts.patch, EditCategoryProducts.patch
>
>
> How to regenerate the error:-
> Catalog Manager -->Under Browse Categories section, select a category with products-->Products tab then try to delete one of the products by clicking on the delete button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751936#action_12751936 ]

Jacques Le Roux commented on OFBIZ-2788:
----------------------------------------

I see, it seems that you have some tabs in this patch. Please could you check formatting and replace tabs by 4 spaces ?

> Patch non-secure URL in EditCategoryProducts.ftl
> ------------------------------------------------
>
>                 Key: OFBIZ-2788
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2788
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ahmed Dini
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditCategoryProducts.patch, EditCategoryProducts.patch
>
>
> How to regenerate the error:-
> Catalog Manager -->Under Browse Categories section, select a category with products-->Products tab then try to delete one of the products by clicking on the delete button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2788.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Ahmed,

Your patch is in trunk at r815977, R9.04 at r815978
I have reformatted all the block, because I understood it was not your own formatting but an old bad one that was already there. I did not have enough courage to check the all file though...

> Patch non-secure URL in EditCategoryProducts.ftl
> ------------------------------------------------
>
>                 Key: OFBIZ-2788
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2788
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ahmed Dini
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditCategoryProducts.patch, EditCategoryProducts.patch
>
>
> How to regenerate the error:-
> Catalog Manager -->Under Browse Categories section, select a category with products-->Products tab then try to delete one of the products by clicking on the delete button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.