[jira] Created: (OFBIZ-2848) Add PartyIdentification feature

[Nicolas Malin (Jira)]

Add PartyIdentification feature
-------------------------------

                 Key: OFBIZ-2848
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
             Project: OFBiz
          Issue Type: Improvement
          Components: party
    Affects Versions: SVN trunk
            Reporter: nicolas malin
             Fix For: SVN trunk


Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.

This issue contains :
 * entities
 * portlet added to profile party screen
 * demo data
 * edit and list PartyIdentification screen
 * search service to find a Party by an Id (partyId or idValue associate)



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin updated OFBIZ-2848:
---------------------------------

    Attachment:     (was: partyIdentification.patch)

> Add PartyIdentification feature
> -------------------------------
>
>                 Key: OFBIZ-2848
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.
> This issue contains :
>  * entities
>  * portlet added to profile party screen
>  * demo data
>  * edit and list PartyIdentification screen
>  * search service to find a Party by an Id (partyId or idValue associate)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin updated OFBIZ-2848:
---------------------------------

    Attachment: partyIdentification.patch

Patch to apply to ofbiz trunk for test PartyIdentification feature

> Add PartyIdentification feature
> -------------------------------
>
>                 Key: OFBIZ-2848
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.
> This issue contains :
>  * entities
>  * portlet added to profile party screen
>  * demo data
>  * edit and list PartyIdentification screen
>  * search service to find a Party by an Id (partyId or idValue associate)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin updated OFBIZ-2848:
---------------------------------

    Attachment: partyIdentification.patch

To test this patch :
1. Apply on trunk Ofbiz version
2. on party component, look DemoSupplier profile. In the fisrt column end you have a new idintification number, remove one and add new or edit.
3. You can add identification number on other party as DemoEmployee
4. To test search, go to runService in webtools and run findPartiesById

> Add PartyIdentification feature
> -------------------------------
>
>                 Key: OFBIZ-2848
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: partyIdentification.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.
> This issue contains :
>  * entities
>  * portlet added to profile party screen
>  * demo data
>  * edit and list PartyIdentification screen
>  * search service to find a Party by an Id (partyId or idValue associate)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752139#action_12752139 ]

Jacques Le Roux commented on OFBIZ-2848:
----------------------------------------

Hi Nicolas,

1st : review, remarks :
# please don't put .project file in your patch,
# add Permission Check to your service declarations, something like
{code}
<permission-service service-name="partyBasePermissionCheck" main-action="........"/>
{code}
# I'd prefer n° than numéro in french l10n, that's subjective, I used n° everywhere else in OFBiz.

Else looks pretty good, thanks.

> Add PartyIdentification feature
> -------------------------------
>
>                 Key: OFBIZ-2848
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: partyIdentification.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.
> This issue contains :
>  * entities
>  * portlet added to profile party screen
>  * demo data
>  * edit and list PartyIdentification screen
>  * search service to find a Party by an Id (partyId or idValue associate)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752153#action_12752153 ]

nicolas malin commented on OFBIZ-2848:
--------------------------------------

Thanks jacques for your review :)

1. Oh It's an error, sorry
2. Ok I add permission on service
3. Ok I correct uiLabel

I create a new patch in few days.

Nicolas

> Add PartyIdentification feature
> -------------------------------
>
>                 Key: OFBIZ-2848
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: partyIdentification.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.
> This issue contains :
>  * entities
>  * portlet added to profile party screen
>  * demo data
>  * edit and list PartyIdentification screen
>  * search service to find a Party by an Id (partyId or idValue associate)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin updated OFBIZ-2848:
---------------------------------

    Attachment: partyIdentification.patch

* correct french label
* increase code to multi creation service
* add security to service definition

> Add PartyIdentification feature
> -------------------------------
>
>                 Key: OFBIZ-2848
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: partyIdentification.patch, partyIdentification.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.
> This issue contains :
>  * entities
>  * portlet added to profile party screen
>  * demo data
>  * edit and list PartyIdentification screen
>  * search service to find a Party by an Id (partyId or idValue associate)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752487#action_12752487 ]

nicolas malin commented on OFBIZ-2848:
--------------------------------------

Ok Jacques, I operated to modification. Thanks by advance for tour review ;)

Nicolas

> Add PartyIdentification feature
> -------------------------------
>
>                 Key: OFBIZ-2848
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: partyIdentification.patch, partyIdentification.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.
> This issue contains :
>  * entities
>  * portlet added to profile party screen
>  * demo data
>  * edit and list PartyIdentification screen
>  * search service to find a Party by an Id (partyId or idValue associate)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2848.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

You are welcome Nicolas,

I just had to move
    <Party partyId="DemoSupplier"/>
    <PartyRole partyId="DemoSupplier" roleTypeId="ACCOUNT"/>
from sfa to party, but it should not be a problem as sfa depends on party and not the other way.

I successfully tested findByPartiesId service frrom Webtools

Your patch is in trunk at r812532  

Thanks

> Add PartyIdentification feature
> -------------------------------
>
>                 Key: OFBIZ-2848
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: partyIdentification.patch, partyIdentification.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.
> This issue contains :
>  * entities
>  * portlet added to profile party screen
>  * demo data
>  * edit and list PartyIdentification screen
>  * search service to find a Party by an Id (partyId or idValue associate)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.