[jira] Created: (OFBIZ-2856) ordermgr -- productsummary.ftl (rev 797259) contains hard coded labels

[Nicolas Malin (Jira)]

ordermgr -- productsummary.ftl (rev 797259) contains hard coded labels
----------------------------------------------------------------------

                 Key: OFBIZ-2856
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2856
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
         Environment: irrelevant; bug in ftl screendef
            Reporter: Carsten Schinzer
            Priority: Minor


line 104 ff. are curremtly defined as:

            <div>
              <#if (sizeProductFeatureAndAppls?size == 1)>
                                Size:
              <#else>
                                Available Sizes:
              </#if>

However, in order to enable proper i18n, these lines should rather read

            <div>
              <#if (sizeProductFeatureAndAppls?size == 1)>
                                ${uiLabelMap.SingleSizeAvailable}:
              <#else>
                                ${uiLabelMap.MultipleSizesAvailable}:
              </#if>

... and corresponding UI Labels added to order/config/OrderUiLables.xml.

I've added the following locales to OrderUiLabels.xml:

    <property key="SingleSizeAvailable">
        <value xml:lang="de">Größe</value>
        <value xml:lang="en">Size</value>
        <value xml:lang="fr">Taille</value>
    </property>
    <property key="MultipleSizesAvailable">
        <value xml:lang="de">Verfügbare Größen</value>
        <value xml:lang="en">Sizes Available</value>
        <value xml:lang="fr">Tailles Disponibles</value>
    </property>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747154#action_12747154 ]

Adrian Crum commented on OFBIZ-2856:
------------------------------------

Carsten,

It would be helpful if you submitted a patch. Patches are faster and easier for committers to review and commit.

Also, take a look at this document - http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices.

> ordermgr -- productsummary.ftl (rev 797259) contains hard coded labels
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-2856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2856
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: irrelevant; bug in ftl screendef
>            Reporter: Carsten Schinzer
>            Priority: Minor
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> line 104 ff. are curremtly defined as:
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> Size:
>               <#else>
> Available Sizes:
>               </#if>
> However, in order to enable proper i18n, these lines should rather read
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> ${uiLabelMap.SingleSizeAvailable}:
>               <#else>
> ${uiLabelMap.MultipleSizesAvailable}:
>               </#if>
> ... and corresponding UI Labels added to order/config/OrderUiLables.xml.
> I've added the following locales to OrderUiLabels.xml:
>     <property key="SingleSizeAvailable">
>         <value xml:lang="de">Größe</value>
>         <value xml:lang="en">Size</value>
>         <value xml:lang="fr">Taille</value>
>     </property>
>     <property key="MultipleSizesAvailable">
>         <value xml:lang="de">Verfügbare Größen</value>
>         <value xml:lang="en">Sizes Available</value>
>         <value xml:lang="fr">Tailles Disponibles</value>
>     </property>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Schinzer updated OFBIZ-2856:
------------------------------------

    Summary: ordermgr webapp - catalog - productsummary.ftl contains hard coded labels  (was: ordermgr -- productsummary.ftl (rev 797259) contains hard coded labels)

> ordermgr webapp - catalog - productsummary.ftl contains hard coded labels
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2856
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: irrelevant; bug in ftl screendef
>            Reporter: Carsten Schinzer
>            Priority: Minor
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> line 104 ff. are curremtly defined as:
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> Size:
>               <#else>
> Available Sizes:
>               </#if>
> However, in order to enable proper i18n, these lines should rather read
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> ${uiLabelMap.SingleSizeAvailable}:
>               <#else>
> ${uiLabelMap.MultipleSizesAvailable}:
>               </#if>
> ... and corresponding UI Labels added to order/config/OrderUiLables.xml.
> I've added the following locales to OrderUiLabels.xml:
>     <property key="SingleSizeAvailable">
>         <value xml:lang="de">Größe</value>
>         <value xml:lang="en">Size</value>
>         <value xml:lang="fr">Taille</value>
>     </property>
>     <property key="MultipleSizesAvailable">
>         <value xml:lang="de">Verfügbare Größen</value>
>         <value xml:lang="en">Sizes Available</value>
>         <value xml:lang="fr">Tailles Disponibles</value>
>     </property>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Schinzer updated OFBIZ-2856:
------------------------------------

    Issue Type: Bug  (was: Improvement)
       Summary: ordermgr webapp - catalog - productsummary contains hard coded labels  (was: ordermgr webapp - catalog - productsummary.ftl contains hard coded labels)

> ordermgr webapp - catalog - productsummary contains hard coded labels
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2856
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: irrelevant; bug in ftl screendef
>            Reporter: Carsten Schinzer
>            Priority: Minor
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> line 104 ff. are curremtly defined as:
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> Size:
>               <#else>
> Available Sizes:
>               </#if>
> However, in order to enable proper i18n, these lines should rather read
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> ${uiLabelMap.SingleSizeAvailable}:
>               <#else>
> ${uiLabelMap.MultipleSizesAvailable}:
>               </#if>
> ... and corresponding UI Labels added to order/config/OrderUiLables.xml.
> I've added the following locales to OrderUiLabels.xml:
>     <property key="SingleSizeAvailable">
>         <value xml:lang="de">Größe</value>
>         <value xml:lang="en">Size</value>
>         <value xml:lang="fr">Taille</value>
>     </property>
>     <property key="MultipleSizesAvailable">
>         <value xml:lang="de">Verfügbare Größen</value>
>         <value xml:lang="en">Sizes Available</value>
>         <value xml:lang="fr">Tailles Disponibles</value>
>     </property>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Schinzer updated OFBIZ-2856:
------------------------------------

    Attachment: OFBIZ-2856_ordermgr webapp - catalog - productsummary contains hard coded labels.patch

the two related files are updated

> ordermgr webapp - catalog - productsummary contains hard coded labels
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2856
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: irrelevant; bug in ftl screendef
>            Reporter: Carsten Schinzer
>            Priority: Minor
>         Attachments: OFBIZ-2856_ordermgr webapp - catalog - productsummary contains hard coded labels.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> line 104 ff. are curremtly defined as:
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> Size:
>               <#else>
> Available Sizes:
>               </#if>
> However, in order to enable proper i18n, these lines should rather read
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> ${uiLabelMap.SingleSizeAvailable}:
>               <#else>
> ${uiLabelMap.MultipleSizesAvailable}:
>               </#if>
> ... and corresponding UI Labels added to order/config/OrderUiLables.xml.
> I've added the following locales to OrderUiLabels.xml:
>     <property key="SingleSizeAvailable">
>         <value xml:lang="de">Größe</value>
>         <value xml:lang="en">Size</value>
>         <value xml:lang="fr">Taille</value>
>     </property>
>     <property key="MultipleSizesAvailable">
>         <value xml:lang="de">Verfügbare Größen</value>
>         <value xml:lang="en">Sizes Available</value>
>         <value xml:lang="fr">Tailles Disponibles</value>
>     </property>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747346#action_12747346 ]

Carsten Schinzer commented on OFBIZ-2856:
-----------------------------------------

Morning Adrian,

Thanks for pointing me there. I had not read the patch-section.
I will prepare all JIRA issues accordingly, that I have reported so far.

Who will now change the status of the JIRA issue? Am I supposed to close it
myself?
Or will that be done by the comitter who finally reviews the patches?

Kind regards

Carsten

2009/8/25 Adrian Crum (JIRA) <[hidden email]>



--

Best

Carsten Schinzer

Waisenhausstr. 53a
80637 München
Germany

> ordermgr webapp - catalog - productsummary contains hard coded labels
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2856
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: irrelevant; bug in ftl screendef
>            Reporter: Carsten Schinzer
>            Priority: Minor
>         Attachments: OFBIZ-2856_ordermgr webapp - catalog - productsummary contains hard coded labels.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> line 104 ff. are curremtly defined as:
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> Size:
>               <#else>
> Available Sizes:
>               </#if>
> However, in order to enable proper i18n, these lines should rather read
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> ${uiLabelMap.SingleSizeAvailable}:
>               <#else>
> ${uiLabelMap.MultipleSizesAvailable}:
>               </#if>
> ... and corresponding UI Labels added to order/config/OrderUiLables.xml.
> I've added the following locales to OrderUiLabels.xml:
>     <property key="SingleSizeAvailable">
>         <value xml:lang="de">Größe</value>
>         <value xml:lang="en">Size</value>
>         <value xml:lang="fr">Taille</value>
>     </property>
>     <property key="MultipleSizesAvailable">
>         <value xml:lang="de">Verfügbare Größen</value>
>         <value xml:lang="en">Sizes Available</value>
>         <value xml:lang="fr">Tailles Disponibles</value>
>     </property>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747449#action_12747449 ]

Adrian Crum commented on OFBIZ-2856:
------------------------------------

The committer will close the issue.

> ordermgr webapp - catalog - productsummary contains hard coded labels
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2856
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: irrelevant; bug in ftl screendef
>            Reporter: Carsten Schinzer
>            Priority: Minor
>         Attachments: OFBIZ-2856_ordermgr webapp - catalog - productsummary contains hard coded labels.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> line 104 ff. are curremtly defined as:
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> Size:
>               <#else>
> Available Sizes:
>               </#if>
> However, in order to enable proper i18n, these lines should rather read
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> ${uiLabelMap.SingleSizeAvailable}:
>               <#else>
> ${uiLabelMap.MultipleSizesAvailable}:
>               </#if>
> ... and corresponding UI Labels added to order/config/OrderUiLables.xml.
> I've added the following locales to OrderUiLabels.xml:
>     <property key="SingleSizeAvailable">
>         <value xml:lang="de">Größe</value>
>         <value xml:lang="en">Size</value>
>         <value xml:lang="fr">Taille</value>
>     </property>
>     <property key="MultipleSizesAvailable">
>         <value xml:lang="de">Verfügbare Größen</value>
>         <value xml:lang="en">Sizes Available</value>
>         <value xml:lang="fr">Tailles Disponibles</value>
>     </property>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2856.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 9.04
         Assignee: Jacques Le Roux

Thanks Carsten,

Your patch is in trunk at r810814 and R9.04 at r810817.

> ordermgr webapp - catalog - productsummary contains hard coded labels
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2856
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: irrelevant; bug in ftl screendef
>            Reporter: Carsten Schinzer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2856_ordermgr webapp - catalog - productsummary contains hard coded labels.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> line 104 ff. are curremtly defined as:
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> Size:
>               <#else>
> Available Sizes:
>               </#if>
> However, in order to enable proper i18n, these lines should rather read
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> ${uiLabelMap.SingleSizeAvailable}:
>               <#else>
> ${uiLabelMap.MultipleSizesAvailable}:
>               </#if>
> ... and corresponding UI Labels added to order/config/OrderUiLables.xml.
> I've added the following locales to OrderUiLabels.xml:
>     <property key="SingleSizeAvailable">
>         <value xml:lang="de">Größe</value>
>         <value xml:lang="en">Size</value>
>         <value xml:lang="fr">Taille</value>
>     </property>
>     <property key="MultipleSizesAvailable">
>         <value xml:lang="de">Verfügbare Größen</value>
>         <value xml:lang="en">Sizes Available</value>
>         <value xml:lang="fr">Tailles Disponibles</value>
>     </property>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750911#action_12750911 ]

Jacques Le Roux commented on OFBIZ-2856:
----------------------------------------

BTW I changed a bit the 2d French translation ;o)

> ordermgr webapp - catalog - productsummary contains hard coded labels
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2856
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: irrelevant; bug in ftl screendef
>            Reporter: Carsten Schinzer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2856_ordermgr webapp - catalog - productsummary contains hard coded labels.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> line 104 ff. are curremtly defined as:
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> Size:
>               <#else>
> Available Sizes:
>               </#if>
> However, in order to enable proper i18n, these lines should rather read
>             <div>
>               <#if (sizeProductFeatureAndAppls?size == 1)>
> ${uiLabelMap.SingleSizeAvailable}:
>               <#else>
> ${uiLabelMap.MultipleSizesAvailable}:
>               </#if>
> ... and corresponding UI Labels added to order/config/OrderUiLables.xml.
> I've added the following locales to OrderUiLabels.xml:
>     <property key="SingleSizeAvailable">
>         <value xml:lang="de">Größe</value>
>         <value xml:lang="en">Size</value>
>         <value xml:lang="fr">Taille</value>
>     </property>
>     <property key="MultipleSizesAvailable">
>         <value xml:lang="de">Verfügbare Größen</value>
>         <value xml:lang="en">Sizes Available</value>
>         <value xml:lang="fr">Tailles Disponibles</value>
>     </property>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.