[jira] Created: (OFBIZ-2873) error to parse menu with " on screelet header

[Nicolas Malin (Jira)]

error to parse menu with " on screelet header
---------------------------------------------

                 Key: OFBIZ-2873
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2873
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: nicolas malin
             Fix For: SVN trunk


When you have a menu with link that contains ", the macro render do a replace with " by '. This action break the link.

I change the replace with " by ' to " by µµ. This change permit to pass macro render by ftl template.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin updated OFBIZ-2873:
---------------------------------

    Attachment: screenlet.diff

> error to parse menu with " on screelet header
> ---------------------------------------------
>
>                 Key: OFBIZ-2873
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2873
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: screenlet.diff
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> When you have a menu with link that contains ", the macro render do a replace with " by '. This action break the link.
> I change the replace with " by ' to " by µµ. This change permit to pass macro render by ftl template.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2873.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 9.04
         Assignee: Jacques Le Roux

Thanks Nicolas,

Your patch is in trunk at r810807 and R9.04 at r810808.

> error to parse menu with " on screelet header
> ---------------------------------------------
>
>                 Key: OFBIZ-2873
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2873
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: screenlet.diff
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> When you have a menu with link that contains ", the macro render do a replace with " by '. This action break the link.
> I change the replace with " by ' to " by µµ. This change permit to pass macro render by ftl template.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reopened OFBIZ-2873:
-------------------------------


Reopening due to build issues caused by the fix

> error to parse menu with " on screelet header
> ---------------------------------------------
>
>                 Key: OFBIZ-2873
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2873
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: screenlet.diff
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> When you have a menu with link that contains ", the macro render do a replace with " by '. This action break the link.
> I change the replace with " by ' to " by µµ. This change permit to pass macro render by ftl template.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-2873:
------------------------------

    Attachment: OFBIZ-2873.patch

Nicolas,

Could you please try the attached patch and let me know if it works for you.

Thanks
Scott

> error to parse menu with " on screelet header
> ---------------------------------------------
>
>                 Key: OFBIZ-2873
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2873
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2873.patch, screenlet.diff
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> When you have a menu with link that contains ", the macro render do a replace with " by '. This action break the link.
> I change the replace with " by ' to " by µµ. This change permit to pass macro render by ftl template.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752522#action_12752522 ]

nicolas malin commented on OFBIZ-2873:
--------------------------------------

Ok Scott, I have no problem with your patch, It's better solution :) .

Tks a lot.

Nicolas

> error to parse menu with " on screelet header
> ---------------------------------------------
>
>                 Key: OFBIZ-2873
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2873
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2873.patch, screenlet.diff
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> When you have a menu with link that contains ", the macro render do a replace with " by '. This action break the link.
> I change the replace with " by ' to " by µµ. This change permit to pass macro render by ftl template.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2873.
----------------------------------

    Resolution: Fixed

Thanks Scott, Nicolas,

Scott your patch is in trunk at r812540, R9.04 at r812541

> error to parse menu with " on screelet header
> ---------------------------------------------
>
>                 Key: OFBIZ-2873
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2873
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2873.patch, screenlet.diff
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> When you have a menu with link that contains ", the macro render do a replace with " by '. This action break the link.
> I change the replace with " by ' to " by µµ. This change permit to pass macro render by ftl template.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.