[jira] Created: (OFBIZ-2915) ViewGeneric screen not showing BigDecimal columns as editable

[Nicolas Malin (Jira)]

ViewGeneric screen not showing BigDecimal columns as editable
--------------------------------------------------------------

                 Key: OFBIZ-2915
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2915
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
         Environment: WinXP
            Reporter: Stephen Rufle
         Attachments: GenericEntity_BigDecimal.patch

When editing a record that has BigDecimal columns defined, no edit boxes were generated in the "Edit Value" box

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Rufle updated OFBIZ-2915:
---------------------------------

    Attachment: GenericEntity_BigDecimal.patch

Added BigDecimal sections to ViewGeneric.groovy and ViewGeneric.ftl

> ViewGeneric screen not showing BigDecimal columns as editable
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Stephen Rufle
>         Attachments: GenericEntity_BigDecimal.patch
>
>
> When editing a record that has BigDecimal columns defined, no edit boxes were generated in the "Edit Value" box

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756499#action_12756499 ]

Stephen Rufle commented on OFBIZ-2915:
--------------------------------------

Bump, can someone review


--
Stephen P Rufle
[hidden email]
H1:480-626-8022
H2:480-802-7173
Yahoo IM: stephen_rufle
AOL IM: stephen1rufle

> ViewGeneric screen not showing BigDecimal columns as editable
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Stephen Rufle
>         Attachments: GenericEntity_BigDecimal.patch
>
>
> When editing a record that has BigDecimal columns defined, no edit boxes were generated in the "Edit Value" box

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756501#action_12756501 ]

Scott Gray commented on OFBIZ-2915:
-----------------------------------

Looks fine to me, my only comment is that you shouldn't use toString() with BigDecimals because you'll end up with scientific notation sooner or later.  Use toPlainString() instead.

> ViewGeneric screen not showing BigDecimal columns as editable
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Stephen Rufle
>         Attachments: GenericEntity_BigDecimal.patch
>
>
> When editing a record that has BigDecimal columns defined, no edit boxes were generated in the "Edit Value" box

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757213#action_12757213 ]

Stephen Rufle commented on OFBIZ-2915:
--------------------------------------

Does that mean I should also modify
org.ofbiz.base.util.UtilFormatOut.safeToString(Object) to deal with BigDecimal specifically?

Calling toPlainString() for BigDecimal objects. If no one object that is what I will put in my next patch.

> ViewGeneric screen not showing BigDecimal columns as editable
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Stephen Rufle
>         Attachments: GenericEntity_BigDecimal.patch
>
>
> When editing a record that has BigDecimal columns defined, no edit boxes were generated in the "Edit Value" box

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757521#action_12757521 ]

Scott Gray commented on OFBIZ-2915:
-----------------------------------

I would just do it locally so that we don't have to do an additional instanceof check for every object that passes through the method, all it does it a null check anyway.

> ViewGeneric screen not showing BigDecimal columns as editable
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Stephen Rufle
>         Attachments: GenericEntity_BigDecimal.patch
>
>
> When editing a record that has BigDecimal columns defined, no edit boxes were generated in the "Edit Value" box

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath closed OFBIZ-2915.
-----------------------------

    Resolution: Fixed

This bug was fixed by revision 916925.

> ViewGeneric screen not showing BigDecimal columns as editable
> --------------------------------------------------------------
>
>                 Key: OFBIZ-2915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Stephen Rufle
>         Attachments: GenericEntity_BigDecimal.patch
>
>
> When editing a record that has BigDecimal columns defined, no edit boxes were generated in the "Edit Value" box

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.