[jira] Created: (OFBIZ-294) orderType configurable prefixes

[Nicolas Malin (Jira)]

orderType configurable prefixes
-------------------------------

                 Key: OFBIZ-294
                 URL: http://issues.apache.org/jira/browse/OFBIZ-294
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Marco Risaliti
            Priority: Minor


I was reading Hans's README.pdf for opentravelsystems and thought one of his ideas could be added to OFBiz. Hans had added "S" for sales orders and "P" for purchase orders in orderIds, and I thought we could set it so that OrderType can have two additional fields:

- useStorePrefix - If set to "N", then do not use productStoreId's prefix.
- orderTypePrefix - Someone can set a prefix for this order type.

So purchase orders could be set to useStorePrefix="N" and orderTypePrefix="P" and sales orders could be set to useStorePrefix="Y" and orderTypePrefix=null or ="S"
 
 

 All    Comments    Work Log    Change History       Sort Order:  
Comment by Fred Forester [20/May/06 06:44 AM] [ Permlink ]
Si,

I was looking at how to do this the night before you posted it to jira. I may need a little more detail on where these changes would go and would be glad to do the coding for it.

Fred


Comment by Si Chen [22/May/06 11:08 AM] [ Permlink ]
I was thinking about adding two more fields into OrderType entity and then in OrderServices.java createOrder service, early on, to load the OrderType based on the orderTypeId passed in and check those two fields.

This should be pretty easy to do but I want to make sure David, Jacopo, Hans, etc. like the idea as well.

Comment by Jacopo Cappellato [01/Sep/06 09:31 AM] [ Permlink ]
Si,

I like this idea. However we could slightly simplify it:

1) add a new field OrderType.orderTypePrefix (or orderTypeId)
2) if orderTypePrefix is null then the prefix set in the product store is used (if present)



Comment by Marco Risaliti [13/Sep/06 04:08 PM] [ Permlink ]
is this improvement will be implemented ?
In this case I will move it to the new jira server.

Thanks
Marco

It's a copy of the old-jira issue OFBIZ-889.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-294?page=comments#action_12434796 ]
           
Daniel Kunkel commented on OFBIZ-294:
-------------------------------------

Why not just have the prefix, and let it be null, nothing, or "" if someone doesn't want to use it:

orderSalesPrefix="S" or ="" for nothing
orderPurchasePrefix="P" or =""

> orderType configurable prefixes
> -------------------------------
>
>                 Key: OFBIZ-294
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-294
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Minor
>
> I was reading Hans's README.pdf for opentravelsystems and thought one of his ideas could be added to OFBiz. Hans had added "S" for sales orders and "P" for purchase orders in orderIds, and I thought we could set it so that OrderType can have two additional fields:
> - useStorePrefix - If set to "N", then do not use productStoreId's prefix.
> - orderTypePrefix - Someone can set a prefix for this order type.
> So purchase orders could be set to useStorePrefix="N" and orderTypePrefix="P" and sales orders could be set to useStorePrefix="Y" and orderTypePrefix=null or ="S"
>  
>  
>  All    Comments    Work Log    Change History       Sort Order:  
> Comment by Fred Forester [20/May/06 06:44 AM] [ Permlink ]
> Si,
> I was looking at how to do this the night before you posted it to jira. I may need a little more detail on where these changes would go and would be glad to do the coding for it.
> Fred
> Comment by Si Chen [22/May/06 11:08 AM] [ Permlink ]
> I was thinking about adding two more fields into OrderType entity and then in OrderServices.java createOrder service, early on, to load the OrderType based on the orderTypeId passed in and check those two fields.
> This should be pretty easy to do but I want to make sure David, Jacopo, Hans, etc. like the idea as well.
> Comment by Jacopo Cappellato [01/Sep/06 09:31 AM] [ Permlink ]
> Si,
> I like this idea. However we could slightly simplify it:
> 1) add a new field OrderType.orderTypePrefix (or orderTypeId)
> 2) if orderTypePrefix is null then the prefix set in the product store is used (if present)
> Comment by Marco Risaliti [13/Sep/06 04:08 PM] [ Permlink ]
> is this improvement will be implemented ?
> In this case I will move it to the new jira server.
> Thanks
> Marco
> It's a copy of the old-jira issue OFBIZ-889.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-294?page=all ]

Jacopo Cappellato updated OFBIZ-294:
------------------------------------

    Description:
Copy of http://jira.undersunconsulting.com/browse/OFBIZ-889 from Si Chen.

=======================================

I was reading Hans's README.pdf for opentravelsystems and thought one of his ideas could be added to OFBiz. Hans had added "S" for sales orders and "P" for purchase orders in orderIds, and I thought we could set it so that OrderType can have two additional fields:

- useStorePrefix - If set to "N", then do not use productStoreId's prefix.
- orderTypePrefix - Someone can set a prefix for this order type.

So purchase orders could be set to useStorePrefix="N" and orderTypePrefix="P" and sales orders could be set to useStorePrefix="Y" and orderTypePrefix=null or ="S"
 
 

 All    Comments    Work Log    Change History       Sort Order:  
Comment by Fred Forester [20/May/06 06:44 AM] [ Permlink ]
Si,

I was looking at how to do this the night before you posted it to jira. I may need a little more detail on where these changes would go and would be glad to do the coding for it.

Fred


Comment by Si Chen [22/May/06 11:08 AM] [ Permlink ]
I was thinking about adding two more fields into OrderType entity and then in OrderServices.java createOrder service, early on, to load the OrderType based on the orderTypeId passed in and check those two fields.

This should be pretty easy to do but I want to make sure David, Jacopo, Hans, etc. like the idea as well.

Comment by Jacopo Cappellato [01/Sep/06 09:31 AM] [ Permlink ]
Si,

I like this idea. However we could slightly simplify it:

1) add a new field OrderType.orderTypePrefix (or orderTypeId)
2) if orderTypePrefix is null then the prefix set in the product store is used (if present)



Comment by Marco Risaliti [13/Sep/06 04:08 PM] [ Permlink ]
is this improvement will be implemented ?
In this case I will move it to the new jira server.

Thanks
Marco

It's a copy of the old-jira issue OFBIZ-889.

  was:
I was reading Hans's README.pdf for opentravelsystems and thought one of his ideas could be added to OFBiz. Hans had added "S" for sales orders and "P" for purchase orders in orderIds, and I thought we could set it so that OrderType can have two additional fields:

- useStorePrefix - If set to "N", then do not use productStoreId's prefix.
- orderTypePrefix - Someone can set a prefix for this order type.

So purchase orders could be set to useStorePrefix="N" and orderTypePrefix="P" and sales orders could be set to useStorePrefix="Y" and orderTypePrefix=null or ="S"
 
 

 All    Comments    Work Log    Change History       Sort Order:  
Comment by Fred Forester [20/May/06 06:44 AM] [ Permlink ]
Si,

I was looking at how to do this the night before you posted it to jira. I may need a little more detail on where these changes would go and would be glad to do the coding for it.

Fred


Comment by Si Chen [22/May/06 11:08 AM] [ Permlink ]
I was thinking about adding two more fields into OrderType entity and then in OrderServices.java createOrder service, early on, to load the OrderType based on the orderTypeId passed in and check those two fields.

This should be pretty easy to do but I want to make sure David, Jacopo, Hans, etc. like the idea as well.

Comment by Jacopo Cappellato [01/Sep/06 09:31 AM] [ Permlink ]
Si,

I like this idea. However we could slightly simplify it:

1) add a new field OrderType.orderTypePrefix (or orderTypeId)
2) if orderTypePrefix is null then the prefix set in the product store is used (if present)



Comment by Marco Risaliti [13/Sep/06 04:08 PM] [ Permlink ]
is this improvement will be implemented ?
In this case I will move it to the new jira server.

Thanks
Marco

It's a copy of the old-jira issue OFBIZ-889.

> orderType configurable prefixes
> -------------------------------
>
>                 Key: OFBIZ-294
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-294
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Minor
>
> Copy of http://jira.undersunconsulting.com/browse/OFBIZ-889 from Si Chen.
> =======================================
> I was reading Hans's README.pdf for opentravelsystems and thought one of his ideas could be added to OFBiz. Hans had added "S" for sales orders and "P" for purchase orders in orderIds, and I thought we could set it so that OrderType can have two additional fields:
> - useStorePrefix - If set to "N", then do not use productStoreId's prefix.
> - orderTypePrefix - Someone can set a prefix for this order type.
> So purchase orders could be set to useStorePrefix="N" and orderTypePrefix="P" and sales orders could be set to useStorePrefix="Y" and orderTypePrefix=null or ="S"
>  
>  
>  All    Comments    Work Log    Change History       Sort Order:  
> Comment by Fred Forester [20/May/06 06:44 AM] [ Permlink ]
> Si,
> I was looking at how to do this the night before you posted it to jira. I may need a little more detail on where these changes would go and would be glad to do the coding for it.
> Fred
> Comment by Si Chen [22/May/06 11:08 AM] [ Permlink ]
> I was thinking about adding two more fields into OrderType entity and then in OrderServices.java createOrder service, early on, to load the OrderType based on the orderTypeId passed in and check those two fields.
> This should be pretty easy to do but I want to make sure David, Jacopo, Hans, etc. like the idea as well.
> Comment by Jacopo Cappellato [01/Sep/06 09:31 AM] [ Permlink ]
> Si,
> I like this idea. However we could slightly simplify it:
> 1) add a new field OrderType.orderTypePrefix (or orderTypeId)
> 2) if orderTypePrefix is null then the prefix set in the product store is used (if present)
> Comment by Marco Risaliti [13/Sep/06 04:08 PM] [ Permlink ]
> is this improvement will be implemented ?
> In this case I will move it to the new jira server.
> Thanks
> Marco
> It's a copy of the old-jira issue OFBIZ-889.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira