[jira] Created: (OFBIZ-2941) improvement on the calendar screen

[Nicolas Malin (Jira)]

improvement on the calendar screen
----------------------------------

                 Key: OFBIZ-2941
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
             Project: OFBiz
          Issue Type: Improvement
          Components: workeffort
    Affects Versions: SVN trunk
            Reporter: Erwan de FERRIERES
             Fix For: SVN trunk


This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.

https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2941:
--------------------------------------

    Attachment: OFBIZ-2941.diff

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755191#action_12755191 ]

Adrian Crum commented on OFBIZ-2941:
------------------------------------

The bothclear CSS class was eliminated a while ago. Use the clear class.

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755195#action_12755195 ]

Jacques Le Roux commented on OFBIZ-2941:
----------------------------------------

Hi Erwan,

I like it, there is just one point I'd like to be sure it's not a regression (I did not write this and I don't know if it was intentional). The bar where the view can be changed  (week/days/month) was before above the 3 parts of the bottom of the screen. With your changes it will be only around the calendat itself.

So if nobody see a problem with that I will commit your patch in some days...

Maybe you could also explain why you make this choice, or change back to what it was before if your change was unintentional ?

Thanks

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755412#action_12755412 ]

Erwan de FERRIERES commented on OFBIZ-2941:
-------------------------------------------

Adrian,
In the clear class, there is a property visibility set to hidden, which hide the calendar. So we need to add an extra style which won't hide this calendar

Jacques,
This change was intentional, as the navigation buttons are related to the calendar and not to the events. It is more coherent, from my point of view, to add the buttons on the screenlet that is going to be manipulate.

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755423#action_12755423 ]

Jacques Le Roux commented on OFBIZ-2941:
----------------------------------------

Should be OK, I just wait Adrian's confirmation before commiting

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755507#action_12755507 ]

Adrian Crum commented on OFBIZ-2941:
------------------------------------

Just put the clearing element after the screenlet:

{code}
<container style="clear"/>
{code}

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2941:
--------------------------------------

    Attachment: OFBIZ-2941.2.diff

thanks adrian for the tip.
here is the new version of the patch, and a small correction to a wrong entitylabel introduced in 2939

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.2.diff, OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2941.
----------------------------------

    Resolution: Fixed
      Assignee: Adrian Crum

Thanks Erwan,

Your patch is in trunk at r815479  

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Adrian Crum
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.2.diff, OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2941:
--------------------------------------

    Attachment: OFBIZ-2941.3.diff

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Adrian Crum
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.2.diff, OFBIZ-2941.3.diff, OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755926#action_12755926 ]

Hans Bakker commented on OFBIZ-2941:
------------------------------------

ok looks better now...the separation of the screenlets...can live with it.....
Thanks for the quick reply,

Committed revision 815655

> improvement on the calendar screen
> ----------------------------------
>
>                 Key: OFBIZ-2941
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2941
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Adrian Crum
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2941.2.diff, OFBIZ-2941.3.diff, OFBIZ-2941.diff
>
>
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen.
> https://localhost:8443/workeffort/control/calendar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.