[jira] Created: (OFBIZ-2946) orderHistory for completed orders - shows multiple invoices
Locked
[jira] Created: (OFBIZ-2946) orderHistory for completed orders - shows multiple invoices
 
|
orderHistory for completed orders - shows multiple invoices
----------------------------------------------------------- Key: OFBIZ-2946 URL: https://issues.apache.org/jira/browse/OFBIZ-2946 Project: OFBiz Issue Type: Bug Environment: trunk version Reporter: Aswath Satrasala There is a bug in orderHistory.ftl. In the line 60, that is as follows <#assign invoices = delegator.findByAnd("OrderItemBilling", Static["org.ofbiz.base.util.UtilMisc"].toMap("orderId", "${orderHeader.orderId}"))> <#if invoices?has_content> <#list invoices as invoice> <a href="<@ofbizUrl>invoice.pdf?invoiceId=${invoice.invoiceId}</@ofbizUrl>" class="buttontext">(${invoice.invoiceId} PDF) </a> </#list> <#else> </#if> Here, in the orderhistory page, there are many invoice links displayed (all point to the same invoice). The sample data in my database is as follows, and hence displays 6 invoices for the same orderid in the orderhistory page as per the above delegator.findByAnd. orderid seqid invoiceid issuanceid quantity amount WSCO10000 00001 CI1 00001 10012 6 38.4 WSCO10000 00001 CI1 00006 10013 5 38.4 WSCO10000 00002 CI1 00011 10014 1 59.99 WSCO10000 00005 CI1 00013 10017 1 59.99 WSCO10000 00003 CI1 00015 10015 1 1.99 WSCO10000 00004 CI1 00017 10016 1 1.99 --- I have the patch for this already. -Aswath -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2946) orderHistory for completed orders - shows multiple invoices
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aswath Satrasala updated OFBIZ-2946: ------------------------------------ Attachment: orderhistorypatch.txt Please review the patch. Thanks -Aswath > orderHistory for completed orders - shows multiple invoices > ----------------------------------------------------------- > > Key: OFBIZ-2946 > URL: https://issues.apache.org/jira/browse/OFBIZ-2946 > Project: OFBiz > Issue Type: Bug > Environment: trunk version > Reporter: Aswath Satrasala > Attachments: orderhistorypatch.txt > > > There is a bug in orderHistory.ftl. > In the line 60, that is as follows > <#assign invoices = delegator.findByAnd("OrderItemBilling", Static["org.ofbiz.base.util.UtilMisc"].toMap("orderId", "${orderHeader.orderId}"))> > <#if invoices?has_content> > <#list invoices as invoice> > <a href="<@ofbizUrl>invoice.pdf?invoiceId=${invoice.invoiceId}</@ofbizUrl>" class="buttontext">(${invoice.invoiceId} PDF) </a> > </#list> > <#else> > </#if> > Here, in the orderhistory page, there are many invoice links displayed (all point to the same invoice). > The sample data in my database is as follows, and hence displays 6 invoices for the same orderid in the orderhistory page as per the above delegator.findByAnd. > orderid seqid invoiceid issuanceid quantity amount > WSCO10000 00001 CI1 00001 10012 6 38.4 > WSCO10000 00001 CI1 00006 10013 5 38.4 > WSCO10000 00002 CI1 00011 10014 1 59.99 > WSCO10000 00005 CI1 00013 10017 1 59.99 > WSCO10000 00003 CI1 00015 10015 1 1.99 > WSCO10000 00004 CI1 00017 10016 1 1.99 > --- > I have the patch for this already. > -Aswath -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2946) orderHistory for completed orders - shows multiple invoices
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758186#action_12758186 ] Jacques Le Roux commented on OFBIZ-2946: ---------------------------------------- Hi Aswath, Could you please provide exact steps to reproduce ? Is it related to an order with a service product in ? > orderHistory for completed orders - shows multiple invoices > ----------------------------------------------------------- > > Key: OFBIZ-2946 > URL: https://issues.apache.org/jira/browse/OFBIZ-2946 > Project: OFBiz > Issue Type: Bug > Environment: trunk version > Reporter: Aswath Satrasala > Attachments: orderhistorypatch.txt > > > There is a bug in orderHistory.ftl. > In the line 60, that is as follows > <#assign invoices = delegator.findByAnd("OrderItemBilling", Static["org.ofbiz.base.util.UtilMisc"].toMap("orderId", "${orderHeader.orderId}"))> > <#if invoices?has_content> > <#list invoices as invoice> > <a href="<@ofbizUrl>invoice.pdf?invoiceId=${invoice.invoiceId}</@ofbizUrl>" class="buttontext">(${invoice.invoiceId} PDF) </a> > </#list> > <#else> > </#if> > Here, in the orderhistory page, there are many invoice links displayed (all point to the same invoice). > The sample data in my database is as follows, and hence displays 6 invoices for the same orderid in the orderhistory page as per the above delegator.findByAnd. > orderid seqid invoiceid issuanceid quantity amount > WSCO10000 00001 CI1 00001 10012 6 38.4 > WSCO10000 00001 CI1 00006 10013 5 38.4 > WSCO10000 00002 CI1 00011 10014 1 59.99 > WSCO10000 00005 CI1 00013 10017 1 59.99 > WSCO10000 00003 CI1 00015 10015 1 1.99 > WSCO10000 00004 CI1 00017 10016 1 1.99 > --- > I have the patch for this already. > -Aswath -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2946) orderHistory for completed orders - shows multiple invoices
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758605#action_12758605 ] Aswath Satrasala commented on OFBIZ-2946: ----------------------------------------- Following are the steps. * I order 10-tiny zigmo through ecommerce * I did a quick ship entire order in the order manager * In the ecommerce, I did 'client-order history'. Then, multiple pdf's are shown. I think, in general completed orders has this issue -Aswath > orderHistory for completed orders - shows multiple invoices > ----------------------------------------------------------- > > Key: OFBIZ-2946 > URL: https://issues.apache.org/jira/browse/OFBIZ-2946 > Project: OFBiz > Issue Type: Bug > Environment: trunk version > Reporter: Aswath Satrasala > Attachments: orderhistorypatch.txt > > > There is a bug in orderHistory.ftl. > In the line 60, that is as follows > <#assign invoices = delegator.findByAnd("OrderItemBilling", Static["org.ofbiz.base.util.UtilMisc"].toMap("orderId", "${orderHeader.orderId}"))> > <#if invoices?has_content> > <#list invoices as invoice> > <a href="<@ofbizUrl>invoice.pdf?invoiceId=${invoice.invoiceId}</@ofbizUrl>" class="buttontext">(${invoice.invoiceId} PDF) </a> > </#list> > <#else> > </#if> > Here, in the orderhistory page, there are many invoice links displayed (all point to the same invoice). > The sample data in my database is as follows, and hence displays 6 invoices for the same orderid in the orderhistory page as per the above delegator.findByAnd. > orderid seqid invoiceid issuanceid quantity amount > WSCO10000 00001 CI1 00001 10012 6 38.4 > WSCO10000 00001 CI1 00006 10013 5 38.4 > WSCO10000 00002 CI1 00011 10014 1 59.99 > WSCO10000 00005 CI1 00013 10017 1 59.99 > WSCO10000 00003 CI1 00015 10015 1 1.99 > WSCO10000 00004 CI1 00017 10016 1 1.99 > --- > I have the patch for this already. > -Aswath -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-2946) orderHistory for completed orders - shows multiple invoices
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2946. ---------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 9.04 Assignee: Jacques Le Roux Thanks Aswath, Your patch is in trunk at r818030, R9.04 at r818035 I had to merge it by hand, but it was easily done so I did not ask for an update. > orderHistory for completed orders - shows multiple invoices > ----------------------------------------------------------- > > Key: OFBIZ-2946 > URL: https://issues.apache.org/jira/browse/OFBIZ-2946 > Project: OFBiz > Issue Type: Bug > Environment: trunk version > Reporter: Aswath Satrasala > Assignee: Jacques Le Roux > Fix For: Release Branch 9.04, SVN trunk > > Attachments: orderhistorypatch.txt > > > There is a bug in orderHistory.ftl. > In the line 60, that is as follows > <#assign invoices = delegator.findByAnd("OrderItemBilling", Static["org.ofbiz.base.util.UtilMisc"].toMap("orderId", "${orderHeader.orderId}"))> > <#if invoices?has_content> > <#list invoices as invoice> > <a href="<@ofbizUrl>invoice.pdf?invoiceId=${invoice.invoiceId}</@ofbizUrl>" class="buttontext">(${invoice.invoiceId} PDF) </a> > </#list> > <#else> > </#if> > Here, in the orderhistory page, there are many invoice links displayed (all point to the same invoice). > The sample data in my database is as follows, and hence displays 6 invoices for the same orderid in the orderhistory page as per the above delegator.findByAnd. > orderid seqid invoiceid issuanceid quantity amount > WSCO10000 00001 CI1 00001 10012 6 38.4 > WSCO10000 00001 CI1 00006 10013 5 38.4 > WSCO10000 00002 CI1 00011 10014 1 59.99 > WSCO10000 00005 CI1 00013 10017 1 59.99 > WSCO10000 00003 CI1 00015 10015 1 1.99 > WSCO10000 00004 CI1 00017 10016 1 1.99 > --- > I have the patch for this already. > -Aswath -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |