OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2969) UEL errors in picklist services

_‹ Previous Topic Next Topic _›

Classic

List

9 messages Options

Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-2969) UEL errors in picklist services

UEL errors in picklist services
-------------------------------

Key: OFBIZ-2969
URL: https://issues.apache.org/jira/browse/OFBIZ-2969
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: Release Branch 9.04, SVN trunk
Reporter: Wickersheimer Jeremy
Fix For: Release Branch 9.04, SVN trunk

Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple methods.

I had the problem in `getPickAndPackReportInfo` but since i was at it i also fixed the other methods but did not test them.
Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2969) UEL errors in picklist services

[ https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-2969:
----------------------------------------

Attachment: jira-2969.patch

This should apply to both 09.04 and trunk

> UEL errors in picklist services
> -------------------------------
>
> Key: OFBIZ-2969
> URL: https://issues.apache.org/jira/browse/OFBIZ-2969
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Wickersheimer Jeremy
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: jira-2969.patch
>
>
> Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple methods.
> I had the problem in `getPickAndPackReportInfo` but since i was at it i also fixed the other methods but did not test them.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-2969) UEL errors in picklist services

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-2969:
----------------------------------

Assignee: Adrian Crum

> UEL errors in picklist services
> -------------------------------
>
> Key: OFBIZ-2969
> URL: https://issues.apache.org/jira/browse/OFBIZ-2969
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Adrian Crum
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: jira-2969.patch
>
>
> Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple methods.
> I had the problem in `getPickAndPackReportInfo` but since i was at it i also fixed the other methods but did not test them.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2969) UEL errors in picklist services

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759551#action_12759551 ]

Adrian Crum commented on OFBIZ-2969:
------------------------------------

Jeremy,

This patch looks good. If it is not too much trouble, could you also replace the calculate element with a UEL expression? It's not a requirement for committing, it's just a request - since you're already testing that section of code.

One of the nice things about UEL is we can replace the calculate element with simple UEL expressions. It would be nice to get these conversions into the project whenever we run across them.

> UEL errors in picklist services
> -------------------------------
>
> Key: OFBIZ-2969
> URL: https://issues.apache.org/jira/browse/OFBIZ-2969
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Adrian Crum
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: jira-2969.patch
>
>
> Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple methods.
> I had the problem in `getPickAndPackReportInfo` but since i was at it i also fixed the other methods but did not test them.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2969) UEL errors in picklist services

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760214#action_12760214 ]

Wickersheimer Jeremy commented on OFBIZ-2969:
---------------------------------------------

Adrian,

I am not sure i have time to deal with it right now as i am working on other components. Also this would not be a bug fix so it probably would not apply to 09.04. But feel free to do it or add this to another JIRA it there is one for the conversion effort in trunk.

> UEL errors in picklist services
> -------------------------------
>
> Key: OFBIZ-2969
> URL: https://issues.apache.org/jira/browse/OFBIZ-2969
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Adrian Crum
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: jira-2969.patch
>
>
> Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple methods.
> I had the problem in `getPickAndPackReportInfo` but since i was at it i also fixed the other methods but did not test them.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2969) UEL errors in picklist services

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760324#action_12760324 ]

Adrian Crum commented on OFBIZ-2969:
------------------------------------

Jeremy,

Your patch works fine on R9.04, but it has conflicts with the trunk.

> UEL errors in picklist services
> -------------------------------
>
> Key: OFBIZ-2969
> URL: https://issues.apache.org/jira/browse/OFBIZ-2969
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Adrian Crum
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: jira-2969.patch
>
>
> Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple methods.
> I had the problem in `getPickAndPackReportInfo` but since i was at it i also fixed the other methods but did not test them.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2969) UEL errors in picklist services

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766438#action_12766438 ]

Wickersheimer Jeremy commented on OFBIZ-2969:
---------------------------------------------

We are not working with trunk so if it has conflicts it may have already been fixed there, or there are new simple methods.
Let's just apply it to 09.04 for now then.

> UEL errors in picklist services
> -------------------------------
>
> Key: OFBIZ-2969
> URL: https://issues.apache.org/jira/browse/OFBIZ-2969
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Adrian Crum
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: jira-2969.patch
>
>
> Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple methods.
> I had the problem in `getPickAndPackReportInfo` but since i was at it i also fixed the other methods but did not test them.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2969) UEL errors in picklist services

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767476#action_12767476 ]

Jacques Le Roux commented on OFBIZ-2969:
----------------------------------------

Jeremy, Adrian,

Some if not all, have already been fixed in trunk by Adrian at r770308. I backported them in R9.04 at r826786.

Jeremy, could you please check if all the changes you did are in r826786 ?

Thanks

> UEL errors in picklist services
> -------------------------------
>
> Key: OFBIZ-2969
> URL: https://issues.apache.org/jira/browse/OFBIZ-2969
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Adrian Crum
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: jira-2969.patch
>
>
> Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple methods.
> I had the problem in `getPickAndPackReportInfo` but since i was at it i also fixed the other methods but did not test them.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-2969) UEL errors in picklist services

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-2969.
------------------------------

Resolution: Fixed

> UEL errors in picklist services
> -------------------------------
>
> Key: OFBIZ-2969
> URL: https://issues.apache.org/jira/browse/OFBIZ-2969
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Adrian Crum
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: jira-2969.patch
>
>
> Like https://issues.apache.org/jira/browse/OFBIZ-2513 but in the other simple methods.
> I had the problem in `getPickAndPackReportInfo` but since i was at it i also fixed the other methods but did not test them.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.