[jira] Created: (OFBIZ-2971) Shipping Options are not showing correct currency symbol

[Nicolas Malin (Jira)]

Shipping Options are not showing correct currency symbol
--------------------------------------------------------

                 Key: OFBIZ-2971
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2971
             Project: OFBiz
          Issue Type: Bug
          Components: specialpurpose/ecommerce
    Affects Versions: Release Branch 9.04
         Environment: Mac OS 10.5
            Reporter: Simon Hutchinson
            Priority: Minor


During "Step 3: Shipping Options" of the one page checkout the available options are displayed as options in a select box.

The description of the option includes a currency symbol. - However this symbol is always a $.

To re-create:

1.Set up a store and product with currency and price set to a currecy other then USD.
2.From the ecommerce application add the product from step 1 to shopping basket and check out (logged in) using the one page checkout.
3. The shipping options in step 3 will have the "$" symbol in thier description,

Note, the dollar symbol is hard-coded in /specialpurpose/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml

in the getShipOptions simple method

This is the line with the hard-coded $ symbol. Note the double $$ in $${shippingEst}"/>

<set field="shippingDesc" value="${carrierShipmentMethod.partyId} ${carrierShipmentMethod.description} - $${shippingEst}"/>



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Hutchinson updated OFBIZ-2971:
------------------------------------

    Attachment: Picture 2.png

This attached image show the problem in ecommerce.

Notice that the prices in the summary table at the top all are dispayed as £

But the expanding select box with the options are all shown as $

> Shipping Options are not showing correct currency symbol
> --------------------------------------------------------
>
>                 Key: OFBIZ-2971
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2971
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 9.04
>         Environment: Mac OS 10.5
>            Reporter: Simon Hutchinson
>            Priority: Minor
>         Attachments: Picture 2.png
>
>
> During "Step 3: Shipping Options" of the one page checkout the available options are displayed as options in a select box.
> The description of the option includes a currency symbol. - However this symbol is always a $.
> To re-create:
> 1.Set up a store and product with currency and price set to a currecy other then USD.
> 2.From the ecommerce application add the product from step 1 to shopping basket and check out (logged in) using the one page checkout.
> 3. The shipping options in step 3 will have the "$" symbol in thier description,
> Note, the dollar symbol is hard-coded in /specialpurpose/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> in the getShipOptions simple method
> This is the line with the hard-coded $ symbol. Note the double $$ in $${shippingEst}"/>
> <set field="shippingDesc" value="${carrierShipmentMethod.partyId} ${carrierShipmentMethod.description} - $${shippingEst}"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Hutchinson updated OFBIZ-2971:
------------------------------------

    Attachment: shippingOptionCurrencySymbol.diff

This is a tentative patch to resolve this issue.

> Shipping Options are not showing correct currency symbol
> --------------------------------------------------------
>
>                 Key: OFBIZ-2971
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2971
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 9.04
>         Environment: Mac OS 10.5
>            Reporter: Simon Hutchinson
>            Priority: Minor
>         Attachments: Picture 2.png, shippingOptionCurrencySymbol.diff
>
>
> During "Step 3: Shipping Options" of the one page checkout the available options are displayed as options in a select box.
> The description of the option includes a currency symbol. - However this symbol is always a $.
> To re-create:
> 1.Set up a store and product with currency and price set to a currecy other then USD.
> 2.From the ecommerce application add the product from step 1 to shopping basket and check out (logged in) using the one page checkout.
> 3. The shipping options in step 3 will have the "$" symbol in thier description,
> Note, the dollar symbol is hard-coded in /specialpurpose/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> in the getShipOptions simple method
> This is the line with the hard-coded $ symbol. Note the double $$ in $${shippingEst}"/>
> <set field="shippingDesc" value="${carrierShipmentMethod.partyId} ${carrierShipmentMethod.description} - $${shippingEst}"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2971.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 9.04
         Assignee: Jacques Le Roux

Thanks Simon,

Your patch is in trunk at r819337, R9.04 at r819338

> Shipping Options are not showing correct currency symbol
> --------------------------------------------------------
>
>                 Key: OFBIZ-2971
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2971
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 9.04
>         Environment: Mac OS 10.5
>            Reporter: Simon Hutchinson
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: Picture 2.png, shippingOptionCurrencySymbol.diff
>
>
> During "Step 3: Shipping Options" of the one page checkout the available options are displayed as options in a select box.
> The description of the option includes a currency symbol. - However this symbol is always a $.
> To re-create:
> 1.Set up a store and product with currency and price set to a currecy other then USD.
> 2.From the ecommerce application add the product from step 1 to shopping basket and check out (logged in) using the one page checkout.
> 3. The shipping options in step 3 will have the "$" symbol in thier description,
> Note, the dollar symbol is hard-coded in /specialpurpose/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> in the getShipOptions simple method
> This is the line with the hard-coded $ symbol. Note the double $$ in $${shippingEst}"/>
> <set field="shippingDesc" value="${carrierShipmentMethod.partyId} ${carrierShipmentMethod.description} - $${shippingEst}"/>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.