[jira] Created: (OFBIZ-301) Allow extending a form widget from a different file with the same form name

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-301) Allow extending a form widget from a different file with the same form name

Nicolas Malin (Jira)
Allow extending a form widget from a different file with the same form name
---------------------------------------------------------------------------

                 Key: OFBIZ-301
                 URL: http://issues.apache.org/jira/browse/OFBIZ-301
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Marco Risaliti
            Priority: Minor
         Attachments: extends-resource.patch

With form-widget, it is not possible to extend another form with the same form-name. I agree with this behaviour when we extend a form from another one in the same file to avoid recursive definition.

Exemple :
FormsA.xml
<form name="test">...</form>
<form name="test" extends="test">...</form>
=> recursive definition

But :
FormsB.xml
<form name="test" extends="test" extends-resource="FormsA.xml">...</form>
=> should work because forms are in different files

I think this limitation is not necessary when we extend a form from another file and I've found a "TODO" comment in ModelForm.java about this problem.

So I propose a patch to fix this small issue. I hope I've not missed some implications.
 
 

 All    Comments    Work Log    Change History       Sort Order:  
Comment by Marco Risaliti [14/Sep/06 08:55 AM] [ Permlink ]
Hi David,

could you please help me this patch is important and so I have to move to the new jira server of simply close it ?

Thanks
Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-301) Allow extending a form widget from a different file with the same form name

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-301?page=all ]

Marco Risaliti updated OFBIZ-301:
---------------------------------

    Attachment: extends-resource.patch

> Allow extending a form widget from a different file with the same form name
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-301
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-301
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Minor
>         Attachments: extends-resource.patch
>
>
> With form-widget, it is not possible to extend another form with the same form-name. I agree with this behaviour when we extend a form from another one in the same file to avoid recursive definition.
> Exemple :
> FormsA.xml
> <form name="test">...</form>
> <form name="test" extends="test">...</form>
> => recursive definition
> But :
> FormsB.xml
> <form name="test" extends="test" extends-resource="FormsA.xml">...</form>
> => should work because forms are in different files
> I think this limitation is not necessary when we extend a form from another file and I've found a "TODO" comment in ModelForm.java about this problem.
> So I propose a patch to fix this small issue. I hope I've not missed some implications.
>  
>  
>  All    Comments    Work Log    Change History       Sort Order:  
> Comment by Marco Risaliti [14/Sep/06 08:55 AM] [ Permlink ]
> Hi David,
> could you please help me this patch is important and so I have to move to the new jira server of simply close it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-301) Allow extending a form widget from a different file with the same form name

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-301?page=all ]

Jacques Le Roux reassigned OFBIZ-301:
-------------------------------------

    Assignee: Jacques Le Roux

> Allow extending a form widget from a different file with the same form name
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-301
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-301
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>         Attachments: extends-resource.patch
>
>
> With form-widget, it is not possible to extend another form with the same form-name. I agree with this behaviour when we extend a form from another one in the same file to avoid recursive definition.
> Exemple :
> FormsA.xml
> <form name="test">...</form>
> <form name="test" extends="test">...</form>
> => recursive definition
> But :
> FormsB.xml
> <form name="test" extends="test" extends-resource="FormsA.xml">...</form>
> => should work because forms are in different files
> I think this limitation is not necessary when we extend a form from another file and I've found a "TODO" comment in ModelForm.java about this problem.
> So I propose a patch to fix this small issue. I hope I've not missed some implications.
>  
>  
>  All    Comments    Work Log    Change History       Sort Order:  
> Comment by Marco Risaliti [14/Sep/06 08:55 AM] [ Permlink ]
> Hi David,
> could you please help me this patch is important and so I have to move to the new jira server of simply close it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-301) Allow extending a form widget from a different file with the same form name

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-301?page=all ]

Jacques Le Roux closed OFBIZ-301.
---------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Commited in 446825

> Allow extending a form widget from a different file with the same form name
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-301
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-301
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: extends-resource.patch
>
>
> With form-widget, it is not possible to extend another form with the same form-name. I agree with this behaviour when we extend a form from another one in the same file to avoid recursive definition.
> Exemple :
> FormsA.xml
> <form name="test">...</form>
> <form name="test" extends="test">...</form>
> => recursive definition
> But :
> FormsB.xml
> <form name="test" extends="test" extends-resource="FormsA.xml">...</form>
> => should work because forms are in different files
> I think this limitation is not necessary when we extend a form from another file and I've found a "TODO" comment in ModelForm.java about this problem.
> So I propose a patch to fix this small issue. I hope I've not missed some implications.
>  
>  
>  All    Comments    Work Log    Change History       Sort Order:  
> Comment by Marco Risaliti [14/Sep/06 08:55 AM] [ Permlink ]
> Hi David,
> could you please help me this patch is important and so I have to move to the new jira server of simply close it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira