[jira] Created: (OFBIZ-3028) context.get("menuStringRenderer") is called twice in /framework/widget/src/org/ofbiz/widget/screen/ModelScreenWidget.java method renderWidgetString.

[Nicolas Malin (Jira)]

context.get("menuStringRenderer") is called twice in /framework/widget/src/org/ofbiz/widget/screen/ModelScreenWidget.java method renderWidgetString.
----------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-3028
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3028
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Zhang Weixue


menuStringRenderer = (MenuStringRenderer) context.get("menuStringRenderer"), this line of code appears twice in below code segment. Why?

        public void renderWidgetString(Appendable writer, Map<String, Object> context, ScreenStringRenderer screenStringRenderer) throws IOException {
            // try finding the menuStringRenderer by name in the context in case one was prepared and put there
            MenuStringRenderer menuStringRenderer = (MenuStringRenderer) context.get("menuStringRenderer");
            // if there was no menuStringRenderer put in place, now try finding the request/response in the context and creating a new one
            if (menuStringRenderer == null) {
                // try finding the menuStringRenderer by name in the context in
                // case one was prepared and put there
                menuStringRenderer = (MenuStringRenderer) context.get("menuStringRenderer");
                // if there was no menuStringRenderer put in place, now try
                // finding the request/response in the context and creating a
                // new one
                if (menuStringRenderer == null) {
 

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3028.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 9.04
         Assignee: Jacques Le Roux

Thanks Zhang,

Yes this was a C/P duplicated snippet I guess, removed in trunk at r829525, got a conflict in R9.04, gave up

> context.get("menuStringRenderer") is called twice in /framework/widget/src/org/ofbiz/widget/screen/ModelScreenWidget.java method renderWidgetString.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3028
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3028
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Weixue Zhang
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>
> menuStringRenderer = (MenuStringRenderer) context.get("menuStringRenderer"), this line of code appears twice in below code segment. Why?
>         public void renderWidgetString(Appendable writer, Map<String, Object> context, ScreenStringRenderer screenStringRenderer) throws IOException {
>             // try finding the menuStringRenderer by name in the context in case one was prepared and put there
>             MenuStringRenderer menuStringRenderer = (MenuStringRenderer) context.get("menuStringRenderer");
>             // if there was no menuStringRenderer put in place, now try finding the request/response in the context and creating a new one
>             if (menuStringRenderer == null) {
>                 // try finding the menuStringRenderer by name in the context in
>                 // case one was prepared and put there
>                 menuStringRenderer = (MenuStringRenderer) context.get("menuStringRenderer");
>                 // if there was no menuStringRenderer put in place, now try
>                 // finding the request/response in the context and creating a
>                 // new one
>                 if (menuStringRenderer == null) {
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.