OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3033) Improvement in Product Review implementation.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3033) Improvement in Product Review implementation.

Improvement in Product Review implementation.
---------------------------------------------

Key: OFBIZ-3033
URL: https://issues.apache.org/jira/browse/OFBIZ-3033
Project: OFBiz
Issue Type: Improvement
Components: product, specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Awdesh Singh Parihar
Priority: Minor
Fix For: SVN trunk

Need following improvements in Product Review implementation :

1) Make createProductReview service definition more generic, so that it can take all nopk fields as IN parameters.
2) Change field value in "productreview.ftl" because field "postedAnonymous" is not a boolean type in ProductReview entity.
3) Make the service implementation more generic so that, it can be used for unregistered users also.
4) Put checks on pendingReviews.ftl to handle case of anonymous user.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3033) Improvement in Product Review implementation.

[ https://issues.apache.org/jira/browse/OFBIZ-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-3033:
------------------------------------------

Assignee: Ashish Vijaywargiya

> Improvement in Product Review implementation.
> ---------------------------------------------
>
> Key: OFBIZ-3033
> URL: https://issues.apache.org/jira/browse/OFBIZ-3033
> Project: OFBiz
> Issue Type: Improvement
> Components: product, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Awdesh Singh Parihar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
>
> Need following improvements in Product Review implementation :
> 1) Make createProductReview service definition more generic, so that it can take all nopk fields as IN parameters.
> 2) Change field value in "productreview.ftl" because field "postedAnonymous" is not a boolean type in ProductReview entity.
> 3) Make the service implementation more generic so that, it can be used for unregistered users also.
> 4) Put checks on pendingReviews.ftl to handle case of anonymous user.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3033) Improvement in Product Review implementation.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Singh Parihar updated OFBIZ-3033:
----------------------------------------

Attachment: OFBIZ-3033.patch

Please find the mentioned improvement in patch .

--
Awdesh Parihar

> Improvement in Product Review implementation.
> ---------------------------------------------
>
> Key: OFBIZ-3033
> URL: https://issues.apache.org/jira/browse/OFBIZ-3033
> Project: OFBiz
> Issue Type: Improvement
> Components: product, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Awdesh Singh Parihar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3033.patch
>
>
> Need following improvements in Product Review implementation :
> 1) Make createProductReview service definition more generic, so that it can take all nopk fields as IN parameters.
> 2) Change field value in "productreview.ftl" because field "postedAnonymous" is not a boolean type in ProductReview entity.
> 3) Make the service implementation more generic so that, it can be used for unregistered users also.
> 4) Put checks on pendingReviews.ftl to handle case of anonymous user.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3033) Improvement in Product Review implementation.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-3033.
--------------------------------------

Resolution: Fixed

Thanks Awdesh - Your changes are in trunk at r824675.

--
Ashish

> Improvement in Product Review implementation.
> ---------------------------------------------
>
> Key: OFBIZ-3033
> URL: https://issues.apache.org/jira/browse/OFBIZ-3033
> Project: OFBiz
> Issue Type: Improvement
> Components: product, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Awdesh Singh Parihar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3033.patch
>
>
> Need following improvements in Product Review implementation :
> 1) Make createProductReview service definition more generic, so that it can take all nopk fields as IN parameters.
> 2) Change field value in "productreview.ftl" because field "postedAnonymous" is not a boolean type in ProductReview entity.
> 3) Make the service implementation more generic so that, it can be used for unregistered users also.
> 4) Put checks on pendingReviews.ftl to handle case of anonymous user.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3033) Improvement in Product Review implementation.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765037#action_12765037 ]

Awdesh Singh Parihar commented on OFBIZ-3033:
---------------------------------------------

Thank you Ashish for committing patch
--
Awdesh

> Improvement in Product Review implementation.
> ---------------------------------------------
>
> Key: OFBIZ-3033
> URL: https://issues.apache.org/jira/browse/OFBIZ-3033
> Project: OFBiz
> Issue Type: Improvement
> Components: product, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Awdesh Singh Parihar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3033.patch
>
>
> Need following improvements in Product Review implementation :
> 1) Make createProductReview service definition more generic, so that it can take all nopk fields as IN parameters.
> 2) Change field value in "productreview.ftl" because field "postedAnonymous" is not a boolean type in ProductReview entity.
> 3) Make the service implementation more generic so that, it can be used for unregistered users also.
> 4) Put checks on pendingReviews.ftl to handle case of anonymous user.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.