[jira] Created: (OFBIZ-3046) EditPersonTrainings has been deleted since r802308

[Nicolas Malin (Jira)]

EditPersonTrainings has been deleted since r802308
--------------------------------------------------

                 Key: OFBIZ-3046
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3046
             Project: OFBiz
          Issue Type: Bug
          Components: party
    Affects Versions: SVN trunk
            Reporter: matthieu bollot


EditPersonTrainings screen has been deleted from humanres/widget/PersonTrainingScreens.xml.

To reproduce, go to https://localhost:8443/partymgr/control/viewprofile?partyId=admin and click on Training in "sub-sub"-menu

Author: hansbak
Date: Sat Aug  8 07:20:30 2009
New Revision: 802308

URL: http://svn.apache.org/viewvc?rev=802308&view=rev

Patch file contains :
     </screen>
-    <screen name="EditPersonTrainings">
+    <screen name="TrainingCalendarWithDecorator">
         <section>

So I don't know if EditPersonTrainings should be replaced by TrainingCalendarWithDecorator or if it should be completely deleted.
By the way, the log of the commit is :
Log:
commited patch of OFBIZ-2531 with minor changes, however added initial help screens, initial commit need some more work on the permissions for admin and employee

But there are a lot of change so may be it is a mistake ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766871#action_12766871 ]

Jacques Le Roux commented on OFBIZ-3046:
----------------------------------------

Hi Matthieu,

Actually I tried to clean this at [r817443|http://svn.apache.org/viewvc?rev=817443&view=rev] but obvisouly I missed this one. A patch would be welcome

Thanks

> EditPersonTrainings has been deleted since r802308
> --------------------------------------------------
>
>                 Key: OFBIZ-3046
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3046
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>
> EditPersonTrainings screen has been deleted from humanres/widget/PersonTrainingScreens.xml.
> To reproduce, go to https://localhost:8443/partymgr/control/viewprofile?partyId=admin and click on Training in "sub-sub"-menu
> Author: hansbak
> Date: Sat Aug  8 07:20:30 2009
> New Revision: 802308
> URL: http://svn.apache.org/viewvc?rev=802308&view=rev
> Patch file contains :
>      </screen>
> -    <screen name="EditPersonTrainings">
> +    <screen name="TrainingCalendarWithDecorator">
>          <section>
> So I don't know if EditPersonTrainings should be replaced by TrainingCalendarWithDecorator or if it should be completely deleted.
> By the way, the log of the commit is :
> Log:
> commited patch of OFBIZ-2531 with minor changes, however added initial help screens, initial commit need some more work on the permissions for admin and employee
> But there are a lot of change so may be it is a mistake ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

matthieu bollot updated OFBIZ-3046:
-----------------------------------

    Attachment: cleantraining.patch

This patch delete references to EditPersonTrainings and to FindTrainings.

> EditPersonTrainings has been deleted since r802308
> --------------------------------------------------
>
>                 Key: OFBIZ-3046
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3046
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: cleantraining.patch
>
>
> EditPersonTrainings screen has been deleted from humanres/widget/PersonTrainingScreens.xml.
> To reproduce, go to https://localhost:8443/partymgr/control/viewprofile?partyId=admin and click on Training in "sub-sub"-menu
> Author: hansbak
> Date: Sat Aug  8 07:20:30 2009
> New Revision: 802308
> URL: http://svn.apache.org/viewvc?rev=802308&view=rev
> Patch file contains :
>      </screen>
> -    <screen name="EditPersonTrainings">
> +    <screen name="TrainingCalendarWithDecorator">
>          <section>
> So I don't know if EditPersonTrainings should be replaced by TrainingCalendarWithDecorator or if it should be completely deleted.
> By the way, the log of the commit is :
> Log:
> commited patch of OFBIZ-2531 with minor changes, however added initial help screens, initial commit need some more work on the permissions for admin and employee
> But there are a lot of change so may be it is a mistake ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3046.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Thanks Matthieu,

Your patch is in trunk at r826272  

> EditPersonTrainings has been deleted since r802308
> --------------------------------------------------
>
>                 Key: OFBIZ-3046
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3046
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: cleantraining.patch
>
>
> EditPersonTrainings screen has been deleted from humanres/widget/PersonTrainingScreens.xml.
> To reproduce, go to https://localhost:8443/partymgr/control/viewprofile?partyId=admin and click on Training in "sub-sub"-menu
> Author: hansbak
> Date: Sat Aug  8 07:20:30 2009
> New Revision: 802308
> URL: http://svn.apache.org/viewvc?rev=802308&view=rev
> Patch file contains :
>      </screen>
> -    <screen name="EditPersonTrainings">
> +    <screen name="TrainingCalendarWithDecorator">
>          <section>
> So I don't know if EditPersonTrainings should be replaced by TrainingCalendarWithDecorator or if it should be completely deleted.
> By the way, the log of the commit is :
> Log:
> commited patch of OFBIZ-2531 with minor changes, however added initial help screens, initial commit need some more work on the permissions for admin and employee
> But there are a lot of change so may be it is a mistake ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.