OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-305) New "description" attribute for entitymodel fields to help keep comments

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-305) New "description" attribute for entitymodel fields to help keep comments

New "description" attribute for entitymodel fields to help keep comments
------------------------------------------------------------------------

Key: OFBIZ-305
URL: http://issues.apache.org/jira/browse/OFBIZ-305
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Marco Risaliti
Priority: Trivial
Attachments: entitymodel_field_description.patch

Please put in this small change to the entitymodel xsd which will add a "description" attribute to entity fields, to help describe the fields. It'll be nice to keep comments about the data model right there with the definition and will also allow later on for them to be displayed by an entity model viewer such as those in webtools.

All Comments Work Log Change History Sort Order:
Comment by David E. Jones [18/Dec/05 11:26 PM] [ Permlink ]
Rather than using an attribute a sub-element for this is probably better, especially if the description ever gets a bit longer. This is also more consistent with the descrption under the entity and view-entity elements. Now it can be put under just about everything.

This patch still does not include code changes to put these values in the corresponding objects during the parsing, so the code for the following elements needs to be changed (and this issue should perhaps stay open until they are):

field
relation
index
member-entity
alias-all
alias
view-link

The XSD file updates are in SVN rev 6365.

Comment by Chris Howe [07/Jan/06 05:02 AM] [ Permlink ]
Can this issue be closed?

Comment by Si Chen [09/Jan/06 04:08 PM] [ Permlink ]
Actually somebody needs to write some code for getting this field into ModelField/ModelEntity/etc. etc. Want to take a shot at it?

Comment by Marco Risaliti [14/Sep/06 02:12 AM] [ Permlink ]
Can I move it ?

Thanks
Marco

Comment by Marco Risaliti [14/Sep/06 03:02 AM] [ Permlink ]
This patch seems to be not applied so probably no-one need it.
Can I close it ?

Thanks
Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-305) New "description" attribute for entitymodel fields to help keep comments

[ http://issues.apache.org/jira/browse/OFBIZ-305?page=all ]

Marco Risaliti updated OFBIZ-305:
---------------------------------

Attachment: entitymodel_field_description.patch

> New "description" attribute for entitymodel fields to help keep comments
> ------------------------------------------------------------------------
>
> Key: OFBIZ-305
> URL: http://issues.apache.org/jira/browse/OFBIZ-305
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Trivial
> Attachments: entitymodel_field_description.patch
>
>
> Please put in this small change to the entitymodel xsd which will add a "description" attribute to entity fields, to help describe the fields. It'll be nice to keep comments about the data model right there with the definition and will also allow later on for them to be displayed by an entity model viewer such as those in webtools.
>
>
> All Comments Work Log Change History Sort Order:
> Comment by David E. Jones [18/Dec/05 11:26 PM] [ Permlink ]
> Rather than using an attribute a sub-element for this is probably better, especially if the description ever gets a bit longer. This is also more consistent with the descrption under the entity and view-entity elements. Now it can be put under just about everything.
> This patch still does not include code changes to put these values in the corresponding objects during the parsing, so the code for the following elements needs to be changed (and this issue should perhaps stay open until they are):
> field
> relation
> index
> member-entity
> alias-all
> alias
> view-link
> The XSD file updates are in SVN rev 6365.
> Comment by Chris Howe [07/Jan/06 05:02 AM] [ Permlink ]
> Can this issue be closed?
> Comment by Si Chen [09/Jan/06 04:08 PM] [ Permlink ]
> Actually somebody needs to write some code for getting this field into ModelField/ModelEntity/etc. etc. Want to take a shot at it?
> Comment by Marco Risaliti [14/Sep/06 02:12 AM] [ Permlink ]
> Can I move it ?
> Thanks
> Marco
> Comment by Marco Risaliti [14/Sep/06 03:02 AM] [ Permlink ]
> This patch seems to be not applied so probably no-one need it.
> Can I close it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-305) New "description" attribute for entitymodel fields to help keep comments

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-305?page=comments#action_12434813 ]

Marco Risaliti commented on OFBIZ-305:
--------------------------------------

Hi Leon Torres,

I have seen that the attached pacth is too old and it cannot be review to understand what they do.
So if you want that this issue will progress you have to attach a new patch otherwise it will be closed (incomplete).

Thanks
Marco

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-305) New "description" attribute for entitymodel fields to help keep comments

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-305?page=comments#action_12435273 ]

Jacques Le Roux commented on OFBIZ-305:
---------------------------------------

Marco,

This patch was already applied by David (see comment above : rev 6365). But some changes need always to be done in parsing. So please don't close this issue.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-305) New "description" attribute for entitymodel fields to help keep comments

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-305?page=all ]

Jacopo Cappellato updated OFBIZ-305:
------------------------------------

Description:
Copy of http://jira.undersunconsulting.com/browse/OFBIZ-582 from Leon Torres.

=========================================================

Please put in this small change to the entitymodel xsd which will add a "description" attribute to entity fields, to help describe the fields. It'll be nice to keep comments about the data model right there with the definition and will also allow later on for them to be displayed by an entity model viewer such as those in webtools.

All Comments Work Log Change History Sort Order:
Comment by David E. Jones [18/Dec/05 11:26 PM] [ Permlink ]
Rather than using an attribute a sub-element for this is probably better, especially if the description ever gets a bit longer. This is also more consistent with the descrption under the entity and view-entity elements. Now it can be put under just about everything.

This patch still does not include code changes to put these values in the corresponding objects during the parsing, so the code for the following elements needs to be changed (and this issue should perhaps stay open until they are):

field
relation
index
member-entity
alias-all
alias
view-link

The XSD file updates are in SVN rev 6365.

Comment by Chris Howe [07/Jan/06 05:02 AM] [ Permlink ]
Can this issue be closed?

Comment by Si Chen [09/Jan/06 04:08 PM] [ Permlink ]
Actually somebody needs to write some code for getting this field into ModelField/ModelEntity/etc. etc. Want to take a shot at it?

Comment by Marco Risaliti [14/Sep/06 02:12 AM] [ Permlink ]
Can I move it ?

Thanks
Marco

Comment by Marco Risaliti [14/Sep/06 03:02 AM] [ Permlink ]
This patch seems to be not applied so probably no-one need it.
Can I close it ?

Thanks
Marco

was:
Please put in this small change to the entitymodel xsd which will add a "description" attribute to entity fields, to help describe the fields. It'll be nice to keep comments about the data model right there with the definition and will also allow later on for them to be displayed by an entity model viewer such as those in webtools.

All Comments Work Log Change History Sort Order:
Comment by David E. Jones [18/Dec/05 11:26 PM] [ Permlink ]
Rather than using an attribute a sub-element for this is probably better, especially if the description ever gets a bit longer. This is also more consistent with the descrption under the entity and view-entity elements. Now it can be put under just about everything.

This patch still does not include code changes to put these values in the corresponding objects during the parsing, so the code for the following elements needs to be changed (and this issue should perhaps stay open until they are):

field
relation
index
member-entity
alias-all
alias
view-link

The XSD file updates are in SVN rev 6365.

Comment by Chris Howe [07/Jan/06 05:02 AM] [ Permlink ]
Can this issue be closed?

Comment by Si Chen [09/Jan/06 04:08 PM] [ Permlink ]
Actually somebody needs to write some code for getting this field into ModelField/ModelEntity/etc. etc. Want to take a shot at it?

Comment by Marco Risaliti [14/Sep/06 02:12 AM] [ Permlink ]
Can I move it ?

Thanks
Marco

Comment by Marco Risaliti [14/Sep/06 03:02 AM] [ Permlink ]
This patch seems to be not applied so probably no-one need it.
Can I close it ?

Thanks
Marco

> New "description" attribute for entitymodel fields to help keep comments
> ------------------------------------------------------------------------
>
> Key: OFBIZ-305
> URL: http://issues.apache.org/jira/browse/OFBIZ-305
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Trivial
> Attachments: entitymodel_field_description.patch
>
>
> Copy of http://jira.undersunconsulting.com/browse/OFBIZ-582 from Leon Torres.
> =========================================================
> Please put in this small change to the entitymodel xsd which will add a "description" attribute to entity fields, to help describe the fields. It'll be nice to keep comments about the data model right there with the definition and will also allow later on for them to be displayed by an entity model viewer such as those in webtools.
>
>
> All Comments Work Log Change History Sort Order:
> Comment by David E. Jones [18/Dec/05 11:26 PM] [ Permlink ]
> Rather than using an attribute a sub-element for this is probably better, especially if the description ever gets a bit longer. This is also more consistent with the descrption under the entity and view-entity elements. Now it can be put under just about everything.
> This patch still does not include code changes to put these values in the corresponding objects during the parsing, so the code for the following elements needs to be changed (and this issue should perhaps stay open until they are):
> field
> relation
> index
> member-entity
> alias-all
> alias
> view-link
> The XSD file updates are in SVN rev 6365.
> Comment by Chris Howe [07/Jan/06 05:02 AM] [ Permlink ]
> Can this issue be closed?
> Comment by Si Chen [09/Jan/06 04:08 PM] [ Permlink ]
> Actually somebody needs to write some code for getting this field into ModelField/ModelEntity/etc. etc. Want to take a shot at it?
> Comment by Marco Risaliti [14/Sep/06 02:12 AM] [ Permlink ]
> Can I move it ?
> Thanks
> Marco
> Comment by Marco Risaliti [14/Sep/06 03:02 AM] [ Permlink ]
> This patch seems to be not applied so probably no-one need it.
> Can I close it ?
> Thanks
> Marco

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-305) New "description" attribute for entitymodel fields to help keep comments

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-305?page=all ]

Chris Howe updated OFBIZ-305:
-----------------------------

Attachment: Description_Model.patch

Description_Model.patch

Adds the description to the models for
field
index
view-entity
alias-all
alias
complex-alias
complex-alias-field
relation

I'm not really positive how to test this patch. I followed the pattern for ModelEntity

> New "description" attribute for entitymodel fields to help keep comments
> ------------------------------------------------------------------------
>
> Key: OFBIZ-305
> URL: http://issues.apache.org/jira/browse/OFBIZ-305
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Trivial
> Attachments: Description_Model.patch, entitymodel_field_description.patch
>
>
> Copy of http://jira.undersunconsulting.com/browse/OFBIZ-582 from Leon Torres.
> =========================================================
> Please put in this small change to the entitymodel xsd which will add a "description" attribute to entity fields, to help describe the fields. It'll be nice to keep comments about the data model right there with the definition and will also allow later on for them to be displayed by an entity model viewer such as those in webtools.
>
>
> All Comments Work Log Change History Sort Order:
> Comment by David E. Jones [18/Dec/05 11:26 PM] [ Permlink ]
> Rather than using an attribute a sub-element for this is probably better, especially if the description ever gets a bit longer. This is also more consistent with the descrption under the entity and view-entity elements. Now it can be put under just about everything.
> This patch still does not include code changes to put these values in the corresponding objects during the parsing, so the code for the following elements needs to be changed (and this issue should perhaps stay open until they are):
> field
> relation
> index
> member-entity
> alias-all
> alias
> view-link
> The XSD file updates are in SVN rev 6365.
> Comment by Chris Howe [07/Jan/06 05:02 AM] [ Permlink ]
> Can this issue be closed?
> Comment by Si Chen [09/Jan/06 04:08 PM] [ Permlink ]
> Actually somebody needs to write some code for getting this field into ModelField/ModelEntity/etc. etc. Want to take a shot at it?
> Comment by Marco Risaliti [14/Sep/06 02:12 AM] [ Permlink ]
> Can I move it ?
> Thanks
> Marco
> Comment by Marco Risaliti [14/Sep/06 03:02 AM] [ Permlink ]
> This patch seems to be not applied so probably no-one need it.
> Can I close it ?
> Thanks
> Marco