[jira] Created: (OFBIZ-3062) creating a billing invoice from the project manager is not fully done

[Nicolas Malin (Jira)]

creating a billing invoice from the project manager is not fully done
---------------------------------------------------------------------

                 Key: OFBIZ-3062
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3062
             Project: OFBiz
          Issue Type: Bug
          Components: specialpurpose/projectmgr
    Affects Versions: SVN trunk
            Reporter: Erwan de FERRIERES
             Fix For: SVN trunk


when you create a billing invoice from the project manager, the currency is not added to the invoice. The currency symbol is then not displayed in the invoice screen and when searching an invoice from the accounting screens, errors are displayed in the console, due to the currency missing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767772#action_12767772 ]

Hans Bakker commented on OFBIZ-3062:
------------------------------------

it takes currently the currency defined from the partyIdTo in the party Entity.....

> creating a billing invoice from the project manager is not fully done
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3062
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3062
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/projectmgr
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>
> when you create a billing invoice from the project manager, the currency is not added to the invoice. The currency symbol is then not displayed in the invoice screen and when searching an invoice from the accounting screens, errors are displayed in the console, due to the currency missing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767869#action_12767869 ]

Erwan de FERRIERES commented on OFBIZ-3062:
-------------------------------------------

Hi Hans,

I've looked a bit more, and the error I had was because in the demo data, the clients have no currency defined. I will provide a patch to correct the data.

> creating a billing invoice from the project manager is not fully done
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3062
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3062
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/projectmgr
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>
> when you create a billing invoice from the project manager, the currency is not added to the invoice. The currency symbol is then not displayed in the invoice screen and when searching an invoice from the accounting screens, errors are displayed in the console, due to the currency missing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3062:
--------------------------------------

    Attachment: OFBIZ-3062.diff

> creating a billing invoice from the project manager is not fully done
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3062
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3062
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/projectmgr
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3062.diff
>
>
> when you create a billing invoice from the project manager, the currency is not added to the invoice. The currency symbol is then not displayed in the invoice screen and when searching an invoice from the accounting screens, errors are displayed in the console, due to the currency missing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768011#action_12768011 ]

Hans Bakker commented on OFBIZ-3062:
------------------------------------

perhaps better to change the system that if the currency is not defined on the party, it should take the default currency?

> creating a billing invoice from the project manager is not fully done
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3062
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3062
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/projectmgr
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3062.diff
>
>
> when you create a billing invoice from the project manager, the currency is not added to the invoice. The currency symbol is then not displayed in the invoice screen and when searching an invoice from the accounting screens, errors are displayed in the console, due to the currency missing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3062:
--------------------------------------

    Attachment: OFBIZ-3062.2.diff

Hi Hans,

this patch will take the default currency.uom.id.default in general.properties file instead of adding the currency to the party.

> creating a billing invoice from the project manager is not fully done
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3062
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3062
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/projectmgr
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3062.2.diff, OFBIZ-3062.diff
>
>
> when you create a billing invoice from the project manager, the currency is not added to the invoice. The currency symbol is then not displayed in the invoice screen and when searching an invoice from the accounting screens, errors are displayed in the console, due to the currency missing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-3062.
------------------------------

    Resolution: Fixed

Hi Erwan,

thanks for the patch, i committed in:  revision 827924.


Regards,
Hans

> creating a billing invoice from the project manager is not fully done
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3062
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3062
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/projectmgr
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3062.2.diff, OFBIZ-3062.diff
>
>
> when you create a billing invoice from the project manager, the currency is not added to the invoice. The currency symbol is then not displayed in the invoice screen and when searching an invoice from the accounting screens, errors are displayed in the console, due to the currency missing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.