[jira] Created: (OFBIZ-3083) Adding a page size selector in the pagination bar

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
Adding a page size selector in the pagination bar
-------------------------------------------------

                 Key: OFBIZ-3083
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
             Project: OFBiz
          Issue Type: New Feature
          Components: framework
            Reporter: Bruno Busco
            Priority: Minor
         Attachments: OFBIZ-3083 viewSizeSelector.patch

I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
Having this feature, the user can select 30 as page size, and have all elements in one page.

In the attached patch there is a first try I am working on.

This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.

Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.

What do you think about?

Thank you,
Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3083:
-------------------------------

    Attachment: OFBIZ-3083 viewSizeSelector.patch

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769767#action_12769767 ]

Jacques Le Roux commented on OFBIZ-3083:
----------------------------------------

Hi Bruno,

Sounds like an excellent idea to me. Of course having it working in all cases (ajax, i18n, etc.) would be better ;)

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769773#action_12769773 ]

Bruno Busco commented on OFBIZ-3083:
------------------------------------

Yes Jacques,
I will add ajax and i18n but I am more interested on hearing if everybody does agree with having the pagination bar always rendered.


> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769779#action_12769779 ]

Jacques Le Roux commented on OFBIZ-3083:
----------------------------------------

I'd prefer have it always rendered

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3083:
-------------------------------

    Attachment: OFBIZ-3083 viewSizeSelector.patch

Please find attached an updated patch with i18n and ajax support.

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769869#action_12769869 ]

Jacques Le Roux commented on OFBIZ-3083:
----------------------------------------

Hi Bruno,

I just tried in categories lookup (from main Product screen).
* From the 1st page of result, when I change from 20 (default) to 30, all dissapears.
* From a page inside, when I change from 20 to 30, nothing happens

I just run ant and reloaded, could be that missed something ?

Also we may enjoy an intermediary 100 in the [20, 30, 50, 200] set. And why not bigger 500 and 1000 (10000?). They could be useful when you want to make a quick search inside a list. Of course when used these numbers should be constrained to the max items present (but I don't think we need someting more elaborated).

Thanks

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769875#action_12769875 ]

Adrian Crum commented on OFBIZ-3083:
------------------------------------

Why not have the user enter the page size, instead of predefined page sizes?


> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769880#action_12769880 ]

Jacques Le Roux commented on OFBIZ-3083:
----------------------------------------

Or both, predefined is quicker ;)

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769994#action_12769994 ]

Bruno Busco commented on OFBIZ-3083:
------------------------------------

Hi Jacques,
thank you for testing the patch.
I must say that this was a rapid prototipe I submitted in order to share ideas about it and so I did not fully tested.
I have seen that in the lookup you tested it does not work.

In any case it seems that in the Example list it works.
I will look into it as soon as I have time.

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3083:
-------------------------------

    Attachment: OFBIZ-3083 viewSizeSelector.patch

An updated patch with Ajax working and a "100" option added.
Even if I did see it initially not working on the lookup It seems that it works in all cases now.


> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770397#action_12770397 ]

Bruno Busco commented on OFBIZ-3083:
------------------------------------

Just to let you know that I think the patch is now OK to be reviewed and committed.
Further improvements will be to have the availableViewSizes to be set in a configuration property file but I do not think I will do it in the short time. (any help greatly appreciated :) )

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770441#action_12770441 ]

Bilgin Ibryam commented on OFBIZ-3083:
--------------------------------------

Bruno, this is a great addition. Thanks!

I did a quick UI test with you patch and faced these issues:

1. When logged in to application with javascript disabled, the dropdown for page number selection is not rendered because it relies on javascrip. I think "Items per page" dropdown should not be rendered too.

2. I did my tests in accounting->find fixed asset screen. After the seach, if your FIRST actions is changing the items per page, the selection seems not working. But after that the next selections are working fine. Then I found that this bug exists even before applying your patch, ie the first click on paginator buttons (such as next, last, changing page number) doesn;t have any effect on the UI.

Bilgin
 

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770537#action_12770537 ]

Adrian Crum commented on OFBIZ-3083:
------------------------------------

Bilgin brings up a good point - the Find Fixed Asset screen is a good test bed for these kinds of modifications because it uses Ajax.



> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770937#action_12770937 ]

Bruno Busco commented on OFBIZ-3083:
------------------------------------

Hi Bilgin,
thank you for reviewing the patch.

1) I agree. I will update the patch.

2) I did my tests about the ajax support on this page https://localhost:8443/example/control/authview/findExampleAjax
and here you can see that the issue you found is not present.

I have seen that the issue in the page you point out. This is due to a wrong link that appears on ALL the pagination buttons.
For example the NEXT button has this link when the page is first loaded:

<a href="javascript:ajaxUpdateAreas('search-results,/accounting/control/FixedAssetSearchResults,fixedAssetName_op=like&noConditionFind=Y&fixedAssetId_op=like&fixedAssetName_ic=Y&fixedAssetId_ic=Y&VIEW_SIZE_2=20&VIEW_INDEX_2=1#')">Successivo</a>

and this link when the page is refreshed:

<a href="javascript:ajaxUpdateAreas('search-results,/accounting/control/FixedAssetSearchResults,VIEW_INDEX_2=1&fixedAssetName_op=like&VIEW_SIZE_2=20&noConditionFind=Y&fixedAssetId_op=like&fixedAssetName_ic=Y&fixedAssetId_ic=Y&VIEW_SIZE_1=20&VIEW_INDEX_1=1#')">Successivo</a>

As you can see there is something wrong with the VIEW_INDEX_x and VIEW_SIZE_x parameters.

The first link only contains VIEW_INDEX_2 and VIEW_SIZE_2 (and does not work),
the second link contains both VIEW_INDEX_1, VIEW_SIZE_1 and VIEW_INDEX_2, VIEW_SIZE_2.

Anybody can help here?

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3083:
-------------------------------

    Attachment: OFBIZ-3083 viewSizeSelector.patch

Please find attached an updated patch that solves what Bilgin has pointed out as #1.
Additionally I changed the template to show the "Displaying x-y out of z" string even if the javascript is disabled.

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771876#action_12771876 ]

Jacques Le Roux commented on OFBIZ-3083:
----------------------------------------

It works well in lookups now, I wonder though, as suggested Adrian, if we should not allow the user to enter the size her/he wants ?

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771906#action_12771906 ]

Bruno Busco commented on OFBIZ-3083:
------------------------------------

I think this could be a further improvement implemented at a later time.

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771925#action_12771925 ]

Jacques Le Roux commented on OFBIZ-3083:
----------------------------------------

I agree, we should open a new Jira for the point 2.

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772307#action_12772307 ]

Bruno Busco commented on OFBIZ-3083:
------------------------------------

I have reopened OFBIZ-1935 since this issue already deals with this kind of issue.

Do you think the patch can be committed now? ;-)

> Adding a page size selector in the pagination bar
> -------------------------------------------------
>
>                 Key: OFBIZ-3083
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3083
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch
>
>
> I find usefull to let the user change, on the ui, the actual number of elements contained in a page.
> This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages.
> Having this feature, the user can select 30 as page size, and have all elements in one page.
> In the attached patch there is a first try I am working on.
> This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements.
> Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled.
> What do you think about?
> Thank you,
> Bruno

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

12