[jira] Created: (OFBIZ-3099) PriceServices.calculateProductPrice should not process or return obsolete PriceRules

[Nicolas Malin (Jira)]

PriceServices.calculateProductPrice should not process or return obsolete PriceRules
------------------------------------------------------------------------------------

                 Key: OFBIZ-3099
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3099
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
            Reporter: Patrick Antivackis
             Fix For: SVN trunk


There is no filterByDate done on the allProductPriceRules returned line 559.
The consequences are that a findAllQuantityPrices=Y return a Map with some obsolete PriceRule
The calcPriceResultFromRules process some PriceRules that could be filtered before.

I don't see the point of returning all the PriceRules found when using findAllQuantityPrices=Y as this map is used to display active price quantity condition to the customer.

If the service do need to return all PriceRules, as it is today, the service should be updated in order to allow to specify if the returned list should be only active or all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Antivackis updated OFBIZ-3099:
--------------------------------------

    Attachment: Patch-OFBIZ-3099.txt

This patch add a filterByDate to the PriceRules obtained after the call to the makeProducePriceRuleList function

> PriceServices.calculateProductPrice should not process or return obsolete PriceRules
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3099
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3099
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Patrick Antivackis
>             Fix For: SVN trunk
>
>         Attachments: Patch-OFBIZ-3099.txt
>
>
> There is no filterByDate done on the allProductPriceRules returned line 559.
> The consequences are that a findAllQuantityPrices=Y return a Map with some obsolete PriceRule
> The calcPriceResultFromRules process some PriceRules that could be filtered before.
> I don't see the point of returning all the PriceRules found when using findAllQuantityPrices=Y as this map is used to display active price quantity condition to the customer.
> If the service do need to return all PriceRules, as it is today, the service should be updated in order to allow to specify if the returned list should be only active or all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770934#action_12770934 ]

Jacques Le Roux commented on OFBIZ-3099:
----------------------------------------

Hi Patrick,

I agree and can't neither see why to calculate obsolete prices.
So I commited your 1st patch in trunk at r830528. Do you intend to provide another patch for the service definition ? Else I will close, except if somebody see a trouble with this change or want to enhance the service definition...

> PriceServices.calculateProductPrice should not process or return obsolete PriceRules
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3099
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3099
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Patrick Antivackis
>             Fix For: SVN trunk
>
>         Attachments: Patch-OFBIZ-3099.txt
>
>
> There is no filterByDate done on the allProductPriceRules returned line 559.
> The consequences are that a findAllQuantityPrices=Y return a Map with some obsolete PriceRule
> The calcPriceResultFromRules process some PriceRules that could be filtered before.
> I don't see the point of returning all the PriceRules found when using findAllQuantityPrices=Y as this map is used to display active price quantity condition to the customer.
> If the service do need to return all PriceRules, as it is today, the service should be updated in order to allow to specify if the returned list should be only active or all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3099:
-----------------------------------

    Issue Type: Improvement  (was: Bug)

I did change from bug to improvment as I don't see really a bug here.

> PriceServices.calculateProductPrice should not process or return obsolete PriceRules
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3099
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3099
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Patrick Antivackis
>             Fix For: SVN trunk
>
>         Attachments: Patch-OFBIZ-3099.txt
>
>
> There is no filterByDate done on the allProductPriceRules returned line 559.
> The consequences are that a findAllQuantityPrices=Y return a Map with some obsolete PriceRule
> The calcPriceResultFromRules process some PriceRules that could be filtered before.
> I don't see the point of returning all the PriceRules found when using findAllQuantityPrices=Y as this map is used to display active price quantity condition to the customer.
> If the service do need to return all PriceRules, as it is today, the service should be updated in order to allow to specify if the returned list should be only active or all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770946#action_12770946 ]

Patrick Antivackis commented on OFBIZ-3099:
-------------------------------------------

Hello Jacques,
You can close the issue, i will provide another patch if it breaks something for someone.

I tagged the issue as a bug because returning obsolete prices was creating bug in display when you present the different prices by quantity for a product. But it's just a small bug, so improvement is ok for me too.

> PriceServices.calculateProductPrice should not process or return obsolete PriceRules
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3099
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3099
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Patrick Antivackis
>             Fix For: SVN trunk
>
>         Attachments: Patch-OFBIZ-3099.txt
>
>
> There is no filterByDate done on the allProductPriceRules returned line 559.
> The consequences are that a findAllQuantityPrices=Y return a Map with some obsolete PriceRule
> The calcPriceResultFromRules process some PriceRules that could be filtered before.
> I don't see the point of returning all the PriceRules found when using findAllQuantityPrices=Y as this map is used to display active price quantity condition to the customer.
> If the service do need to return all PriceRules, as it is today, the service should be updated in order to allow to specify if the returned list should be only active or all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3099:
-----------------------------------

    Affects Version/s: Release Branch 9.04
        Fix Version/s: Release Branch 9.04
           Issue Type: Bug  (was: Improvement)

Thanks Patrick for the bug detail, I changed it back to bug and will backport to 9.04

> PriceServices.calculateProductPrice should not process or return obsolete PriceRules
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3099
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3099
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Patrick Antivackis
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: Patch-OFBIZ-3099.txt
>
>
> There is no filterByDate done on the allProductPriceRules returned line 559.
> The consequences are that a findAllQuantityPrices=Y return a Map with some obsolete PriceRule
> The calcPriceResultFromRules process some PriceRules that could be filtered before.
> I don't see the point of returning all the PriceRules found when using findAllQuantityPrices=Y as this map is used to display active price quantity condition to the customer.
> If the service do need to return all PriceRules, as it is today, the service should be updated in order to allow to specify if the returned list should be only active or all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3099.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

In R9.04 at r830666

> PriceServices.calculateProductPrice should not process or return obsolete PriceRules
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3099
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3099
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: Patch-OFBIZ-3099.txt
>
>
> There is no filterByDate done on the allProductPriceRules returned line 559.
> The consequences are that a findAllQuantityPrices=Y return a Map with some obsolete PriceRule
> The calcPriceResultFromRules process some PriceRules that could be filtered before.
> I don't see the point of returning all the PriceRules found when using findAllQuantityPrices=Y as this map is used to display active price quantity condition to the customer.
> If the service do need to return all PriceRules, as it is today, the service should be updated in order to allow to specify if the returned list should be only active or all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.