[jira] Created: (OFBIZ-3100) Resolve java warnings exposed in Eclipse

[Nicolas Malin (Jira)]

Resolve java warnings exposed in Eclipse
----------------------------------------

                 Key: OFBIZ-3100
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3100
             Project: OFBiz
          Issue Type: Bug
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Bob Morley


There are over 9000 warnings reported when you do a build in Eclipse.  Let's clean them up!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771460#action_12771460 ]

Joe Eckard commented on OFBIZ-3100:
-----------------------------------

Very minor issue regarding import statements... these patches sort imports and remove blank lines. At some time long ago I believe the suggestion was to setup your IDE to produce something like:

java.*
<blank line>
javax.*
<blank line>
org.ofbiz.*
<blank line>
everything else

but I can't seem to find this info posted anywhere.

Looking through a random sampling of files, some follow that pattern while others do not... if there was / is a compelling reason to do things that way, then within this issue might be a good place to reformat.

> Resolve java warnings exposed in Eclipse
> ----------------------------------------
>
>                 Key: OFBIZ-3100
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3100
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>
> There are over 9000 warnings reported when you do a build in Eclipse.  Let's clean them up!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771477#action_12771477 ]

Marc Morin commented on OFBIZ-3100:
-----------------------------------

I just formatted using the built in Eclipse feature, haven't set it up any differently.  This likely points to needing to have a common Eclipse code style & error/warning profile as well.  

> Resolve java warnings exposed in Eclipse
> ----------------------------------------
>
>                 Key: OFBIZ-3100
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3100
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>
> There are over 9000 warnings reported when you do a build in Eclipse.  Let's clean them up!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773335#action_12773335 ]

Marc Morin commented on OFBIZ-3100:
-----------------------------------

Once we apply the patch for framework/entity.  Likely a number of warnings using EntityCondition.makeCondition() will go away... or we'll likely need to do a second pass.

Once we get the framework area patched, I will be happy to proceed into the other areas.

> Resolve java warnings exposed in Eclipse
> ----------------------------------------
>
>                 Key: OFBIZ-3100
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3100
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>
> There are over 9000 warnings reported when you do a build in Eclipse.  Let's clean them up!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773338#action_12773338 ]

Wickersheimer Jeremy commented on OFBIZ-3100:
---------------------------------------------

Should those patches be ported to 0904 ? I would be nice and maybe save some trouble when backporting future patches.

> Resolve java warnings exposed in Eclipse
> ----------------------------------------
>
>                 Key: OFBIZ-3100
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3100
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>
> There are over 9000 warnings reported when you do a build in Eclipse.  Let's clean them up!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773371#action_12773371 ]

Scott Gray commented on OFBIZ-3100:
-----------------------------------

Generally not, they represent code cleanups rather than bug fixes and 9.04 only gets the latter.

> Resolve java warnings exposed in Eclipse
> ----------------------------------------
>
>                 Key: OFBIZ-3100
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3100
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>
> There are over 9000 warnings reported when you do a build in Eclipse.  Let's clean them up!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773395#action_12773395 ]

Jacques Le Roux commented on OFBIZ-3100:
----------------------------------------

Hi Marc, Bob,

One little thing to note for future patches, please follow this advice from [OFBiz Contributors Best Practices|http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)] (<- hey, there is a link there ;))
<<Eclipse internal command (don't use finish and select project to avoid the 2 1st lines in the patch)>>

Thanks

> Resolve java warnings exposed in Eclipse
> ----------------------------------------
>
>                 Key: OFBIZ-3100
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3100
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>
> There are over 9000 warnings reported when you do a build in Eclipse.  Let's clean them up!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773529#action_12773529 ]

Adrian Crum commented on OFBIZ-3100:
------------------------------------

I don't have a problem with back porting these changes to R9.04. Also, David hinted that backporting these would not be a bad thing...

http://n4.nabble.com/Re-OFBIZ-3100-patches-td277961.html#a278069

> Resolve java warnings exposed in Eclipse
> ----------------------------------------
>
>                 Key: OFBIZ-3100
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3100
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>
> There are over 9000 warnings reported when you do a build in Eclipse.  Let's clean them up!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773641#action_12773641 ]

Scott Gray commented on OFBIZ-3100:
-----------------------------------

I'm not going to lose sleep over it but these changes do next to nothing to improve system stability (which is what the releases are all about) and every commit to the release branch carries a risk of introducing problems.  Bending the rules we've previously laid out also introduces a slippery slope problem.

> Resolve java warnings exposed in Eclipse
> ----------------------------------------
>
>                 Key: OFBIZ-3100
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3100
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>
> There are over 9000 warnings reported when you do a build in Eclipse.  Let's clean them up!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.