[jira] Created: (OFBIZ-3107) framework - entity

[Nicolas Malin (Jira)]

framework - entity
------------------

                 Key: OFBIZ-3107
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
             Project: OFBiz
          Issue Type: Sub-task
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Bob Morley




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marc Morin updated OFBIZ-3107:
------------------------------

    Attachment: OFBIZ-3107.patch

entity patch.  This was a more difficult one because of the partially parameterized generics in the condition evaluation.  

> framework - entity
> ------------------
>
>                 Key: OFBIZ-3107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3107.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778326#action_12778326 ]

Jacques Le Roux commented on OFBIZ-3107:
----------------------------------------

Hi Bob,

Could you please update, I get too much conflicts. I feared that, that's why I tried to commit then ASAP.

> framework - entity
> ------------------
>
>                 Key: OFBIZ-3107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3107.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marc Morin updated OFBIZ-3107:
------------------------------

    Attachment: OFBIZ-3107-take2.patch

redone to adjust for changes since last created

> framework - entity
> ------------------
>
>                 Key: OFBIZ-3107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3107-take2.patch, OFBIZ-3107.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3107.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Thanks Bob,

Your patch is in trunk at r881669  

> framework - entity
> ------------------
>
>                 Key: OFBIZ-3107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3107-take2.patch, OFBIZ-3107.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782020#action_12782020 ]

Jacques Le Roux commented on OFBIZ-3107:
----------------------------------------

Hi Bob,

What was the reason you uncomment the line below in your patch ?

Debug.logInfo(message, module);

Thanks

> framework - entity
> ------------------
>
>                 Key: OFBIZ-3107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3107-take2.patch, OFBIZ-3107.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782020#action_12782020 ]

Jacques Le Roux edited comment on OFBIZ-3107 at 11/24/09 5:34 PM:
------------------------------------------------------------------

Hi Bob,

What was the reason you uncommented the line below in your patch ?

Debug.logInfo(message, module);

Thanks

Edit :  ********* better grammar ***********

      was (Author: jacques.le.roux):
    Hi Bob,

What was the reason you uncomment the line below in your patch ?

Debug.logInfo(message, module);

Thanks
 

> framework - entity
> ------------------
>
>                 Key: OFBIZ-3107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3107-take2.patch, OFBIZ-3107.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782176#action_12782176 ]

Scott Gray commented on OFBIZ-3107:
-----------------------------------

Hi Jacques

I can answer this one, the line was most likely uncommented because the message string declared above the line was showing as unused by Eclipse, so to fix the warning the log line was uncommented.  I would recommend changing the logging level from info to verbose.

Regards
Scott

> framework - entity
> ------------------
>
>                 Key: OFBIZ-3107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3107-take2.patch, OFBIZ-3107.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782193#action_12782193 ]

Jacques Le Roux commented on OFBIZ-3107:
----------------------------------------

Thanks Scott,

This looks like a good answer, indeed. Another possibility would have been to comment all out, like in OFBIZ-1021.

> framework - entity
> ------------------
>
>                 Key: OFBIZ-3107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3107-take2.patch, OFBIZ-3107.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782374#action_12782374 ]

Jacques Le Roux commented on OFBIZ-3107:
----------------------------------------

Hi Scott,

Done as suggested at r884047  

> framework - entity
> ------------------
>
>                 Key: OFBIZ-3107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3107
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3107-take2.patch, OFBIZ-3107.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.