OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

29 messages Options

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

[ http://issues.apache.org/jira/browse/OFBIZ-311?page=all ]

Christian Geisert updated OFBIZ-311:
------------------------------------

Attachment: patch_ofbiz_fop-0.92upgrade-fix_xslfo.diff

This patch fixes problemes where FOP 0.92 is more strict about the interpretation of the XSL-FO 1.0 specification.
It can be commit without problems now as it doesn't break anything with FOP 0.20.5

> Upgrade the Apache FOP rendering engine from .20.5 to .92
> ---------------------------------------------------------
>
> Key: OFBIZ-311
> URL: http://issues.apache.org/jira/browse/OFBIZ-311
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Environment: Windows / Java 1.5
> Reporter: John Martin
> Attachments: fop-0.92-upgrade-patch.zip, patch_ofbiz_fop-0.92upgrade-fix_xslfo.diff
>
>
> Working on upgrading the FOP (http://xmlgraphics.apache.org/fop/) rendering engine used in ofBiz to generate PDF documents.
> We had the need to use more advanced layout functionality than what 0.20.5 offered. Version 0.92 offers a lot of improvements. From the apache site:
> * More than half of the codebase has been rewritten over the last three years. The code is relatively new and possibly not as stable as version 0.20.5 in every regard. But the code is quickly approaching production level, especially when you're happy with only PDF and PostScript output.
> * The API of FOP has changed considerably and is not backwards-compatible with version 0.20.5.
> * There have been changes to the end-user API between 0.91 beta and 0.92 beta. With version 0.92, the API is now considered stable. Some methods have been deprecated and will be removed with the next release. If you upgrade from 0.91 beta, you will need to adjust your Java code.
> * The new code is much more strict about the interpretation of the XSL-FO 1.0 specification. Things that worked fine in version 0.20.5 might start to produce warnings or even errors now. FOP 0.20.5 contains many bugs which have been corrected in the new code.
> NOTE:
> - The last bullet point was accurate and some of the fo.ftl templates were broken (i.e. invoicePDF.fo.ftl). <fo:table-row> must contain <fo:table-column> and <fo:table-column> must contain <fo:block>.
> - Rendering of images are now done at their "natural" size unless you use the properties content-width or content-height. The height and width attributes don't seem to have any effect on the rendering.
> - Some of the XSL-FO documentation that I read also recommended avoiding the use of 'px' (pixels) to define the size of objects since pixels is a screen resolution and may not translate well to other devices. They recommend using mm or in for dimensions.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-311?page=comments#action_12454456 ]

Jacopo Cappellato commented on OFBIZ-311:
-----------------------------------------

Thanks Christian,

your patch is in rev. 480724.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-311?page=all ]

Christian Geisert updated OFBIZ-311:
------------------------------------

Attachment: patch_ofbiz_fop-0.92upgrade.diff

These are are changes from John (with ASF header added and a toString() removed) and EmailServices.java ExamplePrintServices.java changed by me and the foToPdf-Method and service definition removed.

There seems to be no CLA on file for John.

The "low level" stuff from FOP should be used in only one class (will have a look a this later)

I haven't tested the following reports:
applications/manufacturing/webapp/manufacturing/reports/PackageContentsAndOrder.fo.ftl
applications/manufacturing/webapp/manufacturing/reports/PRunsProductsAndOrder.fo.ftl
applications/manufacturing/webapp/manufacturing/reports/PRunsInfoAndOrder.fo.ftl
applications/manufacturing/webapp/manufacturing/reports/PRunsProductsByFeature.fo.ftl
applications/manufacturing/webapp/manufacturing/reports/ShipmentPlanStockReport.fo.ftl
applications/manufacturing/webapp/manufacturing/reports/PRunsComponentsByFeature.fo.ftl
applications/manufacturing/webapp/manufacturing/reports/PRunsProductsStacks.fo.ftl
applications/manufacturing/webapp/manufacturing/reports/ShipmentWorkEffortTasks.fo.ftl
applications/manufacturing/webapp/manufacturing/reports/ShipmentLabel.fo.ftl

All the other reports are looking ok but of course there should be some more testing.

barcode4j-fop-ext-trunk-complete.jar is just a dev-snapshot but I just talked with Jeremias and there will be a new release soon.

> Upgrade the Apache FOP rendering engine from .20.5 to .92
> ---------------------------------------------------------
>
> Key: OFBIZ-311
> URL: http://issues.apache.org/jira/browse/OFBIZ-311
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Environment: Windows / Java 1.5
> Reporter: John Martin
> Attachments: fop-0.92-upgrade-patch.zip, patch_ofbiz_fop-0.92upgrade-fix_xslfo.diff, patch_ofbiz_fop-0.92upgrade.diff
>
>
> Working on upgrading the FOP (http://xmlgraphics.apache.org/fop/) rendering engine used in ofBiz to generate PDF documents.
> We had the need to use more advanced layout functionality than what 0.20.5 offered. Version 0.92 offers a lot of improvements. From the apache site:
> * More than half of the codebase has been rewritten over the last three years. The code is relatively new and possibly not as stable as version 0.20.5 in every regard. But the code is quickly approaching production level, especially when you're happy with only PDF and PostScript output.
> * The API of FOP has changed considerably and is not backwards-compatible with version 0.20.5.
> * There have been changes to the end-user API between 0.91 beta and 0.92 beta. With version 0.92, the API is now considered stable. Some methods have been deprecated and will be removed with the next release. If you upgrade from 0.91 beta, you will need to adjust your Java code.
> * The new code is much more strict about the interpretation of the XSL-FO 1.0 specification. Things that worked fine in version 0.20.5 might start to produce warnings or even errors now. FOP 0.20.5 contains many bugs which have been corrected in the new code.
> NOTE:
> - The last bullet point was accurate and some of the fo.ftl templates were broken (i.e. invoicePDF.fo.ftl). <fo:table-row> must contain <fo:table-column> and <fo:table-column> must contain <fo:block>.
> - Rendering of images are now done at their "natural" size unless you use the properties content-width or content-height. The height and width attributes don't seem to have any effect on the rendering.
> - Some of the XSL-FO documentation that I read also recommended avoiding the use of 'px' (pixels) to define the size of objects since pixels is a screen resolution and may not translate well to other devices. They recommend using mm or in for dimensions.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-311?page=all ]

Jacopo Cappellato reassigned OFBIZ-311:
---------------------------------------

Assignee: Jacopo Cappellato

> Upgrade the Apache FOP rendering engine from .20.5 to .92
> ---------------------------------------------------------
>
> Key: OFBIZ-311
> URL: http://issues.apache.org/jira/browse/OFBIZ-311
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Environment: Windows / Java 1.5
> Reporter: John Martin
> Assigned To: Jacopo Cappellato
> Attachments: fop-0.92-upgrade-patch.zip, patch_ofbiz_fop-0.92upgrade-fix_xslfo.diff, patch_ofbiz_fop-0.92upgrade.diff
>
>
> Working on upgrading the FOP (http://xmlgraphics.apache.org/fop/) rendering engine used in ofBiz to generate PDF documents.
> We had the need to use more advanced layout functionality than what 0.20.5 offered. Version 0.92 offers a lot of improvements. From the apache site:
> * More than half of the codebase has been rewritten over the last three years. The code is relatively new and possibly not as stable as version 0.20.5 in every regard. But the code is quickly approaching production level, especially when you're happy with only PDF and PostScript output.
> * The API of FOP has changed considerably and is not backwards-compatible with version 0.20.5.
> * There have been changes to the end-user API between 0.91 beta and 0.92 beta. With version 0.92, the API is now considered stable. Some methods have been deprecated and will be removed with the next release. If you upgrade from 0.91 beta, you will need to adjust your Java code.
> * The new code is much more strict about the interpretation of the XSL-FO 1.0 specification. Things that worked fine in version 0.20.5 might start to produce warnings or even errors now. FOP 0.20.5 contains many bugs which have been corrected in the new code.
> NOTE:
> - The last bullet point was accurate and some of the fo.ftl templates were broken (i.e. invoicePDF.fo.ftl). <fo:table-row> must contain <fo:table-column> and <fo:table-column> must contain <fo:block>.
> - Rendering of images are now done at their "natural" size unless you use the properties content-width or content-height. The height and width attributes don't seem to have any effect on the rendering.
> - Some of the XSL-FO documentation that I read also recommended avoiding the use of 'px' (pixels) to define the size of objects since pixels is a screen resolution and may not translate well to other devices. They recommend using mm or in for dimensions.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-311?page=comments#action_12455082 ]

Jacopo Cappellato commented on OFBIZ-311:
-----------------------------------------

Christian,

thanks for all your hard work.
No problem for the reports in the manufacturing component: they are there as examples of how you can pull data out of OFBiz and create manufacturing docs useful for the manufacturing facility but before they can really be used in production they'll need some serious customizations.

> Upgrade the Apache FOP rendering engine from .20.5 to .92
> ---------------------------------------------------------
>
> Key: OFBIZ-311
> URL: http://issues.apache.org/jira/browse/OFBIZ-311
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Environment: Windows / Java 1.5
> Reporter: John Martin
> Assigned To: Jacopo Cappellato
> Attachments: fop-0.92-upgrade-patch.zip, patch_ofbiz_fop-0.92upgrade-fix_xslfo.diff, patch_ofbiz_fop-0.92upgrade.diff
>
>
> Working on upgrading the FOP (http://xmlgraphics.apache.org/fop/) rendering engine used in ofBiz to generate PDF documents.
> We had the need to use more advanced layout functionality than what 0.20.5 offered. Version 0.92 offers a lot of improvements. From the apache site:
> * More than half of the codebase has been rewritten over the last three years. The code is relatively new and possibly not as stable as version 0.20.5 in every regard. But the code is quickly approaching production level, especially when you're happy with only PDF and PostScript output.
> * The API of FOP has changed considerably and is not backwards-compatible with version 0.20.5.
> * There have been changes to the end-user API between 0.91 beta and 0.92 beta. With version 0.92, the API is now considered stable. Some methods have been deprecated and will be removed with the next release. If you upgrade from 0.91 beta, you will need to adjust your Java code.
> * The new code is much more strict about the interpretation of the XSL-FO 1.0 specification. Things that worked fine in version 0.20.5 might start to produce warnings or even errors now. FOP 0.20.5 contains many bugs which have been corrected in the new code.
> NOTE:
> - The last bullet point was accurate and some of the fo.ftl templates were broken (i.e. invoicePDF.fo.ftl). <fo:table-row> must contain <fo:table-column> and <fo:table-column> must contain <fo:block>.
> - Rendering of images are now done at their "natural" size unless you use the properties content-width or content-height. The height and width attributes don't seem to have any effect on the rendering.
> - Some of the XSL-FO documentation that I read also recommended avoiding the use of 'px' (pixels) to define the size of objects since pixels is a screen resolution and may not translate well to other devices. They recommend using mm or in for dimensions.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-311?page=comments#action_12455083 ]

Jacopo Cappellato commented on OFBIZ-311:
-----------------------------------------

For all,

I'm applying and testing all this work. After that I'd like to commit it.
Is it ok for all to go on with this upgrade/refactoring (including the removal of the "foToPdf" service, defined in the content component but not used in the system)?

Jacopo

> Upgrade the Apache FOP rendering engine from .20.5 to .92
> ---------------------------------------------------------
>
> Key: OFBIZ-311
> URL: http://issues.apache.org/jira/browse/OFBIZ-311
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Environment: Windows / Java 1.5
> Reporter: John Martin
> Assigned To: Jacopo Cappellato
> Attachments: fop-0.92-upgrade-patch.zip, patch_ofbiz_fop-0.92upgrade-fix_xslfo.diff, patch_ofbiz_fop-0.92upgrade.diff
>
>
> Working on upgrading the FOP (http://xmlgraphics.apache.org/fop/) rendering engine used in ofBiz to generate PDF documents.
> We had the need to use more advanced layout functionality than what 0.20.5 offered. Version 0.92 offers a lot of improvements. From the apache site:
> * More than half of the codebase has been rewritten over the last three years. The code is relatively new and possibly not as stable as version 0.20.5 in every regard. But the code is quickly approaching production level, especially when you're happy with only PDF and PostScript output.
> * The API of FOP has changed considerably and is not backwards-compatible with version 0.20.5.
> * There have been changes to the end-user API between 0.91 beta and 0.92 beta. With version 0.92, the API is now considered stable. Some methods have been deprecated and will be removed with the next release. If you upgrade from 0.91 beta, you will need to adjust your Java code.
> * The new code is much more strict about the interpretation of the XSL-FO 1.0 specification. Things that worked fine in version 0.20.5 might start to produce warnings or even errors now. FOP 0.20.5 contains many bugs which have been corrected in the new code.
> NOTE:
> - The last bullet point was accurate and some of the fo.ftl templates were broken (i.e. invoicePDF.fo.ftl). <fo:table-row> must contain <fo:table-column> and <fo:table-column> must contain <fo:block>.
> - Rendering of images are now done at their "natural" size unless you use the properties content-width or content-height. The height and width attributes don't seem to have any effect on the rendering.
> - Some of the XSL-FO documentation that I read also recommended avoiding the use of 'px' (pixels) to define the size of objects since pixels is a screen resolution and may not translate well to other devices. They recommend using mm or in for dimensions.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-311?page=all ]

Jacopo Cappellato closed OFBIZ-311.
-----------------------------------

Resolution: Fixed

John, Christian,

thanks very much for all your work: this is a very important upgrade.
I've committed it with rev. 481558

Jacopo

> Upgrade the Apache FOP rendering engine from .20.5 to .92
> ---------------------------------------------------------
>
> Key: OFBIZ-311
> URL: http://issues.apache.org/jira/browse/OFBIZ-311
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Environment: Windows / Java 1.5
> Reporter: John Martin
> Assigned To: Jacopo Cappellato
> Attachments: fop-0.92-upgrade-patch.zip, patch_ofbiz_fop-0.92upgrade-fix_xslfo.diff, patch_ofbiz_fop-0.92upgrade.diff
>
>
> Working on upgrading the FOP (http://xmlgraphics.apache.org/fop/) rendering engine used in ofBiz to generate PDF documents.
> We had the need to use more advanced layout functionality than what 0.20.5 offered. Version 0.92 offers a lot of improvements. From the apache site:
> * More than half of the codebase has been rewritten over the last three years. The code is relatively new and possibly not as stable as version 0.20.5 in every regard. But the code is quickly approaching production level, especially when you're happy with only PDF and PostScript output.
> * The API of FOP has changed considerably and is not backwards-compatible with version 0.20.5.
> * There have been changes to the end-user API between 0.91 beta and 0.92 beta. With version 0.92, the API is now considered stable. Some methods have been deprecated and will be removed with the next release. If you upgrade from 0.91 beta, you will need to adjust your Java code.
> * The new code is much more strict about the interpretation of the XSL-FO 1.0 specification. Things that worked fine in version 0.20.5 might start to produce warnings or even errors now. FOP 0.20.5 contains many bugs which have been corrected in the new code.
> NOTE:
> - The last bullet point was accurate and some of the fo.ftl templates were broken (i.e. invoicePDF.fo.ftl). <fo:table-row> must contain <fo:table-column> and <fo:table-column> must contain <fo:block>.
> - Rendering of images are now done at their "natural" size unless you use the properties content-width or content-height. The height and width attributes don't seem to have any effect on the rendering.
> - Some of the XSL-FO documentation that I read also recommended avoiding the use of 'px' (pixels) to define the size of objects since pixels is a screen resolution and may not translate well to other devices. They recommend using mm or in for dimensions.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-311?page=comments#action_12455327 ]

Christian Geisert commented on OFBIZ-311:
-----------------------------------------

I'm happy to have a look at the manufacturing reports (at least to check if they work at all) if you tell me how to display them.

Could you please add "Developer snapshot from http://www.jeremias-maerki.ch/download/fop/barcode4j-fop-ext-trunk-complete.jar" in the
Notes column for barcode4j-fop-ext-0.92.jar on http://docs.ofbiz.org/display/OFBADMIN/Libraries+Included+in+OFBiz

What about moving http://docs.ofbiz.org/display/~jacopoc/Notes+on+XSL-FO+in+OFBiz to the general wiki so we can add information about upgrading fo-templates.

> Upgrade the Apache FOP rendering engine from .20.5 to .92
> ---------------------------------------------------------
>
> Key: OFBIZ-311
> URL: http://issues.apache.org/jira/browse/OFBIZ-311
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Environment: Windows / Java 1.5
> Reporter: John Martin
> Assigned To: Jacopo Cappellato
> Attachments: fop-0.92-upgrade-patch.zip, patch_ofbiz_fop-0.92upgrade-fix_xslfo.diff, patch_ofbiz_fop-0.92upgrade.diff
>
>
> Working on upgrading the FOP (http://xmlgraphics.apache.org/fop/) rendering engine used in ofBiz to generate PDF documents.
> We had the need to use more advanced layout functionality than what 0.20.5 offered. Version 0.92 offers a lot of improvements. From the apache site:
> * More than half of the codebase has been rewritten over the last three years. The code is relatively new and possibly not as stable as version 0.20.5 in every regard. But the code is quickly approaching production level, especially when you're happy with only PDF and PostScript output.
> * The API of FOP has changed considerably and is not backwards-compatible with version 0.20.5.
> * There have been changes to the end-user API between 0.91 beta and 0.92 beta. With version 0.92, the API is now considered stable. Some methods have been deprecated and will be removed with the next release. If you upgrade from 0.91 beta, you will need to adjust your Java code.
> * The new code is much more strict about the interpretation of the XSL-FO 1.0 specification. Things that worked fine in version 0.20.5 might start to produce warnings or even errors now. FOP 0.20.5 contains many bugs which have been corrected in the new code.
> NOTE:
> - The last bullet point was accurate and some of the fo.ftl templates were broken (i.e. invoicePDF.fo.ftl). <fo:table-row> must contain <fo:table-column> and <fo:table-column> must contain <fo:block>.
> - Rendering of images are now done at their "natural" size unless you use the properties content-width or content-height. The height and width attributes don't seem to have any effect on the rendering.
> - Some of the XSL-FO documentation that I read also recommended avoiding the use of 'px' (pixels) to define the size of objects since pixels is a screen resolution and may not translate well to other devices. They recommend using mm or in for dimensions.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-311) Upgrade the Apache FOP rendering engine from .20.5 to .92

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-311?page=comments#action_12455338 ]

Jacopo Cappellato commented on OFBIZ-311:
-----------------------------------------

Christian,

I've updated the Libraries page and moved my notes about XSL-FO to the Wiki space.
About the manufacturing reports: I'd really don't mind about them now.

Thanks for your great help

> Upgrade the Apache FOP rendering engine from .20.5 to .92
> ---------------------------------------------------------
>
> Key: OFBIZ-311
> URL: http://issues.apache.org/jira/browse/OFBIZ-311
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Environment: Windows / Java 1.5
> Reporter: John Martin
> Assigned To: Jacopo Cappellato
> Attachments: fop-0.92-upgrade-patch.zip, patch_ofbiz_fop-0.92upgrade-fix_xslfo.diff, patch_ofbiz_fop-0.92upgrade.diff
>
>
> Working on upgrading the FOP (http://xmlgraphics.apache.org/fop/) rendering engine used in ofBiz to generate PDF documents.
> We had the need to use more advanced layout functionality than what 0.20.5 offered. Version 0.92 offers a lot of improvements. From the apache site:
> * More than half of the codebase has been rewritten over the last three years. The code is relatively new and possibly not as stable as version 0.20.5 in every regard. But the code is quickly approaching production level, especially when you're happy with only PDF and PostScript output.
> * The API of FOP has changed considerably and is not backwards-compatible with version 0.20.5.
> * There have been changes to the end-user API between 0.91 beta and 0.92 beta. With version 0.92, the API is now considered stable. Some methods have been deprecated and will be removed with the next release. If you upgrade from 0.91 beta, you will need to adjust your Java code.
> * The new code is much more strict about the interpretation of the XSL-FO 1.0 specification. Things that worked fine in version 0.20.5 might start to produce warnings or even errors now. FOP 0.20.5 contains many bugs which have been corrected in the new code.
> NOTE:
> - The last bullet point was accurate and some of the fo.ftl templates were broken (i.e. invoicePDF.fo.ftl). <fo:table-row> must contain <fo:table-column> and <fo:table-column> must contain <fo:block>.
> - Rendering of images are now done at their "natural" size unless you use the properties content-width or content-height. The height and width attributes don't seem to have any effect on the rendering.
> - Some of the XSL-FO documentation that I read also recommended avoiding the use of 'px' (pixels) to define the size of objects since pixels is a screen resolution and may not translate well to other devices. They recommend using mm or in for dimensions.