[jira] Created: (OFBIZ-3151) fix for using "equals" operator with null field in performFind service.

[Nicolas Malin (Jira)]

fix for using "equals" operator with null field in performFind service.
-----------------------------------------------------------------------

                 Key: OFBIZ-3151
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
            Reporter: Chatree Srichart
             Fix For: SVN trunk
         Attachments: FindServices.java.diff

Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chatree Srichart updated OFBIZ-3151:
------------------------------------

    Attachment: FindServices.java.diff

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773527#action_12773527 ]

Jacques Le Roux commented on OFBIZ-3151:
----------------------------------------

Hi Chatree,

Could you explain please how you use null field in performFind service ?

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773855#action_12773855 ]

Chatree Srichart edited comment on OFBIZ-3151 at 11/5/09 9:33 AM:
------------------------------------------------------------------

I would like to look up parties which have empty statusId field.
I use performFind service included condition...
....
<set field="parameters.statusId" from-field="nullField"/>
<set field="parameters.statusId_op" value="equals"/>
....
<service service-name="performFind" result-map="result" result-map-list="listIt">
<field-map field-name="inputFields" from-field="parameters"/>
....

But It doesn' t accepted anything.

      was (Author: chatree):
    I would like to look up parties which have empty statusId field.
I use performFind service included condition...
....
<set field="parameters.statusId" from-field="nullField"/>
<set field="parameters.statusId_op" value="equals"/>
....
<service service-name="performFind" result-map="result" result-map-list="listIt">
<field-map field-name="inputFields" from-field="parameters"/>
....

But I don' t accepted anything.
 

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773855#action_12773855 ]

Chatree Srichart commented on OFBIZ-3151:
-----------------------------------------

I would like to look up parties which have empty statusId field.
I use performFind service included condition...
....
<set field="parameters.statusId" from-field="nullField"/>
<set field="parameters.statusId_op" value="equals"/>
....
<service service-name="performFind" result-map="result" result-map-list="listIt">
<field-map field-name="inputFields" from-field="parameters"/>
....

But I don' t accepted anything.

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773858#action_12773858 ]

Scott Gray commented on OFBIZ-3151:
-----------------------------------

Have you tried this:
<set field="parameters.statusId_op" value="empty"/>

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781574#action_12781574 ]

Jacques Le Roux commented on OFBIZ-3151:
----------------------------------------

Hi Chatree,

Should we close ?

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-3151.
------------------------------

    Resolution: Fixed

Thanks for your contribution, Committed revision 883525.

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781850#action_12781850 ]

Jacques Le Roux commented on OFBIZ-3151:
----------------------------------------

Hi Hans, Chatree,

So "empty" did not work ?

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782153#action_12782153 ]

Scott Gray commented on OFBIZ-3151:
-----------------------------------

Jira issues and patches are pretty pointless if reviews and comments are going to be ignored

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782168#action_12782168 ]

Jacques Le Roux commented on OFBIZ-3151:
----------------------------------------

+1 on Scott's comment (!)

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782215#action_12782215 ]

Hans Bakker commented on OFBIZ-3151:
------------------------------------

we missed your message scott and we wil look into it....

Regards,
Hans

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782285#action_12782285 ]

Chatree Srichart commented on OFBIZ-3151:
-----------------------------------------

Hi Scott, Jacques

using "empty" is work fine but I think

....
<set field="parameters.statusId" from-field="nullField"/>
<set field="parameters.statusId_op" value="equals"/>
....

should work too.
If you do not think about that, I am OK.

Regards,
Chatree

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782292#action_12782292 ]

Scott Gray commented on OFBIZ-3151:
-----------------------------------

Hi Chatree,

Does that actually work though? As far as I can tell the string representation of GenericEntity.NULL_FIELD is "[null-field]" and not "nullField".

Assuming it does work, is it really worth adding something that is more verbose than the existing method but achieves the exact same thing?
Do you really prefer:
<set field="parameters.statusId" from-field="nullField"/> <!-- or [null-field] -->
<set field="parameters.statusId_op" value="equals"/>
over this:
<set field="parameters.statusId_op" value="empty"/>

If you do that is fine, go ahead and leave it in there, it's entirely up to you and Hans.

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782350#action_12782350 ]

Jacques Le Roux commented on OFBIZ-3151:
----------------------------------------

Chatree, Scott,

Yes, but what if someone prefer "null" tomorrow, etc.? Should we not avoid redundancy which we now may lead to inconsistency?
And I'm sure one day someone whill ask the differnce between nullField and empty...

I'd prefer to revert

> fix for using "equals" operator with null field in performFind service.
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3151
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3151
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chatree Srichart
>             Fix For: SVN trunk
>
>         Attachments: FindServices.java.diff
>
>
> Because I can not use "equals" operator with null field in performFind service. So I fixed for use one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.