OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3161) We should check that the thru date is not older than the from date

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3161) We should check that the thru date is not older than the from date

We should check that the thru date is not older than the from date
------------------------------------------------------------------

Key: OFBIZ-3161
URL: https://issues.apache.org/jira/browse/OFBIZ-3161
Project: OFBiz
Issue Type: Improvement
Components: ALL APPLICATIONS
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Priority: Trivial
Fix For: SVN trunk

In any places we use a from and thru dates, we should check that the thru date is not older than the from date

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3161) We should check that the thru date is not older than the from date

[ https://issues.apache.org/jira/browse/OFBIZ-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3161:
--------------------------------------

Assignee: Jacques Le Roux

> We should check that the thru date is not older than the from date
> ------------------------------------------------------------------
>
> Key: OFBIZ-3161
> URL: https://issues.apache.org/jira/browse/OFBIZ-3161
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
>
> In any places we use a from and thru dates, we should check that the thru date is not older than the from date

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3161) We should check that the thru date is not older than the from date

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-3161:
------------------------------

Attachment: OFBIZ-3161.patch

Hello All,

This is something needed at many places , i created a patch in jquery and as i tested at many places its working fine . Currently the code is specific to fields having name "fromDate" and "thruDate", further we can improve the code and make it generic.

The patch is a sample and we can improve it further.

Thanks & Regards
Ankit Jain :)

> We should check that the thru date is not older than the from date
> ------------------------------------------------------------------
>
> Key: OFBIZ-3161
> URL: https://issues.apache.org/jira/browse/OFBIZ-3161
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3161.patch
>
>
> In any places we use a from and thru dates, we should check that the thru date is not older than the from date

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3161) We should check that the thru date is not older than the from date

In reply to this post by Nicolas Malin (Jira)

> We should check that the thru date is not older than the from date
> ------------------------------------------------------------------
>
> Key: OFBIZ-3161
> URL: https://issues.apache.org/jira/browse/OFBIZ-3161
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3161.patch, OFBIZ-3161.patch
>
>
> In any places we use a from and thru dates, we should check that the thru date is not older than the from date

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3161) We should check that the thru date is not older than the from date

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901000#action_12901000 ]

Jacques Le Roux commented on OFBIZ-3161:
----------------------------------------

Looks good so far Ankit (just reviewed for now)

Could you have a look at the error message i18n issue please? How do you envision to make the code generic, could you explain? (I can see very easy solutions by quering all possible date field through id (if date is in) or CSS, etc. but I can't find a completely generic solution...)

Thanks

> We should check that the thru date is not older than the from date
> ------------------------------------------------------------------
>
> Key: OFBIZ-3161
> URL: https://issues.apache.org/jira/browse/OFBIZ-3161
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3161.patch, OFBIZ-3161.patch
>
>
> In any places we use a from and thru dates, we should check that the thru date is not older than the from date

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3161) We should check that the thru date is not older than the from date

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901024#action_12901024 ]

Ankit Jain commented on OFBIZ-3161:
-----------------------------------

Hello Jacques,

Thanks to look into it , i'll upadte my patch for error message, Jacques in our form-widget the ids are auto generated and is something like "formName_fieldName" , so how could you query through ids.

Currently the code is handling two field FromDate and ThruDate , but it may be possible if anyone want to use it for WorkEffort StartDate and EndDate than? so i talked about generalised solution .

As we do in ftls we add a class for field and in js we can fetch fields that have our class and do the operations accordingly , that something i was saying and if possible we'll apply here , So anyone can use for checking two date fields which have different names.

Its weekend so i'll try it on Monday. Happy Weekend....

Thanks & Regards
Ankit Jain

> We should check that the thru date is not older than the from date
> ------------------------------------------------------------------
>
> Key: OFBIZ-3161
> URL: https://issues.apache.org/jira/browse/OFBIZ-3161
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3161.patch, OFBIZ-3161.patch
>
>
> In any places we use a from and thru dates, we should check that the thru date is not older than the from date

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3161) We should check that the thru date is not older than the from date

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902549#action_12902549 ]

Jacques Le Roux commented on OFBIZ-3161:
----------------------------------------

Ankit,

Just a tip: for the error message, you could maybe have something like in ajaxSubmitFormUpdateAreas with data._ERROR_MESSAGE_
if (data._ERROR_MESSAGE_LIST_ != undefined || data._ERROR_MESSAGE_ != undefined)
but not sure from where and how the data._ERROR_MESSAGE_ content should come...

> We should check that the thru date is not older than the from date
> ------------------------------------------------------------------
>
> Key: OFBIZ-3161
> URL: https://issues.apache.org/jira/browse/OFBIZ-3161
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3161.patch, OFBIZ-3161.patch
>
>
> In any places we use a from and thru dates, we should check that the thru date is not older than the from date

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.