[jira] Created: (OFBIZ-320) Party Manager: Relationships: Add Relationship: Better role type dropdown
Locked
[jira] Created: (OFBIZ-320) Party Manager: Relationships: Add Relationship: Better role type dropdown
 
|
Party Manager: Relationships: Add Relationship: Better role type dropdown
------------------------------------------------------------------------- Key: OFBIZ-320 URL: http://issues.apache.org/jira/browse/OFBIZ-320 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: party Affects Versions: SVN trunk Environment: Any. I am using JDK1.5 + MySQL 5.0 on Ubuntu 6.06 and Win XP. Reporter: Cameron Smith Priority: Trivial Attachments: 1566388.patch This post is a followup to a discussion with Si Chen on the OpenTAPS General Users Forum. https://sourceforge.net/forum/forum.php?thread_id=1566388&forum_id=487771 Currently there are 4 dropdowns on this screen, which show a list of all Role Types in the system, when in fact the underlying schema will only accept Role Types which the parties in question already have. For 2 of these dropdowns, the session already knows the party involved, so the attached patch makes the dropdown present only the available RoleTypes. Much easier to use, and eliminates chance of getting a grotty error message when you submit. For the other 2 lists, either improve the error messages (see my original post on the forum), or use Ajax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-320) Party Manager: Relationships: Add Relationship: Better role type dropdown
|
|
[ http://issues.apache.org/jira/browse/OFBIZ-320?page=all ]
Cameron Smith updated OFBIZ-320: -------------------------------- Attachment: 1566388.patch Patch against SVN Trunk for the improvements to the 2 dropdowns. I suspect the root dir of the patch is not correct - please note that with the rather poor inet connection where I am, it is a v. timeconsuming job to check out the whole OfBiz source, so for this patch I only checked out applications/party > Party Manager: Relationships: Add Relationship: Better role type dropdown > ------------------------------------------------------------------------- > > Key: OFBIZ-320 > URL: http://issues.apache.org/jira/browse/OFBIZ-320 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Any. I am using JDK1.5 + MySQL 5.0 on Ubuntu 6.06 and Win XP. > Reporter: Cameron Smith > Priority: Trivial > Attachments: 1566388.patch > > > This post is a followup to a discussion with Si Chen on the OpenTAPS General Users Forum. https://sourceforge.net/forum/forum.php?thread_id=1566388&forum_id=487771 > Currently there are 4 dropdowns on this screen, which show a list of all Role Types in the system, when in fact the underlying schema will only accept Role Types which the parties in question already have. For 2 of these dropdowns, the session already knows the party involved, so the attached patch makes the dropdown present only the available RoleTypes. Much easier to use, and eliminates chance of getting a grotty error message when you submit. > For the other 2 lists, either improve the error messages (see my original post on the forum), or use Ajax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Assigned: (OFBIZ-320) Party Manager: Relationships: Add Relationship: Better role type dropdown
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-320?page=all ]
Jacques Le Roux reassigned OFBIZ-320: ------------------------------------- Assignee: Jacques Le Roux > Party Manager: Relationships: Add Relationship: Better role type dropdown > ------------------------------------------------------------------------- > > Key: OFBIZ-320 > URL: http://issues.apache.org/jira/browse/OFBIZ-320 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Any. I am using JDK1.5 + MySQL 5.0 on Ubuntu 6.06 and Win XP. > Reporter: Cameron Smith > Assigned To: Jacques Le Roux > Priority: Trivial > Attachments: 1566388.patch > > > This post is a followup to a discussion with Si Chen on the OpenTAPS General Users Forum. https://sourceforge.net/forum/forum.php?thread_id=1566388&forum_id=487771 > Currently there are 4 dropdowns on this screen, which show a list of all Role Types in the system, when in fact the underlying schema will only accept Role Types which the parties in question already have. For 2 of these dropdowns, the session already knows the party involved, so the attached patch makes the dropdown present only the available RoleTypes. Much easier to use, and eliminates chance of getting a grotty error message when you submit. > For the other 2 lists, either improve the error messages (see my original post on the forum), or use Ajax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Closed: (OFBIZ-320) Party Manager: Relationships: Add Relationship: Better role type dropdown
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-320?page=all ]
Jacques Le Roux closed OFBIZ-320. --------------------------------- Fix Version/s: SVN trunk Resolution: Fixed Thanks Cameron for you patch. It is committed in revision 447898. Just 2 points : . Please avoid tabs in files. For this if you use Eclipse you may use plugins for your ftl and xml files (I'd recommend respectively Hudson Freemarker and XML Buddy). And of course dont forget to check options "use spaces for tabs" (for Java files too) in Eclipse/WIndows/Preferences. Mmm... I checked : Freemarker plugin isn't able to manage tabs to spaces, but it's a good tool that apart. . I understand your Internet connection problem but if possible try to use relative pathes in patch and not absolute (eg not C:/local/workspace/ofbiz_party/widget/partymgr/PartyScreens.xml but applications/party/widget/partymgr/PartyScreens.xml Even without tools, all above is doable by hand (I know I did it ;o) Anyway thanks > Party Manager: Relationships: Add Relationship: Better role type dropdown > ------------------------------------------------------------------------- > > Key: OFBIZ-320 > URL: http://issues.apache.org/jira/browse/OFBIZ-320 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Any. I am using JDK1.5 + MySQL 5.0 on Ubuntu 6.06 and Win XP. > Reporter: Cameron Smith > Assigned To: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: 1566388.patch > > > This post is a followup to a discussion with Si Chen on the OpenTAPS General Users Forum. https://sourceforge.net/forum/forum.php?thread_id=1566388&forum_id=487771 > Currently there are 4 dropdowns on this screen, which show a list of all Role Types in the system, when in fact the underlying schema will only accept Role Types which the parties in question already have. For 2 of these dropdowns, the session already knows the party involved, so the attached patch makes the dropdown present only the available RoleTypes. Much easier to use, and eliminates chance of getting a grotty error message when you submit. > For the other 2 lists, either improve the error messages (see my original post on the forum), or use Ajax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-320) Party Manager: Relationships: Add Relationship: Better role type dropdown
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-320?page=comments#action_12436002 ]
Cameron Smith commented on OFBIZ-320: ------------------------------------- Thanks for the tips Jacques. In fact I had considered altering the paths by hand, just it wasn't clear from Si's post what the correct format was. Happy to do this in future from now on. Tabs/Spaces - sorry, hehe. Si's post is v. clear on this point!! My Eclipse has that configured, but I did this fix in Textpad, as ain't got OfBiz running in Eclipse yet. > Party Manager: Relationships: Add Relationship: Better role type dropdown > ------------------------------------------------------------------------- > > Key: OFBIZ-320 > URL: http://issues.apache.org/jira/browse/OFBIZ-320 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Any. I am using JDK1.5 + MySQL 5.0 on Ubuntu 6.06 and Win XP. > Reporter: Cameron Smith > Assigned To: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: 1566388.patch > > > This post is a followup to a discussion with Si Chen on the OpenTAPS General Users Forum. https://sourceforge.net/forum/forum.php?thread_id=1566388&forum_id=487771 > Currently there are 4 dropdowns on this screen, which show a list of all Role Types in the system, when in fact the underlying schema will only accept Role Types which the parties in question already have. For 2 of these dropdowns, the session already knows the party involved, so the attached patch makes the dropdown present only the available RoleTypes. Much easier to use, and eliminates chance of getting a grotty error message when you submit. > For the other 2 lists, either improve the error messages (see my original post on the forum), or use Ajax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-320) Party Manager: Relationships: Add Relationship: Better role type dropdown
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-320?page=comments#action_12436033 ]
Si Chen commented on OFBIZ-320: ------------------------------- Cameron, Thanks for your patch and for contributing. I just checked http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices, and I did put: For consistency, please make your patch files from the ofbiz/ directory. How could I make it more clear in the future? Si > Party Manager: Relationships: Add Relationship: Better role type dropdown > ------------------------------------------------------------------------- > > Key: OFBIZ-320 > URL: http://issues.apache.org/jira/browse/OFBIZ-320 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Any. I am using JDK1.5 + MySQL 5.0 on Ubuntu 6.06 and Win XP. > Reporter: Cameron Smith > Assigned To: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: 1566388.patch > > > This post is a followup to a discussion with Si Chen on the OpenTAPS General Users Forum. https://sourceforge.net/forum/forum.php?thread_id=1566388&forum_id=487771 > Currently there are 4 dropdowns on this screen, which show a list of all Role Types in the system, when in fact the underlying schema will only accept Role Types which the parties in question already have. For 2 of these dropdowns, the session already knows the party involved, so the attached patch makes the dropdown present only the available RoleTypes. Much easier to use, and eliminates chance of getting a grotty error message when you submit. > For the other 2 lists, either improve the error messages (see my original post on the forum), or use Ajax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-320) Party Manager: Relationships: Add Relationship: Better role type dropdown
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-320?page=comments#action_12436051 ]
Cameron Smith commented on OFBIZ-320: ------------------------------------- Hi Si, I did read that part, but I wasn't sure that you wanted relative paths. I reckon that the following wording might be clearer... " For consistency, please make your paths relative to the OFBIZ_HOME directory (the directory corresponding to the SVN URL: http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/ ). Here are some example paths in the correct format: applications/party/widget/partymgr/PartyScreens.xml framework/webtools/config/WebtoolsErrorUiLabels.properties " > Party Manager: Relationships: Add Relationship: Better role type dropdown > ------------------------------------------------------------------------- > > Key: OFBIZ-320 > URL: http://issues.apache.org/jira/browse/OFBIZ-320 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Any. I am using JDK1.5 + MySQL 5.0 on Ubuntu 6.06 and Win XP. > Reporter: Cameron Smith > Assigned To: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: 1566388.patch > > > This post is a followup to a discussion with Si Chen on the OpenTAPS General Users Forum. https://sourceforge.net/forum/forum.php?thread_id=1566388&forum_id=487771 > Currently there are 4 dropdowns on this screen, which show a list of all Role Types in the system, when in fact the underlying schema will only accept Role Types which the parties in question already have. For 2 of these dropdowns, the session already knows the party involved, so the attached patch makes the dropdown present only the available RoleTypes. Much easier to use, and eliminates chance of getting a grotty error message when you submit. > For the other 2 lists, either improve the error messages (see my original post on the forum), or use Ajax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-320) Party Manager: Relationships: Add Relationship: Better role type dropdown
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-320?page=comments#action_12436085 ]
Si Chen commented on OFBIZ-320: ------------------------------- ok. thanks for letting me know. i changed it. > Party Manager: Relationships: Add Relationship: Better role type dropdown > ------------------------------------------------------------------------- > > Key: OFBIZ-320 > URL: http://issues.apache.org/jira/browse/OFBIZ-320 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Any. I am using JDK1.5 + MySQL 5.0 on Ubuntu 6.06 and Win XP. > Reporter: Cameron Smith > Assigned To: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: 1566388.patch > > > This post is a followup to a discussion with Si Chen on the OpenTAPS General Users Forum. https://sourceforge.net/forum/forum.php?thread_id=1566388&forum_id=487771 > Currently there are 4 dropdowns on this screen, which show a list of all Role Types in the system, when in fact the underlying schema will only accept Role Types which the parties in question already have. For 2 of these dropdowns, the session already knows the party involved, so the attached patch makes the dropdown present only the available RoleTypes. Much easier to use, and eliminates chance of getting a grotty error message when you submit. > For the other 2 lists, either improve the error messages (see my original post on the forum), or use Ajax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |